IETF Logo Mail Archive

Re: [Gen-art] Gen-ART review of draft-ietf-pals-vccv-for-gal-05

"Andrew G. Malis" <agmalis@gmail.com> Sat, 12 September 2015 18:05 UTC

Return-Path: <agmalis@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 003E21B33B3 for <gen-art@ietfa.amsl.com>; Sat, 12 Sep 2015 11:05:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dGS9tEmHeMFW for <gen-art@ietfa.amsl.com>; Sat, 12 Sep 2015 11:05:25 -0700 (PDT)
Received: from mail-wi0-x235.google.com (mail-wi0-x235.google.com [IPv6:2a00:1450:400c:c05::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A74B21B339C for <gen-art@ietf.org>; Sat, 12 Sep 2015 11:05:24 -0700 (PDT)
Received: by wiclk2 with SMTP id lk2so89564439wic.1 for <gen-art@ietf.org>; Sat, 12 Sep 2015 11:05:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=fudciR9cDdE+rR/rr40JRt2mrpFXRVNBiyc258MsLHQ=; b=aR4DTNu0JiIc8zR1xHeWmjypW4bdLcEUQ2D84Ii2vgqb38i6F916tKulgkUMPtnJxv 2FT2wA18F3557MlPK2AKlK2ht8cPAyor/Z52YE9Oe2kqd1JP8OShwT+lRbgFUVA/a3o4 sIJQ6Wse6hOnu7yB7ts7Z1o99tTvcmgZBaf3h1sBjWZN9QhDiI4UO6pwAuj8jCI57Kjc 2p9uHg1EiGqAH/ywB9Cs6F1LmVMvvi3p+Pn+C8/9ApZMl+TxwCvDCv6t9Ru+5WNyKeoi bCTKt/zK+Ff0Yj8Y36YT793NLx3UsShJSi7YavQ2aeCTP9QksoF7nvlXl1MgRnqAKKMl 8Dew==
X-Received: by 10.194.117.133 with SMTP id ke5mr9908327wjb.116.1442081123162; Sat, 12 Sep 2015 11:05:23 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.28.211.68 with HTTP; Sat, 12 Sep 2015 11:05:03 -0700 (PDT)
In-Reply-To: <9904FB1B0159DA42B0B887B7FA8119CA5CB128F5@AZ-FFEXMB04.global.avaya.com>
References: <9904FB1B0159DA42B0B887B7FA8119CA5CB128F5@AZ-FFEXMB04.global.avaya.com>
From: "Andrew G. Malis" <agmalis@gmail.com>
Date: Sat, 12 Sep 2015 14:05:03 -0400
Message-ID: <CAA=duU2=NWnU4JhKWWO-i5yJYGcPdMqYLrxHhPRZGSH_6wCVjA@mail.gmail.com>
To: "Romascanu, Dan (Dan)" <dromasca@avaya.com>
Content-Type: multipart/alternative; boundary="001a1130d396156229051f90ad07"
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/nJnWD-X_mI9-0h2Iuy3hmZzVGWY>
Cc: "draft-ietf-pals-vccv-for-gal.all@tools.ietf.org" <draft-ietf-pals-vccv-for-gal.all@tools.ietf.org>, General Area Review Team <gen-art@ietf.org>
Subject: Re: [Gen-art] Gen-ART review of draft-ietf-pals-vccv-for-gal-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Sep 2015 18:05:27 -0000

Dan,

Thanks for the review, it's greatly appreciated!

Cheers,
Andy

On Fri, Sep 4, 2015 at 11:00 AM, Romascanu, Dan (Dan) <dromasca@avaya.com>
wrote:

> I am the assigned Gen-ART reviewer for this draft. The General Area Review
> Team (Gen-ART) reviews all IETF documents being processed by the IESG for
> the IETF Chair.  Please treat these comments just like any other last call
> comments.
>
>
>
> For more information, please see the FAQ at
>
>
>
> http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq
>
>
>
> Document: draft-ietf-pals-vccv-for-gal-05
>
> Reviewer: Dan Romascanu
>
> Review Date: 9/4/15
>
> IETF LC End Date:
>
> IESG Telechat date:
>
>
>
> Summary: this document is ready with minor issues
>
>
>
> Major issues:
>
>
>
> None
>
>
>
> Minor issues:
>
>
>
> 1.       Section 3 includes the following text:
>
>
>
>    When the PW CW is not used, the Type 4 MPLS VCCV Control Channel (CC)
>
>    type defined in this section MAY be used.  This is referred to as
>
>    VCCV CC Type4 throughout the rest of this of this document.  VCCV
>
>    Type 4 uses the encapsulation shown in Figure 1 in which the presence
>
>    of a GAL at the end of the MPLS label stack indicates that the packet
>
>    carries a VCCV message.
>
>
>
> Two issues here:
>
> -          Line 3 includes a disturbing typo as the type is referred to
> in the rest of the document as ‘VCCV CC Type 4’ (with a space)
>
> -          I understand the MAY in the second line to be directed to the
> implementers and this is fine. However, what about the operators who own
> network devices that have implemented this option? From reading the first
> section I indirectly get that the operators SHOULD activate this option.
> Maybe a separate paragraph can include this recommendation.
>
>
>
> 2.       Manageability Considerations – is there a requirement for all
> devices in a given network to activate the new type support, or a mix of
> routers supporting and not-supporting this option does not cause a problem?
>
> 3.       Section 9.1 – I assume that at publication Bit X (0x0Y) is
> supposed to be changed to Bit 3 (0x08)
>
>
>
> Regards,
>
>
>
> Dan
>
>
>

v2.23.0 | Report a Bug | By Email