Re: [Gen-art] Genart last call review of draft-ietf-tsvwg-sctp-ndata-12

Stewart Bryant <stewart.bryant@gmail.com> Fri, 25 August 2017 11:28 UTC

Return-Path: <stewart.bryant@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 174F81321A1; Fri, 25 Aug 2017 04:28:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id er3Dz8qP_1Uf; Fri, 25 Aug 2017 04:28:29 -0700 (PDT)
Received: from mail-wr0-x233.google.com (mail-wr0-x233.google.com [IPv6:2a00:1450:400c:c0c::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 743D9132B9F; Fri, 25 Aug 2017 04:28:28 -0700 (PDT)
Received: by mail-wr0-x233.google.com with SMTP id a47so6451027wra.4; Fri, 25 Aug 2017 04:28:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=YHyGruDpP2hv76A84vBLPrM5pzmvi07akeqBeS0aBJA=; b=Fs2dwCoc9DkufOZgYbYUBVQK4G8qxdJTI8ElvsT9dRVnTtEVC/8fpoKss9HIOBs42J xxsMkXcvy0SMEnWrLeK8bg4ysb5BgoiVmtRr0kaKWQXQecO2SLZZNq4UXfXVhxcYbaiK d+XSZxTd6Nm127Gi8bjdeSgfzLX+04vZsiTHHfAnFwk4BNE4PjJedy/AuDOhUZsI2Nd3 3vrSGBmmni4Fk2Rl18k/PUYarxTcaWsT6yRECGAvE05Qv0QvZ8AI3/D1GUxJrlHIefUm QmfA1yvc4Qy3OXoItRSxOQWoMrzFnjon62H6YvXNs8V3N0F+nOs4o4F7i3fJ9YisgR4G u+bQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=YHyGruDpP2hv76A84vBLPrM5pzmvi07akeqBeS0aBJA=; b=dnZeXjvgpq/6Mba9jetLBlLWMmbu1LfETN999K2Fox8ZmO70Odwvqw7TOtJIP8YYTi BbBWsCD9IRaEKataHut+wNp8EJGZIXgP7iv0ySLQRbhCuWQJmBNMJ11o11IhYxBBlQ6b wW5qpquw8zpqBLoeJzbeI6a7JZ2eBajVhq0JWM7ZoyWpWeoJWU0xoI7eD/3LIi1xLIM6 AEkKRuraryTTr9aTQrT7JqsBsnQSrNp4YpZjq6PC8ERpj6BEoyXTbDgKicgWGZ5YA3H3 7kx9xfylapMY/8YnGHz+dhI/5sKAJBe1LgC4SKJ6m4syEPRcbpQ59pKS0NLX67Ao2uGx Z7Hw==
X-Gm-Message-State: AHYfb5hHrrP0NaEZQjaVctbpj1hs8u92Dj7w7gW8Yq1Jk+l9Rfdo7tMC zFU4c97KLNYFw31PfiU=
X-Received: by 10.223.167.138 with SMTP id j10mr5081636wrc.97.1503660506634; Fri, 25 Aug 2017 04:28:26 -0700 (PDT)
Received: from [192.168.2.126] (host213-123-124-182.in-addr.btopenworld.com. [213.123.124.182]) by smtp.gmail.com with ESMTPSA id u83sm999934wmu.40.2017.08.25.04.28.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Aug 2017 04:28:26 -0700 (PDT)
To: Michael Tuexen <tuexen@fh-muenster.de>
Cc: gen-art@ietf.org, tsvwg@ietf.org, ietf@ietf.org, draft-ietf-tsvwg-sctp-ndata.all@ietf.org
References: <150274094205.10409.17989486864216331116@ietfa.amsl.com> <2B0B5E2A-0B15-4B86-9226-3129A101EE24@fh-muenster.de>
From: Stewart Bryant <stewart.bryant@gmail.com>
Message-ID: <3c58ac17-179c-6e2a-2ba6-589e83cb6dd1@gmail.com>
Date: Fri, 25 Aug 2017 12:28:24 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <2B0B5E2A-0B15-4B86-9226-3129A101EE24@fh-muenster.de>
Content-Type: text/plain; charset="windows-1252"; format="flowed"
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/nNvK9ckZeD0xxCiiSdztzUklcyo>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-tsvwg-sctp-ndata-12
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Aug 2017 11:28:32 -0000

Hi Michael

Sorry I misread the text.

The text is fine as it is, and I leave it to you to see if there is an 
improvement with a common definition.

I am correcting the review.

- Stewart


On 25/08/2017 11:53, Michael Tuexen wrote:
>> On 14. Aug 2017, at 22:02, Stewart Bryant <stewart.bryant@gmail.com> wrote:
>>
>> Reviewer: Stewart Bryant
>> Review result: Ready
>>
> Hi Stewart,
>
> thanks for your review. See my comment in-line.
>
> Best regards
> Michael
>> I am the assigned Gen-ART reviewer for this draft. The General Area
>> Review Team (Gen-ART) reviews all IETF documents being processed
>> by the IESG for the IETF Chair.  Please treat these comments just
>> like any other last call comments.
>>
>> For more information, please see the FAQ at
>>
>> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>>
>> Document: draft-ietf-tsvwg-sctp-ndata-12
>> Reviewer: Stewart Bryant
>> Review Date: 2017-08-14
>> IETF LC End Date: 2017-08-25
>> IESG Telechat date: Not scheduled for a telechat
>>
>> Summary: This is a well written draft and is ready for publication.
>>
>> Major issues: None
>>
>> Minor issues: None
>>
>> Nits/editorial comments:
>>
>> You repeat the text:
>>
>> "A message is considered in flight, if at least  on of its I-DATA chunks is not
>> acknowledged in a non-renegable way"  in two consecutive sections, maybe a
>> common definition could be used.
> The first text covers "Message in flight", the second covers "Fragment in flight".
> What is duplicated is the text (i.e. acknowledged by the cumulative TSN Ack) for
> explaining "acknowledged in a non-renegable way". Giving the explanation only once
> improves readability, I guess.
>
> Best regards
> Michael