Re: [Gen-art] review: draft-ietf-jose-jwk-thumbprint-05

Joel Halpern <jmh@joelhalpern.com> Mon, 06 July 2015 13:18 UTC

Return-Path: <jmh@joelhalpern.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4FC821A1B0B for <gen-art@ietfa.amsl.com>; Mon, 6 Jul 2015 06:18:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.902
X-Spam-Level:
X-Spam-Status: No, score=-1.902 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oqqwYBve4T9Z for <gen-art@ietfa.amsl.com>; Mon, 6 Jul 2015 06:18:36 -0700 (PDT)
Received: from mailb2.tigertech.net (mailb2.tigertech.net [208.80.4.154]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0E75F1A1B4A for <gen-art@ietf.org>; Mon, 6 Jul 2015 06:18:35 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mailb2.tigertech.net (Postfix) with ESMTP id D475D1C0806; Mon, 6 Jul 2015 06:18:34 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at b2.tigertech.net
Received: from Joels-MacBook-Pro.local (unknown [65.216.245.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailb2.tigertech.net (Postfix) with ESMTPSA id 6424B1C071A; Mon, 6 Jul 2015 06:18:34 -0700 (PDT)
To: "A. Jean Mahoney" <mahoney@nostrum.com>, General Area Review Team <gen-art@ietf.org>, draft-ietf-jose-jwk-thumbprint.all@tools.ietf.org
References: <55833892.7050802@nostrum.com> <55843E22.1060102@joelhalpern.com>
From: Joel Halpern <jmh@joelhalpern.com>
Message-ID: <559A8020.3020700@joelhalpern.com>
Date: Mon, 06 Jul 2015 09:18:24 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:38.0) Gecko/20100101 Thunderbird/38.0.1
MIME-Version: 1.0
In-Reply-To: <55843E22.1060102@joelhalpern.com>
Content-Type: text/plain; charset="windows-1252"; format="flowed"
Content-Transfer-Encoding: 7bit
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/p7159m0UfC18OtUha0ytZXp0X-o>
Subject: Re: [Gen-art] review: draft-ietf-jose-jwk-thumbprint-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Jul 2015 13:18:42 -0000

The document is nearly ready for publication as a Proposed Standard.

Upon  re-review, the addition of section 3.4 raises a question of 
clarity.  As written, the text says that the hash function matters only 
to the original thumbprint provider.  Should there be a little bit of 
text talking about the need for the hash function to be the same for 
thumbprints to be comparable, or, phrased alternatively, that 
thumbprints with different hashes must not be compared?  If there were 
no need for consistent production of the thumbprint, there would be no 
need for a Proposed Standard for the document.

Yours,
Joel

The new section 3.4
On 6/19/15 12:06 PM, Joel M. Halpern wrote:
> I am the assigned Gen-ART reviewer for this draft. For background on
> Gen-ART, please see the FAQ at
>
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
>
> Please resolve these comments along with any other Last Call comments
> you may receive.
>
> Document: draft-ietf-jose-jwk-thumbprint-05
>      JSON Web Key (JWK) Thumbprint
> Reviewer: Joel M. Halpern
> Review Date: 19-June-2015
> IETF LC End Date: N/A
> IESG Telechat date: N/A
>
> Summary: The internet draft is ready for publication as a Proposed
> Standard.
>
> [Note to readers:
> This review is provided because the spreadsheet said so.  The draft
> appears not to be in last call yet.
> Also, this reviewer did not attempt to second-guess the design choices
> made by the WG.  The choices are well-explain, and I understand it to be
> the WGs job to make them.]
>
> Major issues: N/A
>
> Minor issues: N/A
>
> Nits/editorial comments: N/A
>
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art
>