Re: [Gen-art] Gen-ART review of draft-green-secsh-ecc-08.txt

Douglas Stebila <douglas@stebila.ca> Wed, 15 July 2009 05:17 UTC

Return-Path: <douglas@stebila.ca>
X-Original-To: gen-art@core3.amsl.com
Delivered-To: gen-art@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 600443A67D3 for <gen-art@core3.amsl.com>; Tue, 14 Jul 2009 22:17:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.599
X-Spam-Level:
X-Spam-Status: No, score=-6.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, RCVD_IN_DNSWL_MED=-4]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UFMyW8ZhV4Tz for <gen-art@core3.amsl.com>; Tue, 14 Jul 2009 22:17:40 -0700 (PDT)
Received: from services107.math.uwaterloo.ca (services107.math.uwaterloo.ca [129.97.140.58]) by core3.amsl.com (Postfix) with ESMTP id B3D643A6860 for <gen-art@ietf.org>; Tue, 14 Jul 2009 22:17:40 -0700 (PDT)
Received: from [131.181.102.151] ([131.181.102.151]) (authenticated bits=0) by services107.math.uwaterloo.ca (8.13.8/8.13.8) with ESMTP id n6F5BYVS007647 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Wed, 15 Jul 2009 01:11:39 -0400 (EDT)
Message-Id: <24E782B5-D9F3-429E-9A44-DFEDD0C94DEA@stebila.ca>
From: Douglas Stebila <douglas@stebila.ca>
To: "Miguel A. Garcia" <Miguel.A.Garcia@ericsson.com>
In-Reply-To: <4A5C5746.5070904@ericsson.com>
Content-Type: text/plain; charset="US-ASCII"; format="flowed"; delsp="yes"
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v935.3)
Date: Wed, 15 Jul 2009 15:11:29 +1000
References: <4A5C5746.5070904@ericsson.com>
X-Mailer: Apple Mail (2.935.3)
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-3.0 (services107.math.uwaterloo.ca [129.97.140.58]); Wed, 15 Jul 2009 01:11:42 -0400 (EDT)
X-Miltered: at mailchk-m03 with ID 4A5D6506.001 by Joe's j-chkmail (http://j-chkmail.ensmp.fr)!
X-Virus-Scanned: clamav-milter 0.95.1 at mailchk-m04
X-Virus-Status: Clean
X-UUID: 65569eb7-d311-4d6f-a33c-a579f0250626
X-Mailman-Approved-At: Tue, 14 Jul 2009 23:57:02 -0700
Cc: Tim Polk <tim.polk@nist.gov>, General Area Review Team <gen-art@ietf.org>, jon.green@ece.queensu.ca, Jeffrey Hutzelman <jhutz@cmu.edu>
Subject: Re: [Gen-art] Gen-ART review of draft-green-secsh-ecc-08.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jul 2009 05:17:42 -0000

Thanks.  I will make the suggested changes.

Douglas

On 2009-Jul-14, at 8:00 PM, Miguel A. Garcia wrote:

> I have been selected as the General Area Review Team (Gen-ART)
> reviewer for this draft (for background on Gen-ART, please see
> http://www.alvestrand.no/ietf/gen/art/gen-art-FAQ.html).
>
> Please wait for direction from your document shepherd
> or AD before posting a new version of the draft.
>
> Document: draft-green-secsh-ecc-08.txt
> Reviewer: Miguel Garcia <miguel.a.garcia@ericsson.com>
> Review Date: 2009-07-14
> IETF LC End Date: 2009-08-10
> Summary: The document is ready for publication as a standard track  
> RFC.
>
>
> Major issues: none
>
>
> Minor issues:
>
> - In Section 9.1, second sentence, the text reads: "These curve  
> should always be enabled ...." I think the "should" should be  
> elevated to a "SHOULD" in this case.
>
> - The IANA Considerations section needs more work. In particular, it  
> does not name the registry where IANA has to operate. I am assuming  
> that this registry is "Secure Shell (SSH) Protocol Parameters). That  
> registry includes several subregistries, of which, this draft is  
> presumably adding  new values to the "Public Key Algorithm Names"  
> and "Key Exchange Method Names". Please clearly explain what needs  
> to be registered where.
>
> Nits/editorial comments: A couple of minor nits, in case you need to
> create a new version of the document
>
> - The third paragraph of Section 6.1 contains an 8-line long  
> sentence. I think this sentence could be simplified and chunked into  
> smaller sentences, because it is a bit hard to read such long  
> sentences.
>
> - The first paragraph in Section 7 reads ... "... without being  
> granted IANA permission". If we are accurate, IANA does not grant  
> any permission. Instead IANA acts as a registry. So, most likely you  
> want to say "... without requiring an IANA registration process" or  
> something like that.
>
> - Title of Section 9.2, missing white space separated two words.
>
> Regards,
>
>     Miguel
> -- 
> Miguel A. Garcia
> +34-91-339-3608
> Ericsson Spain
>