Re: [Gen-art] Genart last call review of draft-ietf-regext-epp-eai-10

Dmitry Belyavsky <beldmit@gmail.com> Sun, 05 June 2022 11:21 UTC

Return-Path: <beldmit@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 04CE7C14F747; Sun, 5 Jun 2022 04:21:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.106
X-Spam-Level:
X-Spam-Status: No, score=-2.106 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8lnbJhf-imkq; Sun, 5 Jun 2022 04:21:16 -0700 (PDT)
Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B3AFDC14F72F; Sun, 5 Jun 2022 04:21:16 -0700 (PDT)
Received: by mail-lf1-x12a.google.com with SMTP id u23so19326068lfc.1; Sun, 05 Jun 2022 04:21:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wE/r5G5F9t1/NQa1r+merKGsRQ/OISchsYxDXVtTGFU=; b=Ad6eYXviSgOkJx66KtOsanxj0pcZBabbZMGVW99wU8Ah2Isjv7fAGAMyHoDRLp2l0/ x8piI5k21U7q78uQUCrFMoAZO6iUb/eeyCC7RZPxbV6BGj5FOD6sWaaapvC36ymLv7WA pYOs3DZRm3UE9GM+4q78rkjC+88hqDFcPoY2oY3bslVaHSiKyuSfQsm1KTZbAHacUM/v 7WABFp9hjWBaM9AUlJeKKJsGVZWS797PfleTesXIeDsVKwHNZhYNgqdKcYNegsBqzasW 1vDRvrcCRMMMuXR4DO1udbQ0VbDNAiuVj7yu/zjbzjGNxz0TWB6HIyK/x9tMT6zwPrXi BgYQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wE/r5G5F9t1/NQa1r+merKGsRQ/OISchsYxDXVtTGFU=; b=ogTH5c2O0bgzGpJBucmm5kRGYmCtm3kLAiOAgrxM3dZj0BXHBc0DaW5+j0WJjejK49 1xX0FJMnUbUrgDr/iwe7edFvt+CmqONxbwL3mCiyHE2TKqGCjwsIF3Kdqxcl4uz8PZlC Jt8kcCT/z4LHdpgKiICgRLbRxBGwT8p8dMnr+mCQokT4G4JP4WDdG86tretsxkCyXSF+ wMaEiezZFqHzdUXmA9IrmO5K+PkW1wPLOcA9OdoQnjBka7w0RffKP3f6mEYlyH65LzLZ /lLVyKY7MY4tsSfMdBJ5/r546X6zYufA20JI4ahjwGNVOschaVNBK/cHCIqdSqmMUnyC Q/dA==
X-Gm-Message-State: AOAM532T+wKNarVZMDjcK8IDYqsnumeOcPWKNixo4P0NjwDHj97P18VY ryxX0+96hsVfSXkd4tbg0v4QQ6zwO0cFKjviGCu+I/Qq
X-Google-Smtp-Source: ABdhPJzUu8kx4O6m8kxMcARKh7gO0C7Sjo4d7BohU3DjsoCSZknMt0hCWeoLHokQ5+KAiWNbutI3HVwu++JXWzAnWV0=
X-Received: by 2002:a05:6512:3f01:b0:46b:a5ba:3b89 with SMTP id y1-20020a0565123f0100b0046ba5ba3b89mr12296709lfa.28.1654428074236; Sun, 05 Jun 2022 04:21:14 -0700 (PDT)
MIME-Version: 1.0
References: <165410367843.9432.758562996445667068@ietfa.amsl.com> <342ADE07-655E-4132-8254-4E3AB2511E57@verisign.com>
In-Reply-To: <342ADE07-655E-4132-8254-4E3AB2511E57@verisign.com>
From: Dmitry Belyavsky <beldmit@gmail.com>
Date: Sun, 05 Jun 2022 13:21:02 +0200
Message-ID: <CADqLbz+tRSgfxB9u4kGy2ZDxR2UiQZck5bK6YyEngLpUEvnbFg@mail.gmail.com>
To: "Gould, James" <jgould@verisign.com>
Cc: "resnick@episteme.net" <resnick@episteme.net>, "gen-art@ietf.org" <gen-art@ietf.org>, "draft-ietf-regext-epp-eai.all@ietf.org" <draft-ietf-regext-epp-eai.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "regext@ietf.org" <regext@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000abe03f05e0b18dde"
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/vs7G5q_Gz42GBLFBcd9C1B4SFio>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-regext-epp-eai-10
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Jun 2022 11:21:21 -0000

Dear colleagues,
Many thanks for the review!

On Wed, Jun 1, 2022 at 10:24 PM Gould, James <jgould@verisign.com> wrote:

> Pete,
>
> Thanks for the review and feedback.  My responses are embedded below
> prefixed with "JG - ".
>
> --
>
> JG
>
>
>
> James Gould
> Fellow Engineer
> jgould@Verisign.com
> <applewebdata://13890C55-AAE8-4BF3-A6CE-B4BA42740803/jgould@Verisign.com>
>
> 703-948-3271
> 12061 Bluemont Way
> Reston, VA 20190
>
> Verisign.com <http://verisigninc.com/>
>
> On 6/1/22, 1:14 PM, "Pete Resnick via Datatracker" <noreply@ietf.org>
> wrote:
>
>     Caution: This email originated from outside the organization. Do not
> click links or open attachments unless you recognize the sender and know
> the content is safe.
>
>     Reviewer: Pete Resnick
>     Review result: On the Right Track
>
>     I am the assigned Gen-ART reviewer for this draft. The General Area
>     Review Team (Gen-ART) reviews all IETF documents being processed
>     by the IESG for the IETF Chair.  Please treat these comments just
>     like any other last call comments.
>
>     For more information, please see the FAQ at
>
>     <
> https://secure-web.cisco.com/1K6cgCFLakXfTnPIeaE2ZwevlkM0KiD6YlQuPilL-K-FXI75spzFhwPbrTminlCoOV1FdlZ-bTNGfTViEpxNNwpy3pP1zuhfVsE4ZUjY7vULMuNEt3p-qQ62KtoXfXHC_KpjCFJHvW7GqkJC_qLRyJ-N78dFJBhWHSKNXlYl2cJL2QXsuMUzInqccq9AGZZJodZnSZU_J1df7jwu242lQtR1zAq0RHYomOugyloQ1oaUDFUXOeh3j2WkUwpPpY3hA/https%3A%2F%2Ftrac.ietf.org%2Ftrac%2Fgen%2Fwiki%2FGenArtfaq
> >.
>
>     Document: draft-ietf-regext-epp-eai-10
>     Reviewer: Pete Resnick
>     Review Date: 2022-06-01
>     IETF LC End Date: 2022-06-09
>     IESG Telechat date: Not scheduled for a telechat
>
>     Summary:
>
>     I think this proposal is reasonable, but I don't think enough
> explanation has
>     been given regarding the case where one side supports the protocol but
> the
>     other side doesn't.
>
>     Major issues:
>
>     The last bullet item in section 5.3.2 talks about "alternative ASCII
> address",
>     but I don't see anywhere in the document which defines how to provide
> an
>     alternative ASCII address in the data. For example, RFC 5733 implies
> that there
>     will be only one email address in the Contact Mapping; can an
> implementation
>     simply add a second? Does the server then need to distinguish these by
> the
>     presence or absence of non-ASCII characters to determine which is an
> EAI and
>     which is an alternative ASCII address? At the very least, some
> discussion of
>     this seems necessary in the document.
>
> JG - The reference to the "alternative ASCII email address" is for the
> client (registrar) when it's recognized that the server does not support
> EAI.  If the registrar collected an EAI address and an ASCII address, then
> the ASCII address MUST be provided; otherwise, the optional property SHOULD
> be omitted.  The use of an ASCII proxy email address can be used as well.
> In this case, the server does not support EAI addresses, so it's up to the
> EAI-supporting client to handle it.  Most likely the server validates that
> the address is only an ASCII address, but there is no guarantee of it.
>

I agree but I don't think that explanations of registrar operational
practices (e.g. collection of backup email addresses, etc) is in the scope
of protocol documents.


>     Minor issues:
>
>     In the bullets in section 5.3.2, there are quite a few SHOULDs with no
>     explanation of why one might choose to violate these. Why are these
> not MUSTs?
>     I can't think of any reason, for example, that the server would not
> validate
>     the email property, and it seems like a really bad idea not to.
>
> JG - I cover each of the SHOULDs below:
>
> 1. For the required email property with a client that doesn't signal
> support for EAI, the server needs to satisfy the negotiated services . This
> should be a MUST to comply with the negotiated namespaces, since the
> downside is that the client will receive an error response with an info
> command if they still don't support EAI in the login services.   The error
> response is a MUST in the third bullet.
> 2. For the optional email property falls the same case as the required
> email property, since the info response will result in an error.  It should
> be a MUST as well.  The error response is a MUST in the fourth bullet.
>

I replaced both these SHOULDs with MUST


>
>     Nits/editorial comments:
>
>     Abstract: Strike the word "appearing"
>
> JG - Yes, that can be removed.
>

Done


>
>     Section 3: Change "By applying the syntax rules of [RFC5322]" to "By
> applying
>     the syntax rules of [RFC6532]"
>
> JG - I'll leave this one for Dmitry to respond to, but changing RFC5322 to
> RFC6532 looks correct to me.
>
> I think the proper RFC is 6531 here.  Done.


-- 
SY, Dmitry Belyavsky