Re: [Gen-art] Genart last call review of draft-ietf-detnet-ip-over-mpls-05

[Balázs Varga A <[e-mail]>]

Hi Tim,

Thanks for the review. Your comments will be incorporated in the next version.

Feedbacks are inline below marked with <BV>.

Many thanks

Bala'zs



-----Original Message-----
From: Tim Evens via Datatracker <[e-mail]>
Sent: Tuesday, April 21, 2020 12:19 AM
To: [e-mail]
Cc: [e-mail]; [e-mail]; [e-mail]
Subject: Genart last call review of draft-ietf-detnet-ip-over-mpls-05



Reviewer: Tim Evens

Review result: Ready with Nits



I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair.  Please treat these comments just like any other last call comments.



For more information, please see the FAQ at



<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.



Document: draft-ietf-detnet-ip-over-mpls-??

Reviewer: Tim Evens

Review Date: 2020-04-20

IETF LC End Date: 2020-04-23

IESG Telechat date: Not scheduled for a telechat



Summary:



Major issues:



Minor issues:



Nits/editorial comments:



Some of the references refer to older revisions.



Abbreviations:

* T-PE is referenced several times but not defined.

* d-CW is referenced in Figure 3 but not defined.

* S-Label is referenced several times but not defined.

<BV> Right, they will be added to abbreviation section.



Figure 1 and 2 have the same label.

<BV> Right, first shows the architecture the second the location of DetNet functions.

I will update the titles.



In Section 4.2:



* There is reference to section 5.1.1 and 5.1.2, but those sections do not exist in this draft.  Can you clarify which draft/RFC these sections are referring to?

<BV> Right, they are referring to "https://datatracker.ietf.org/doc/draft-ietf-detnet-ip/". Reference is at the end of the sentence.

  "   ...   IP" and "NProto" indicate the fields described in

   Section 5.1.1.  IP Header Information and Section 5.1.2.  Other

   Protocol Header Information in [I-D.ietf-detnet-ip], respectively.



* "Per [I-D.ietf-detnet-mpls], the DetNet MPLS data plane uses a single

   S-Label to support a single app flow.  Section 5.1.  DetNet IP Flow

   Identification Procedures ..."



   Why is Section 5.1 referenced like this?

<BV> Again, this is referring to "https://datatracker.ietf.org/doc/draft-ietf-detnet-ip/".



* "DetNet IP Flow Identification Procedures in [I-D.ietf-detnet-ip] states

   that a single DetNet flow is identified based on IP, and next level

   protocol, header information.  Section 4.4.  Aggregation..."



   It would be more clear to specifically refer to the draft/rfc and section.

<BV> Again, this is referring to "https://datatracker.ietf.org/doc/draft-ietf-detnet-ip/".