Re: [GROW] [Gen-art] Genart last call review of draft-ietf-grow-bmp-local-rib-10
Lars Eggert <lars@eggert.org> Tue, 06 April 2021 12:52 UTC
Return-Path: <lars@eggert.org>
X-Original-To: grow@ietfa.amsl.com
Delivered-To: grow@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DC2BE3A2010; Tue, 6 Apr 2021 05:52:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=eggert.org
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QWLOEsxrEsk3; Tue, 6 Apr 2021 05:52:41 -0700 (PDT)
Received: from mail.eggert.org (mail.eggert.org [91.190.195.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0A2AF3A2112; Tue, 6 Apr 2021 05:51:21 -0700 (PDT)
Received: from [IPv6:2a00:ac00:4000:400:68eb:fc77:3b2:d84e] (unknown [IPv6:2a00:ac00:4000:400:68eb:fc77:3b2:d84e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.eggert.org (Postfix) with ESMTPSA id 6737F600314; Tue, 6 Apr 2021 15:51:12 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eggert.org; s=dkim; t=1617713472; bh=cLc2p/BfY5an4XzVt49MaId94GH0nJVrFT9eUqg3jtU=; h=From:Subject:Date:In-Reply-To:Cc:To:References; b=IpF4HQY86kLmIsv68mbp0Sb0Tglpvwicvvlp92tcF7z/c35HTtkP75PdP6ReOcxQ4 dgmUqq8zCDxUkP9RtmiL/4jyTGWXWh95zlQ8DimI1qFV59mX19vkNYCE0U2isjzXYY RPW2btRUQ/uJmbR7pgjocQ/T/xxnalRQswgpIDZU=
From: Lars Eggert <lars@eggert.org>
Message-Id: <3C646296-60BD-46D6-AA11-4AEFFDF22600@eggert.org>
Content-Type: multipart/signed; boundary="Apple-Mail=_B74DA586-1075-4FB4-AF02-135E2A09218D"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\))
Date: Tue, 06 Apr 2021 15:51:12 +0300
In-Reply-To: <161623640103.11633.5276657057885321836@ietfa.amsl.com>
Cc: General Area Review Team <gen-art@ietf.org>, last-call@ietf.org, grow@ietf.org, draft-ietf-grow-bmp-local-rib.all@ietf.org
To: Thomas Fossati <thomas.fossati@arm.com>
References: <161623640103.11633.5276657057885321836@ietfa.amsl.com>
X-Mailer: Apple Mail (2.3654.60.0.2.21)
X-MailScanner-ID: 6737F600314.A1B07
X-MailScanner: Found to be clean
X-MailScanner-From: lars@eggert.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/grow/-voPVff2GhpryyazGLJBQH4dJEk>
Subject: Re: [GROW] [Gen-art] Genart last call review of draft-ietf-grow-bmp-local-rib-10
X-BeenThere: grow@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Grow Working Group Mailing List <grow.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/grow>, <mailto:grow-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/grow/>
List-Post: <mailto:grow@ietf.org>
List-Help: <mailto:grow-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/grow>, <mailto:grow-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2021 12:52:45 -0000
Thomas, thank you for your review and thank you all for the following discussion. I have entered a No Objection ballot for this document. Lars > On 2021-3-20, at 12:33, Thomas Fossati via Datatracker <noreply@ietf.org> wrote: > > Reviewer: Thomas Fossati > Review result: Ready with Issues > > I am the assigned Gen-ART reviewer for this draft. The General Area > Review Team (Gen-ART) reviews all IETF documents being processed > by the IESG for the IETF Chair. Please treat these comments just > like any other last call comments. > > For more information, please see the FAQ at > > <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. > > Document: draft-ietf-grow-bmp-local-rib-?? > Reviewer: Thomas Fossati > Review Date: 2021-03-20 > IETF LC End Date: 2021-03-29 > IESG Telechat date: Not scheduled for a telechat > > I am the assigned Gen-ART reviewer for this draft. The General Area > Review Team (Gen-ART) reviews all IETF documents being processed by the > IESG for the IETF Chair. Please treat these comments just like any other > last call comments. For more information, please see the FAQ at > <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. > > This draft is on the right track but has open issues, described in the > review. > > Some high level notes: > > * A nice set of use cases that provide compelling reasons for this BMP > extension are presented clearly and concisely at the beginning of the > document. > > * It seems to me that this extension is in line with the original > design goals of the protocol (i.e., simplicity, usefulness, > ease of implementation, minimally service affecting). > > * This document updates BMP by providing a complete replacement > for the monitoring of routes originated into BGP by the local router. > This is made clear by the "update 7854" label, as well as the finer > grained reference found in Section 1, which points to Section 8.2 of > RFC7854. > > * Overall the document is very readable but there are a few places that > need some editorial polishing to eliminate possible ambiguities. > > Nits: > > * Figure 1: > * a couple of '+' are missing in the top-right and bottom-right > corners of the Adj-RIB-In (Post) box; > > * "e.g." => "e.g.," in multiple places; > > * A few acronyms are not expanded: > * IGP, BGP-LS, SPF, CSPF. VRF, ASN, BGP-ID, RD (route > distinguisher?) > > * Section 1.1 > * "directly effects" => "directly affects" > > * Section 3 > * "an instance of an instance of BGP-4" => "an instance of BGP-4" > > * Section 5 > * "post-policy" => "Post-Policy" > * "ie." => "i.e.," > > * Section 5.1 > * "in The Loc-RIB, expressed" => "in the Loc-RIB, expressed" > > * Section 5.2.1 > * Consider using "Peer Up" instead of "Peer UP" for consistency with > the capitalisation use in RFC7854 (also in Sections 5.3, 5.4.1, 6.1, > 6.1.1, 6.1.3, and 8.3) > > * Section 5.3 > * "peer Down" => "Peer Down" > > * Section 6.1 > * "local router emulated peer." maybe "locally emulated peer." > > * Section 6.1.1 > * "since it represents the same Loc-RIB instance" => "since they > represents the same Loc-RIB instance" > > Editorial improvements: > > * Section 1.1 > * I had some troubles parsing: "Complexities introduced by the lack > of access to Loc-RIB in order to derive (e.g. correlate) peer to > router Loc-RIB:", in particular the bit "in order to derive (e.g. > correlate)". Is it "in order to derive (i.e., correlate)" or "in > order to derive (or correlate)" or "in order to correlate"? > > * What does "suppresses more specifics" mean? Is there a term > missing? > > * What does "derive a Loc-RIB to a router" mean? Is it "derive the > Loc-RIB of a router" instead? > > * I find this "The BGP-IDs and session addresses to router > correlation requires additional data" a bit hard to parse. Maybe > re-flow it as: "Correlating BGP-IDs and session addresses to a > router requires additional data" > > * Section 4.1 > * I find "to distinguish that it represents Loc-RIB with or without RD > and local instances" a bit hard to parse. I suggest rephrasing it > to make it clearer. > > * Section 5 > * Re: setting the F flag. It'd help if you put a forward ref to > Section 6.1.2 here. (Before getting to 6.1.2 I got baffled by F; in > particular, it was not clear to me from the surrounding text what is > the monitoring station supposed to do with partial information > without knowing exactly how much and what kind of info has been > left out.) > > * Section 5.2 > * Should add-paths be ADD-PATH instead? If so, maybe you could also > add an informative reference to RFC7911 > > * In "The duplication allows the BMP receiver to use existing parsing" > could you clarify what "existing parsing" mean? > > * Section 5.5 > * Why would the receiver decide not to ignore a Route Mirror message? > And what would happen if it decided so? I'm asking because I don't > understand the reasons for a SHOULD rather than a MUST here. > > * Section 6.1.1 > * In "There MUST be multiple emulated peers for each Loc-RIB instance" > I am unsure whether what you want to say is that "there MUST be at > least one emulated peer for each Loc-RIB instance" (which is what I > thought) or that "each Loc-RIB instance *always* has multiple > emulated peers" (which the current text seems to say)? > > * Section 8.2 > * It is not clear to me if saying "and proposes that peer flags are > specific to the peer type" you are asking IANA to modify the > contents and/or structure of the BMP Peer Flags registry? If so, > the request to IANA should be made more explicit. > > * Section 8.3 > * Should "informational message TLV types" be "Initiation Message TLV > type" instead? > > > > > > _______________________________________________ > Gen-art mailing list > Gen-art@ietf.org > https://www.ietf.org/mailman/listinfo/gen-art
- [GROW] Genart last call review of draft-ietf-grow… Thomas Fossati via Datatracker
- Re: [GROW] Genart last call review of draft-ietf-… Tim Evens (tievens)
- Re: [GROW] Genart last call review of draft-ietf-… Thomas Fossati
- Re: [GROW] [Gen-art] Genart last call review of d… Lars Eggert