[GROW] Re: Review of draft-ietf-grow-bmp-bgp-rib-stats-05
linchangwang <linchangwang.04414@h3c.com> Thu, 24 April 2025 12:47 UTC
Return-Path: <linchangwang.04414@h3c.com>
X-Original-To: grow@mail2.ietf.org
Delivered-To: grow@mail2.ietf.org
Received: from localhost (localhost [127.0.0.1]) by mail2.ietf.org (Postfix) with ESMTP id 96F5A209374E; Thu, 24 Apr 2025 05:47:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at ietf.org
X-Spam-Flag: NO
X-Spam-Score: -1.797
X-Spam-Level:
X-Spam-Status: No, score=-1.797 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, HTTPS_HTTP_MISMATCH=0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Received: from mail2.ietf.org ([166.84.6.31]) by localhost (mail2.ietf.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MApllfyy8L1q; Thu, 24 Apr 2025 05:47:29 -0700 (PDT)
Received: from h3cspam02-ex.h3c.com (smtp.h3c.com [60.191.123.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail2.ietf.org (Postfix) with ESMTPS id 11D572093744; Thu, 24 Apr 2025 05:47:26 -0700 (PDT)
Received: from mail.maildlp.com ([172.25.15.154]) by h3cspam02-ex.h3c.com with ESMTP id 53OCl8Uw060891; Thu, 24 Apr 2025 20:47:08 +0800 (+08) (envelope-from linchangwang.04414@h3c.com)
Received: from DAG6EX09-BJD.srv.huawei-3com.com (unknown [10.153.34.11]) by mail.maildlp.com (Postfix) with ESMTP id 4AE0D22F19E0; Thu, 24 Apr 2025 20:50:24 +0800 (CST)
Received: from DAG6EX08-BJD.srv.huawei-3com.com (10.153.34.10) by DAG6EX09-BJD.srv.huawei-3com.com (10.153.34.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.27; Thu, 24 Apr 2025 20:47:09 +0800
Received: from DAG6EX08-BJD.srv.huawei-3com.com ([fe80::5d6c:b52b:478f:2738]) by DAG6EX08-BJD.srv.huawei-3com.com ([fe80::5d6c:b52b:478f:2738%17]) with mapi id 15.02.1258.027; Thu, 24 Apr 2025 20:47:09 +0800
From: linchangwang <linchangwang.04414@h3c.com>
To: "mohamed.boucadair@orange.com" <mohamed.boucadair@orange.com>, Mukul Srivastava <msri@juniper.net>, Mukul Srivastava <msri=40juniper.net@dmarc.ietf.org>, "draft-ietf-grow-bmp-bgp-rib-stats@ietf.org" <draft-ietf-grow-bmp-bgp-rib-stats@ietf.org>
Thread-Topic: Review of draft-ietf-grow-bmp-bgp-rib-stats-05
Thread-Index: Adu1Fvk0Fl/UnJ92QSaCQCOhMnQxHg==
Date: Thu, 24 Apr 2025 12:47:09 +0000
Message-ID: <45b133e2c1d04cebbe2b62739eaf4395@h3c.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_ContentBits=0;MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Enabled=True;MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Method=Standard;MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Name=0633b888-ae0d-4341-a75f-06e04137d755;MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_SetDate=2025-02-18T13:31:11.0859958Z;MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_SiteId=bea78b3c-4cdb-4130-854a-1d193232e5f4;MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_ContentBits=0;MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_Enabled=True;MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_Method=Privileged;MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_Name=unrestricted_parent.2;MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_SetDate=2025-02-07T15:11:48.0000000Z;MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_SiteId=90c7a20a-f34b-40bf-bc48-b9253b6f5d20;
x-originating-ip: [10.142.193.222]
x-sender-location: DAG2
Content-Type: multipart/alternative; boundary="_000_45b133e2c1d04cebbe2b62739eaf4395h3ccom_"
MIME-Version: 1.0
X-DNSRBL:
X-SPAM-SOURCE-CHECK: pass
X-MAIL: h3cspam02-ex.h3c.com 53OCl8Uw060891
Message-ID-Hash: IAYEDJ6SBH3Q27GDQP26RFEVQXZ4TBZL
X-Message-ID-Hash: IAYEDJ6SBH3Q27GDQP26RFEVQXZ4TBZL
X-MailFrom: linchangwang.04414@h3c.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-grow.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: "grow@ietf.org" <grow@ietf.org>
X-Mailman-Version: 3.3.9rc6
Precedence: list
Subject: [GROW] Re: Review of draft-ietf-grow-bmp-bgp-rib-stats-05
List-Id: Grow Working Group Mailing List <grow.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/grow/LoCjhARxl2jEnQvNIm_4v3gF5J0>
List-Archive: <https://mailarchive.ietf.org/arch/browse/grow>
List-Help: <mailto:grow-request@ietf.org?subject=help>
List-Owner: <mailto:grow-owner@ietf.org>
List-Post: <mailto:grow@ietf.org>
List-Subscribe: <mailto:grow-join@ietf.org>
List-Unsubscribe: <mailto:grow-leave@ietf.org>
Hi Med, Thank you for your prompt response and thorough review. We will request a WGLC and then address this comment in the next version. Thanks, Changwang 发件人: mohamed.boucadair@orange.com <mohamed.boucadair@orange.com> 发送时间: 2025年4月24日 20:31 收件人: linchangwang (RD) <linchangwang.04414@h3c.com>; Mukul Srivastava <msri@juniper.net>; Mukul Srivastava <msri=40juniper.net@dmarc.ietf.org>; draft-ietf-grow-bmp-bgp-rib-stats@ietf.org 抄送: grow@ietf.org 主题: RE: Review of draft-ietf-grow-bmp-bgp-rib-stats-05 Hi Changwang, Thank you for taking care of this. The two issues are resolved in this version. I see that you also made this change s/may discard/MAY discard. I think the OLD was correct. You can fix this in your local copy; no need to release a new version for this. This can wait for other comments you may get in the WGLC. Thanks. Cheers, Med De : linchangwang <linchangwang.04414@h3c.com<mailto:linchangwang.04414@h3c.com>> Envoyé : jeudi 24 avril 2025 14:18 À : BOUCADAIR Mohamed INNOV/NET <mohamed.boucadair@orange.com<mailto:mohamed.boucadair@orange.com>>; Mukul Srivastava <msri@juniper.net<mailto:msri@juniper.net>>; Mukul Srivastava <msri=40juniper.net@dmarc.ietf.org<mailto:msri=40juniper.net@dmarc.ietf.org>>; draft-ietf-grow-bmp-bgp-rib-stats@ietf.org<mailto:draft-ietf-grow-bmp-bgp-rib-stats@ietf.org> Cc : grow@ietf.org<mailto:grow@ietf.org> Objet : Re: Review of draft-ietf-grow-bmp-bgp-rib-stats-05 Hi Med, Thank you for your review. We've submitted version-08 addressing these comments. Link: https://datatracker.ietf.org/doc/draft-ietf-grow-bmp-bgp-rib-stats/08/ Pls check and let us know if there are any further comments. Thanks, Changwang 发件人: mohamed.boucadair@orange.com<mailto:mohamed.boucadair@orange.com> <mohamed.boucadair@orange.com<mailto:mohamed.boucadair@orange.com>> 发送时间: 2025年4月23日 15:38 收件人: Mukul Srivastava <msri@juniper.net<mailto:msri@juniper.net>>; Mukul Srivastava <msri=40juniper.net@dmarc.ietf.org<mailto:msri=40juniper.net@dmarc.ietf.org>>; draft-ietf-grow-bmp-bgp-rib-stats@ietf.org<mailto:draft-ietf-grow-bmp-bgp-rib-stats@ietf.org> 抄送: grow@ietf.org<mailto:grow@ietf.org> 主题: RE: Review of draft-ietf-grow-bmp-bgp-rib-stats-05 Hi Mukul, Any update about this one? Thank you. Cheers, Med De : Mukul Srivastava <msri@juniper.net<mailto:msri@juniper.net>> Envoyé : jeudi 27 février 2025 21:51 À : BOUCADAIR Mohamed INNOV/NET <mohamed.boucadair@orange.com<mailto:mohamed.boucadair@orange.com>>; Mukul Srivastava <msri=40juniper.net@dmarc.ietf.org<mailto:msri=40juniper.net@dmarc.ietf.org>>; draft-ietf-grow-bmp-bgp-rib-stats@ietf.org<mailto:draft-ietf-grow-bmp-bgp-rib-stats@ietf.org> Cc : grow@ietf.org<mailto:grow@ietf.org> Objet : Re: Review of draft-ietf-grow-bmp-bgp-rib-stats-05 Thanks, Med, for the review. We will soon update doc on this. Thanks Mukul Juniper Business Use Only From: mohamed.boucadair@orange.com<mailto:mohamed.boucadair@orange.com> <mohamed.boucadair@orange.com<mailto:mohamed.boucadair@orange.com>> Date: Monday, February 24, 2025 at 5:43 AM To: Mukul Srivastava <msri@juniper.net<mailto:msri@juniper.net>>, Mukul Srivastava <msri=40juniper.net@dmarc.ietf.org<mailto:msri=40juniper.net@dmarc.ietf.org>>, draft-ietf-grow-bmp-bgp-rib-stats@ietf.org<mailto:draft-ietf-grow-bmp-bgp-rib-stats@ietf.org> <draft-ietf-grow-bmp-bgp-rib-stats@ietf.org<mailto:draft-ietf-grow-bmp-bgp-rib-stats@ietf.org>> Cc: grow@ietf.org<mailto:grow@ietf.org> <grow@ietf.org<mailto:grow@ietf.org>> Subject: RE: Review of draft-ietf-grow-bmp-bgp-rib-stats-05 [External Email. Be cautious of content] Hi Mukul, Thank you for taking care of the comments. I appreciate the new section on the implementation status. When reviewing the 05-07 diff, I have the following comments: * Does it really make sense to include text that mandates a vendor-specific behavior? Why using type 31 isn’t sufficient here? CURRENT: If the license-customized route threshold is vendor specific, this type value (31) SHOULD use enterprise-specific TLV encoding as described in Section 3.3 of [I-D.ietf-grow-bmp-tlv-ebit]. I tend to suggest deleting that part. * The descriptions in the IANA section should be consistent with BMP practice (that is, delete “(64-bit Gauge)”). See that inconsistency at https://www.iana.org/assignments/bmp-parameters/bmp-parameters.xhtml#statistics-types<https://urldefense.com/v3/__https:/www.iana.org/assignments/bmp-parameters/bmp-parameters.xhtml*statistics-types__;Iw!!NEt6yMaO-gk!BbvLvZxPfWUkZcmq6Ppo3rVTWyzD9fzgWlyxtczLOgJQyoWQvO2PDpwo2nRcebJBauJ6yitUFn_Fwmpj57dnW3im$>. Having a column to clearly indicate the type would be useful, though. Cheers, Med Juniper Business Use Only De : Mukul Srivastava <msri@juniper.net<mailto:msri@juniper.net>> Envoyé : vendredi 21 février 2025 17:31 À : Mukul Srivastava <msri=40juniper.net@dmarc.ietf.org<mailto:msri=40juniper.net@dmarc.ietf.org>>; BOUCADAIR Mohamed INNOV/NET <mohamed.boucadair@orange.com<mailto:mohamed.boucadair@orange.com>>; draft-ietf-grow-bmp-bgp-rib-stats@ietf.org<mailto:draft-ietf-grow-bmp-bgp-rib-stats@ietf.org> Cc : grow@ietf.org<mailto:grow@ietf.org> Objet : Re: Review of draft-ietf-grow-bmp-bgp-rib-stats-05 Hello Med All your comments have been addressed in latest version. https://datatracker.ietf.org/doc/draft-ietf-grow-bmp-bgp-rib-stats/07/<https://urldefense.com/v3/__https:/datatracker.ietf.org/doc/draft-ietf-grow-bmp-bgp-rib-stats/07/__;!!NEt6yMaO-gk!BbvLvZxPfWUkZcmq6Ppo3rVTWyzD9fzgWlyxtczLOgJQyoWQvO2PDpwo2nRcebJBauJ6yitUFn_Fwmpj55sUUtIX$> Pls check and let us know if there are any further comments. Thanks Mukul Juniper Business Use Only From: Mukul Srivastava <msri=40juniper.net@dmarc.ietf.org<mailto:msri=40juniper.net@dmarc.ietf.org>> Date: Tuesday, February 18, 2025 at 8:32 AM To: mohamed.boucadair@orange.com<mailto:mohamed.boucadair@orange.com> <mohamed.boucadair@orange.com<mailto:mohamed.boucadair@orange.com>>, draft-ietf-grow-bmp-bgp-rib-stats@ietf.org<mailto:draft-ietf-grow-bmp-bgp-rib-stats@ietf.org> <draft-ietf-grow-bmp-bgp-rib-stats@ietf.org<mailto:draft-ietf-grow-bmp-bgp-rib-stats@ietf.org>> Cc: grow@ietf.org<mailto:grow@ietf.org> <grow@ietf.org<mailto:grow@ietf.org>> Subject: [GROW] Re: Review of draft-ietf-grow-bmp-bgp-rib-stats-05 [External Email. Be cautious of content] Thanks, Med, for your comments. I would go over them and get back to you. Thanks Mukul Juniper Business Use Only Juniper Business Use Only From: mohamed.boucadair@orange.com<mailto:mohamed.boucadair@orange.com> <mohamed.boucadair@orange.com<mailto:mohamed.boucadair@orange.com>> Date: Friday, February 7, 2025 at 10:12 AM To: draft-ietf-grow-bmp-bgp-rib-stats@ietf.org<mailto:draft-ietf-grow-bmp-bgp-rib-stats@ietf.org> <draft-ietf-grow-bmp-bgp-rib-stats@ietf.org<mailto:draft-ietf-grow-bmp-bgp-rib-stats@ietf.org>> Cc: grow@ietf.org<mailto:grow@ietf.org> <grow@ietf.org<mailto:grow@ietf.org>> Subject: Review of draft-ietf-grow-bmp-bgp-rib-stats-05 [External Email. Be cautious of content] Hi Mukul, Yisong, Changwang, and Jinming, Thank you for the effort put into this document. FWIW, you may find a review at: * pdf: https://github.com/boucadair/IETF-Drafts-Reviews/blob/master/2025/draft-ietf-grow-bmp-bgp-rib-stats-05-rev%20Med.pdf<https://urldefense.com/v3/__https:/github.com/boucadair/IETF-Drafts-Reviews/blob/master/2025/draft-ietf-grow-bmp-bgp-rib-stats-05-rev*20Med.pdf__;JQ!!NEt6yMaO-gk!Cl2I5P4e4ExpPUJdtm8UN8u8IFgFDRtP2U9y1PKh-ffpAgmwG35ar4QMQ0rKODbIGPOLCzOgaZRrj2nMaHga8NNo$> * doc: https://github.com/boucadair/IETF-Drafts-Reviews/blob/master/2025/draft-ietf-grow-bmp-bgp-rib-stats-05-rev%20Med.doc<https://urldefense.com/v3/__https:/github.com/boucadair/IETF-Drafts-Reviews/blob/master/2025/draft-ietf-grow-bmp-bgp-rib-stats-05-rev*20Med.doc__;JQ!!NEt6yMaO-gk!Cl2I5P4e4ExpPUJdtm8UN8u8IFgFDRtP2U9y1PKh-ffpAgmwG35ar4QMQ0rKODbIGPOLCzOgaZRrj2nMaODB7c5B$> The document includes a comprehensive list of stat types. I wonder whether we have a public record about available implems of these stats. The document claims that it updates 7854, but I don’t think it does. Also, I recommend the authors to fix the normative dependency on an individual draft. You can easily get ride of that citation by having self-contained description. I guess you can do the same even with draft-ietf-rtgwg-bgp-pic (which is expired). One side comment, unlike the approach followed by 7854, the new entries at https://www.iana.org/assignments/bmp-parameters/bmp-parameters.xhtml<https://urldefense.com/v3/__https:/www.iana.org/assignments/bmp-parameters/bmp-parameters.xhtml__;!!NEt6yMaO-gk!Cl2I5P4e4ExpPUJdtm8UN8u8IFgFDRtP2U9y1PKh-ffpAgmwG35ar4QMQ0rKODbIGPOLCzOgaZRrj2nMaDQQxB1G$> includes the type as part of the description. If that information is important, it is cleaner to consider adding a new column to the registry (called type) to record that. Cheers, Med ____________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you. ____________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you. ____________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you. ------------------------------------------------------------------------------------------------------------------------------------- 本邮件及其附件含有新华三集团的保密信息,仅限于发送给上面地址中列出 的个人或群组。禁止任何其他人以任何形式使用(包括但不限于全部或部分地泄露、复制、 或散发)本邮件中的信息。如果您错收了本邮件,请您立即电话或邮件通知发件人并删除本 邮件! This e-mail and its attachments contain confidential information from New H3C, which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it! ____________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you.
- [GROW] Review of draft-ietf-grow-bmp-bgp-rib-stat… mohamed.boucadair
- [GROW] Re: Review of draft-ietf-grow-bmp-bgp-rib-… Mukul Srivastava
- [GROW] Re: Review of draft-ietf-grow-bmp-bgp-rib-… Mukul Srivastava
- [GROW] Re: Review of draft-ietf-grow-bmp-bgp-rib-… Thomas.Graf
- [GROW] Re: Review of draft-ietf-grow-bmp-bgp-rib-… linchangwang
- [GROW] Re: Review of draft-ietf-grow-bmp-bgp-rib-… mohamed.boucadair
- [GROW] Re: Review of draft-ietf-grow-bmp-bgp-rib-… Mukul Srivastava
- [GROW] Re: Review of draft-ietf-grow-bmp-bgp-rib-… mohamed.boucadair
- [GROW] Re: Review of draft-ietf-grow-bmp-bgp-rib-… mohamed.boucadair
- [GROW] Re: Review of draft-ietf-grow-bmp-bgp-rib-… linchangwang