[GROW] Re: Review of draft-ietf-grow-bmp-bgp-rib-stats-05

[[e-mail]]

Dear Mukul,

For the record. I agree on the comment from Med about license-customized route threshold should use enterprise-specific TLV encoding.

Thanks for updating the document accordingly.

Best wishes
Thomas

From: [e-mail] <[e-mail]>
Sent: Monday, February 24, 2025 11:43 AM
To: Mukul Srivastava <[e-mail]>; Mukul Srivastava <msri=[e-mail]>; [e-mail]
Cc: [e-mail]
Subject: [GROW] Re: Review of draft-ietf-grow-bmp-bgp-rib-stats-05

Be aware: This is an external email.

Hi Mukul,

Thank you for taking care of the comments. I appreciate the new section on the implementation status.

When reviewing the 05-07 diff, I have the following comments:

* Does it really make sense to include text that mandates a vendor-specific behavior? Why using type 31 isn’t sufficient here?

CURRENT:
      If the license-customized route threshold is vendor specific, this
      type value (31) SHOULD use enterprise-specific TLV encoding as
      described in Section 3.3 of [I-D.ietf-grow-bmp-tlv-ebit].

I tend to suggest deleting that part.

* The descriptions in the IANA section should be consistent with BMP practice (that is, delete “(64-bit Gauge)”). See that inconsistency at https://www.iana.org/assignments/bmp-parameters/bmp-parameters.xhtml#statistics-types. Having a column to clearly indicate the type would be useful, though.

Cheers,
Med

De : Mukul Srivastava <[e-mail]<mailto:[e-mail]>>
Envoyé : vendredi 21 février 2025 17:31
À : Mukul Srivastava <msri=[e-mail]<mailto:msri=[e-mail]>>; BOUCADAIR Mohamed INNOV/NET <[e-mail]<mailto:[e-mail]>>; [e-mail]<mailto:[e-mail]>
Cc : [e-mail]<mailto:[e-mail]>
Objet : Re: Review of draft-ietf-grow-bmp-bgp-rib-stats-05

Hello Med

All your comments have been addressed in latest version.
https://datatracker.ietf.org/doc/draft-ietf-grow-bmp-bgp-rib-stats/07/

Pls check and let us know if there are any further comments.

Thanks
Mukul



Juniper Business Use Only
From: Mukul Srivastava <msri=[e-mail]<mailto:msri=[e-mail]>>
Date: Tuesday, February 18, 2025 at 8:32 AM
To: [e-mail]<mailto:[e-mail]> <[e-mail]<mailto:[e-mail]>>, [e-mail]<mailto:[e-mail]> <[e-mail]<mailto:[e-mail]>>
Cc: [e-mail]<mailto:[e-mail]> <[e-mail]<mailto:[e-mail]>>
Subject: [GROW] Re: Review of draft-ietf-grow-bmp-bgp-rib-stats-05
[External Email. Be cautious of content]

Thanks, Med, for your comments. I would go over them and get back to you.

Thanks
Mukul



Juniper Business Use Only


Juniper Business Use Only
From: [e-mail]<mailto:[e-mail]> <[e-mail]<mailto:[e-mail]>>
Date: Friday, February 7, 2025 at 10:12 AM
To: [e-mail]<mailto:[e-mail]> <[e-mail]<mailto:[e-mail]>>
Cc: [e-mail]<mailto:[e-mail]> <[e-mail]<mailto:[e-mail]>>
Subject: Review of draft-ietf-grow-bmp-bgp-rib-stats-05
[External Email. Be cautious of content]

Hi  Mukul, Yisong, Changwang, and Jinming,

Thank you for the effort put into this document. FWIW, you may find a review at:


  *   pdf: https://github.com/boucadair/IETF-Drafts-Reviews/blob/master/2025/draft-ietf-grow-bmp-bgp-rib-stats-05-rev%20Med.pdf<https://urldefense.com/v3/__https:/github.com/boucadair/IETF-Drafts-Reviews/blob/master/2025/draft-ietf-grow-bmp-bgp-rib-stats-05-rev*20Med.pdf__;JQ!!NEt6yMaO-gk!Cl2I5P4e4ExpPUJdtm8UN8u8IFgFDRtP2U9y1PKh-ffpAgmwG35ar4QMQ0rKODbIGPOLCzOgaZRrj2nMaHga8NNo$>
  *   doc: https://github.com/boucadair/IETF-Drafts-Reviews/blob/master/2025/draft-ietf-grow-bmp-bgp-rib-stats-05-rev%20Med.doc<https://urldefense.com/v3/__https:/github.com/boucadair/IETF-Drafts-Reviews/blob/master/2025/draft-ietf-grow-bmp-bgp-rib-stats-05-rev*20Med.doc__;JQ!!NEt6yMaO-gk!Cl2I5P4e4ExpPUJdtm8UN8u8IFgFDRtP2U9y1PKh-ffpAgmwG35ar4QMQ0rKODbIGPOLCzOgaZRrj2nMaODB7c5B$>

The document includes a comprehensive list of stat types. I wonder whether we have a public record about available implems of these stats.

The document claims that it updates 7854, but I don’t think it does.

Also, I recommend the authors to fix the normative dependency on an individual draft. You can easily get ride of that citation by having self-contained description. I guess you can do the same even with draft-ietf-rtgwg-bgp-pic (which is expired).

One side comment, unlike the approach followed by 7854, the new entries at https://www.iana.org/assignments/bmp-parameters/bmp-parameters.xhtml<https://urldefense.com/v3/__https:/www.iana.org/assignments/bmp-parameters/bmp-parameters.xhtml__;!!NEt6yMaO-gk!Cl2I5P4e4ExpPUJdtm8UN8u8IFgFDRtP2U9y1PKh-ffpAgmwG35ar4QMQ0rKODbIGPOLCzOgaZRrj2nMaDQQxB1G$> includes the type as part of the description. If that information is important, it is cleaner to consider adding a new column to the registry (called type) to record that.

Cheers,
Med





____________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc

pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler

a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,

Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.



This message and its attachments may contain confidential or privileged information that may be protected by law;

they should not be distributed, used or copied without authorisation.

If you have received this email in error, please notify the sender and delete this message and its attachments.

As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.

Thank you.

____________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc

pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler

a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,

Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.



This message and its attachments may contain confidential or privileged information that may be protected by law;

they should not be distributed, used or copied without authorisation.

If you have received this email in error, please notify the sender and delete this message and its attachments.

As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.

Thank you.