Re: [I2nsf] [Last-Call] Yangdoctors last call review of draft-ietf-i2nsf-nsf-monitoring-data-model-06
t petch <ietfa@btconnect.com> Thu, 02 September 2021 11:41 UTC
Return-Path: <ietfa@btconnect.com>
X-Original-To: i2nsf@ietfa.amsl.com
Delivered-To: i2nsf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 15E3A3A005C for <i2nsf@ietfa.amsl.com>; Thu, 2 Sep 2021 04:41:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.029
X-Spam-Level:
X-Spam-Status: No, score=-0.029 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FAKE_REPLY_A1=1.871, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o3uAnj-3HqL7 for <i2nsf@ietfa.amsl.com>; Thu, 2 Sep 2021 04:41:33 -0700 (PDT)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60107.outbound.protection.outlook.com [40.107.6.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 001FC3A0062 for <i2nsf@ietf.org>; Thu, 2 Sep 2021 04:41:32 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lKVH6Y/S6VMIQpbaQyBz67FIKyvtBoYxJ6zo+bI3gVAaCYHU3lZ4l7PP6GIOCvj5+JKC3r/v8k6q/OIHblaS+3sXN+2sIs/ld8Hq5Y+7gIx1xItbwkebtAwqLVSn6g29fmZ/gEW4sbnUHd5tzZ3Izg3hMgUJ37C46cTorh6uikq5YS4994xQScdp3bl2nq1yej18yLJRmnIgAmMD5xnYRoQq7G7kh7V3inWLhrtTeFa5om5HakO+57rW1vztJtI8EQmMBMdmJl+SuXcWMk2+RI9XcZO5dHEN458gdhBCL8Amsfiw4j0sQoNjSBRyFpAx7boQdBoRZQbIOxLvJIOHsw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NtOSyYQ+TLUsDr8QkwmitBf+mn0XyxwyuOsWSMrsV4g=; b=WAKwKqmJx9XCzmf6w2w5im/Sl4xZs2AYpDDkpv3WBCv7Hoxmm13l5taHgGBylitOopBUcDyoXoqH8N3rJ+GIZELs3aR4dcgMghwmamycET8ZdXjx1sL9DfgURG4WPql4HJpXguP+CKfHHPrmyHUmDMF8YQvuGDASaV353KsmnbCXUlFryBPNBQT0F42KSfyybDHJo8sWKdt9+wq/Nip601fDPcPa4R4Z1LKQLTFe85WLc15nq0Z9IYvHeu4SqndnUBasRduyZbF1dlSFMcuQyxh0ZXity1CjUhBZd8/EELmMeatROR/IqrZ8YUWEn+38APQPR9Au5NJ9qQ6Q9IwYuw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=btconnect.com; dmarc=pass action=none header.from=btconnect.com; dkim=pass header.d=btconnect.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector2-btconnect-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NtOSyYQ+TLUsDr8QkwmitBf+mn0XyxwyuOsWSMrsV4g=; b=jLqrhnGXWTJ6yhY9PvxLB4mwPfjz+uhBSk8yh6vm7x5CzlOBVmARQiVCX/wsGB6qzoKVTRkTyP3w3cqhgqxI1onyspurZNLrSRqXwegR/K3asQnZ7iKo4bMV5gmTPDRXPYo8EmooNgs1txzNwHvoVHZ0ekG5c5qNdOf5wGwa2fA=
Authentication-Results: ietf.org; dkim=none (message not signed) header.d=none;ietf.org; dmarc=none action=none header.from=btconnect.com;
Received: from AM6PR07MB5544.eurprd07.prod.outlook.com (2603:10a6:20b:8a::30) by AS8PR07MB7653.eurprd07.prod.outlook.com (2603:10a6:20b:2a1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.9; Thu, 2 Sep 2021 11:41:26 +0000
Received: from AM6PR07MB5544.eurprd07.prod.outlook.com ([fe80::5193:fe4a:3a4f:69b0]) by AM6PR07MB5544.eurprd07.prod.outlook.com ([fe80::5193:fe4a:3a4f:69b0%5]) with mapi id 15.20.4478.017; Thu, 2 Sep 2021 11:41:26 +0000
From: t petch <ietfa@btconnect.com>
To: "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
Cc: i2nsf@ietf.org
Message-ID: <6130B864.50606@btconnect.com>
Date: Thu, 02 Sep 2021 12:41:24 +0100
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101 Thunderbird/38.5.0
Content-Type: text/plain; charset="windows-1252"; format="flowed"
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: LO2P265CA0515.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13b::22) To AM6PR07MB5544.eurprd07.prod.outlook.com (2603:10a6:20b:8a::30)
MIME-Version: 1.0
Received: from [192.168.1.65] (86.131.180.104) by LO2P265CA0515.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 11:41:26 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 48f31ef8-bccd-4b00-93c2-08d96e069907
X-MS-TrafficTypeDiagnostic: AS8PR07MB7653:
X-Microsoft-Antispam-PRVS: <AS8PR07MB7653405C56902E83D56FE8C6A2CE9@AS8PR07MB7653.eurprd07.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: gxcyJ6owr/O5at2PCgYd/G0SwP18z0WoDP0vzfi7B/dF7f9f06Xi7At9Q66FO4x22gzbSjOcat40nIZ3aEUFKsYIMQFeSbOmbbnybCaw2XNzqpPrUZ4y9y0k/MQyIvvhDQDcB1nvNiwb7yLvOJX8GUnLbtAc1YPSnfUrjKudnO6RgjbzAtg3in34MApWRbenhx37vu57oczxjJ+WMzA5OySA0hoFiy5NOkD9QGi1H7NS33MZlSdIwMZIKvSb0/Qm5Hj/kKJzlGCg8YmBCXPkgaMxN7tXn+1sfF0uOy6pWXHwYk2e2tFhBdjczVlHDPz4B4wX0oXlUy1bHX6KTCcwPAjoxq40S236ijvAyFqs4vuhwKyQE8sSnfRk6lz5XHHdnkrGLa9q06isgR/o2o8uzF6PwjAAsqR+tNa/z/KSY+maLfoSmMRsL5TDOHSdtM8psaifk5ZsIGpOtpxrQkB3QBncSxEtv6TN312ZRYNT474In1TOx6/BaETgwmNnWZ6FamVV4QiVynjD7sDpu47Iqq+RG0r9r3R0rEAE3Zpa96PTVGRYCQIqzMbXbTUDhJAjux5bmp8qD8rV4C5vxarCl7s4+QXnN4JcI74xr2UpSoyQyKCxeirD0/mT0zGZ0cYWat8esWvLJYGedA5BQYMc6Bm3qXJin1iRxXD+qbtq5MzO5/ZipqgrDGEs2NUtebhTxDuAETLxn7JlvuolcLiikNB3PXaAjMzkC8DnqcZXEGek/VR7Pu48gaF7zB0epBP87Js6pZgz20890VirLD20tnVPlKd7Vs3ImIiLxsGcMKQBLnjpthn7SIZIBtLG+CFQpj5wmFnZg19QMl/76SUbxd0Qjgb0MjTKnv+pknNPz/w=
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR07MB5544.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(376002)(366004)(346002)(396003)(39860400002)(6916009)(52116002)(316002)(66946007)(5660300002)(83380400001)(26005)(2906002)(36756003)(6486002)(16576012)(38100700002)(38350700002)(478600001)(966005)(4326008)(8936002)(53546011)(86362001)(186003)(66556008)(66476007)(33656002)(2616005)(8676002)(956004)(43740500002); DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 7Lq/PHhUJOMhmP/AMUf+X78FGBdU9qbX7Teyir6SmqEfRhsoGmWC3Wk9d5d1kBo10flmxOIybAGih5MY+tfTGkmMdzzywCotdfNGz5h7/OHPj91zi3PgxkaAcT92cXL04YdlU5ZiKkmi9C6iT8x445syX95QRl6BaYkQcpmUAt8eeQw6OEHJvyEmL1XrB0wLXVmID+ZSCQlKotG6vv1kZcJuPlCZpXpa6raw+Y/yX6VCekrYTeo9oNJGkdPUfKc6wUHEelQJ8WCiPxH5gapzAOZZuzsJhTp+EovweBeSXGYriopfoCWefses8gmU3UN1TkSBvM9F8SqtgLM9R9MHCKz7U1Sgk8n0iq9nIXohfRnA272K8MMhZNBwvA4Y16Fs2oEh1FKwapsQ9Nc5VBehwEnGm2Fg7I7ERD+mZ0/YCMUy6AqP3/R+EnWkJ6yYCijS72VeXZQz5QWWWGWmuQ4FlsnYjVB/pfvWBIjEFElZXE7y/a8VQR9w0WEYg2J6VA1seFpgyrU3E3xFj96H/L49k+u99nhHD4Cfq+nWNf1pfoHbTgmBrj0DHjpEwKMkDGXPzfcHkbjIaVWUJJSOdXLFrq8aB4Jc9q5TWzPOhFqOK5G9sUOoXw7WlzLnm5rq7/DWGfX/rHno/7DJYoMKGNl5g8Awxev3nOm6F3mmS2ASk2LJOhfd4xTGuDd5oqL2Rqx0pgGqn/y35btemtDjdeuYfXcrej2XfiCkPVP4rS/FcYLyEd3gzKpRA6e+JdNo5AfzBIbG4mOtCLEDo18Ph6WHkCmxM+iNsECkPjQtHcD/1skYyHObgqjSd7PiBdCxAt6IOUtdgdttg1TPazTPW77yLEyRTJkHvdxxDPico8poElHS4ea/JLzQjZmk1tMNqUMNPpjxgV/DH6JsbuujVZMRBSzlB4DPtmv+BfGlLHD7HDmei4HrkhlnwnUA32T0zb9WE9On0k6HzPDyJWtzhI+oqqKJuBUQqLbNjKmYWYCVMZWcXIDP6scNtEek7iFlFi62p5VtyLlloj1LZkhQYUuryEOPkxT0zmf0Qd4cSsL3/i1zNSuIEwhbTeopc2LkD8WKyBOoH20mELbeC0GSLNuV7LSE/BTzon8ende9x2KZ3COUs3sof6tUBFy9MSkNnDB7SrPfnW6wR8/ypno/hTJAKJ7GOOqYq4eDr0CM6g0oALSO6JvJP7qxl/qVCwzWrT1zCVMWoHq4yFM9w9GrR2SVs+eWUoWVt3Iwst8XvDfGX/kedOimVGlQV4xqxNTwIDkW6ClvMIdh5drpEfgWWPaxnyL1jcIGg8elETHSaGv407Fiif7c4V2/psPw9DFBVUCI
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 48f31ef8-bccd-4b00-93c2-08d96e069907
X-MS-Exchange-CrossTenant-AuthSource: AM6PR07MB5544.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 11:41:26.7834 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wfbXW2aD5Q8hDnuYgssz6NPQi/xcsmuuvXe2dcV5zFfZ8iKr9mFFE2EcW76SdipwYAKVRG93at3HCnKDibWHKQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR07MB7653
Archived-At: <https://mailarchive.ietf.org/arch/msg/i2nsf/IfjIWqOx_hswyE4R3tzLTJ1dvhg>
Subject: Re: [I2nsf] [Last-Call] Yangdoctors last call review of draft-ietf-i2nsf-nsf-monitoring-data-model-06
X-BeenThere: i2nsf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "*I2NSF: Interface to Network Security Functions mailing list*" <i2nsf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/i2nsf>, <mailto:i2nsf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/i2nsf/>
List-Post: <mailto:i2nsf@ietf.org>
List-Help: <mailto:i2nsf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/i2nsf>, <mailto:i2nsf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Sep 2021 11:41:39 -0000
----- Original Message ----- From: "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com> Sent: Tuesday, August 24, 2021 3:27 PM > Hi Tom, > Patrick and I have addressed your comments below with -09 version: > > I attach the revision letter to explain how to address them. > > Please let us know where this revision satisfies you or not. Paul Getting there. You have added some references to the YANG module - good - but you must also add them to the I-D References I see RFC854, RFC913, RFC1081, RFC4340, RFC4960, RFC5321, RFC7230, RFC7231. RFC1081 is obsoleted by RFC1225 so that would likely be a better reference. In other I-D you have cited RFC793bis - I do not know if that is appropriate here. You import ietf-i2nsf-policy-rule-for-nsf { with prefix nsfi but in nsf-facing the prefix is nsfintf Needs to be consistent In identity, derived from application-protocol (a base which I like), I note that 'imap' is present elsewhere but not here. I do not know if that is relevant to this module or not. In the data module: /http:/https:/ leaf src-zone { I was thrown by this thinking of IPv6 address zones but the description makes in clear that this is nothing of the sort. Probably not worth changing but if you do I would suggest src-location as is used in the description clause. leaf-list user-agent { I think that the description violates (!) the limit on line length for an RFC container i2nsf-counters { description "This is probably better covered by an import as this This seems unfinished leaf alarm-type { elsewhere you have switched to lower case (which I think right) but this needs bringing in line (I do like consistency). 10. I2NSF Event Stream you are using the NETMOD convention for line breaks; would benefit from a reference "line breaks as per [RFC8792] The I-D is big and I hope to find time this month to go through it again in more detail. Meanwhile, on to capability. In passing, I get a bounce for skku-iotlab-members every time. Tom Petch > > Thanks. > > Best Regards, > Paul > > On Wed, May 5, 2021 at 7:44 PM t petch <ietfa@btconnect.com<mailto:ietfa@btconnect.com>> wrote: > Paul > > Top posting since this is a more general response (and leaving in YANG > doctors since I note that five different YANG doctors reviewed the five > I-D and so might not see the issue that concerns me). > > As you have probably realised, I have now looked at the five YANG I-D of > I2NSF and am concerned at the disparate approaches to the same topics > that I think will confuse a user and, likely, induce mistakes. I > provided some detailed comments in response to WG LC on > capability-data-model but really it cuts across all five. It may be > that the inconsistenicies that I see can be justified but if so, then I > think that the I-D may need some text to say so, to relate one I-D to > another. > > The treatment of YANG identity for ICMP is to me a clear example. I > think that nsf-monitoring is good here, deriving icmpv4 and icmpv6 from > icmp (and ipv4 and ipv6) > while capability is not good having icmp (sic) and icmpv6 as two > unrelated identity, no common base. > > But at a higher level it may be that capability has a better treatment > where it has > base event; [from which is derived] > identity system-event-capability { > identity system-alarm-capability { > > base system-event-capability; > identity access-violation { > identity configuration-change { > > base system-alarm-capability; > identity memory-alarm { > identity cpu-alarm { > identity disk-alarm { > identity hardware-alarm { > identity interface-alarm { > > while nsf-monitoring has > > base alarm-type; > identity mem-usage-alarm { > identity cpu-usage-alarm { > identity disk-usage-alarm { > identity hw-failure-alarm { > identity ifnet-state-alarm { > > base event-type; > identity access-denied { > identity config-change { > > Different structure, different terminology, and these examples are quite > close compared to some others. I would expect at least the root of the > identifier to be the same if not the whole identifier. > > What is missing, for me, is an underlying, high-level, information model > to provide a consistent structure and a consistent terminology for the > I2NSF YANG I-D. > > Tom Petch > > > ----- Original Message ----- > From: "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com<mailto:jaehoon.paul@gmail.com>> > To: <tom petch> > Cc: <Last Call>; <i2nsf@ietf.org<mailto:i2nsf@ietf.org>>; <Andy Bierman>; <Yoav Nir>; > <draft-ietf-i2nsf-nsf-monitoring-data-model.all@ietf.org<mailto:draft-ie tf-i2nsf-nsf-monitoring-data-model.all@ietf.org>>; <Linda > Dunbar>; <Patrick Lingga>; <YANG Doctors>; <skku-iotlab-members>; <Mr. > Jaehoon Paul Jeong> > Sent: Thursday, April 29, 2021 3:49 PM > Subject: Re: [I2nsf] [Last-Call] Yangdoctors last call review of > draft-ietf-i2nsf-nsf-monitoring-data-model-06 > > > > > Hi Tom, > > > Patrick and I have addressed all your comments below with the > following revision. > > > > https://datatracker.ietf.org/doc/html/draft-ietf-i2nsf-nsf-monitoring-da > ta-model-08<https://datatracker.ietf.org/doc/html/draft-ietf-i2nsf-nsf-m onitoring-data-model-08> > > > > > > I attach our revision letter. > > > > > > Thanks. > > > > > > Best Regards, > > > Paul > > > > > > On Mon, Apr 12, 2021 at 6:59 PM tom petch > <daedulus@btconnect.com<mailto:daedulus@btconnect.com><mailto:daedulus@b tconnect.com<mailto:daedulus@btconnect.com>>> wrote: > > > Paul > > > > > > Some admin comments on -07; I think that you need to: > > > > > > - change the title in YANG revision reference > > > > > > - add to the I-D references > > > RFC959 > > > RFC8632 > > > > > > - shorten lines. There is a limit to line length in RFC as per the > Style > > > Guide. This is exceeded in the YANG where some of the path statements > > > take it over 80 while some of the examples are over 100. > > > > > > - add a reference for the import of > > > ietf-i2nsf-policy-rule-for-nsf > > > > > > HTH > > > > > > Tom Petcb > > > > > > On 01/04/2021 03:09, Mr. Jaehoon Paul Jeong wrote: > >>> > > > Hi Andy, Linda, and Yoav, > >>> > > > Patrick and I have addressed all the comments from Andy. > >>> > > > Here is the revised draft -07: > > > ATT00001.txt 130 bytes > > Attachments: > Revision-Letter-for-NSF-Monitoring-YANG-Data-Model-version-09-20210824.d ocx 103 kB > Revision-Letter-for-NSF-Monitoring-YANG-Data-Model-version-09-20210824.p df 420 kB
- [I2nsf] Yangdoctors last call review of draft-iet… Andy Bierman via Datatracker
- Re: [I2nsf] Yangdoctors last call review of draft… Mr. Jaehoon Paul Jeong
- Re: [I2nsf] Yangdoctors last call review of draft… Andy Bierman
- Re: [I2nsf] Yangdoctors last call review of draft… Mr. Jaehoon Paul Jeong
- Re: [I2nsf] [Last-Call] Yangdoctors last call rev… tom petch
- Re: [I2nsf] [Last-Call] Yangdoctors last call rev… Mr. Jaehoon Paul Jeong
- Re: [I2nsf] Yangdoctors last call review of draft… Mr. Jaehoon Paul Jeong
- Re: [I2nsf] [Last-Call] Yangdoctors last call rev… Mr. Jaehoon Paul Jeong
- Re: [I2nsf] [Last-Call] Yangdoctors last call rev… t petch
- Re: [I2nsf] [yang-doctors] [Last-Call] Yangdoctor… Martin Björklund
- Re: [I2nsf] [Last-Call] Yangdoctors last call rev… Mr. Jaehoon Paul Jeong
- Re: [I2nsf] [yang-doctors] [Last-Call] Yangdoctor… Mr. Jaehoon Paul Jeong
- Re: [I2nsf] [Last-Call] Yangdoctors last call rev… Mr. Jaehoon Paul Jeong
- Re: [I2nsf] [yang-doctors] [Last-Call] Yangdoctor… Mr. Jaehoon Paul Jeong
- Re: [I2nsf] [Last-Call] Yangdoctors last call rev… t petch
- Re: [I2nsf] [Last-Call] Yangdoctors last call rev… Mr. Jaehoon Paul Jeong
- Re: [I2nsf] [Last-Call] Yangdoctors last call rev… tom petch
- Re: [I2nsf] [Last-Call] Yangdoctors last call rev… Mr. Jaehoon Paul Jeong
- Re: [I2nsf] [Last-Call] Yangdoctors last call rev… Mr. Jaehoon Paul Jeong