Re: [I2nsf] [Last-Call] Yangdoctors last call review of draft-ietf-i2nsf-nsf-monitoring-data-model-06
"Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com> Wed, 15 September 2021 16:44 UTC
Return-Path: <jaehoon.paul@gmail.com>
X-Original-To: i2nsf@ietfa.amsl.com
Delivered-To: i2nsf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 15BCE3A2191 for <i2nsf@ietfa.amsl.com>; Wed, 15 Sep 2021 09:44:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.545
X-Spam-Level:
X-Spam-Status: No, score=-1.545 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HK_NAME_FM_MR_MRS=0.542, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_FREEMAIL_DOC_PDF=0.01, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id M3LXV7LVVcbc for <i2nsf@ietfa.amsl.com>; Wed, 15 Sep 2021 09:44:01 -0700 (PDT)
Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 740533A2188 for <i2nsf@ietf.org>; Wed, 15 Sep 2021 09:44:00 -0700 (PDT)
Received: by mail-lj1-x233.google.com with SMTP id r3so2186377ljc.4 for <i2nsf@ietf.org>; Wed, 15 Sep 2021 09:44:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xjUCE+KTgCvm3lLXa+WwY6iVCUon+DHTfznYZ9vKPFE=; b=ZTvISf6H7H/quMkJqKqAW3wdz8lvD74yrxjRE/8bMttG7uX4t3aS3xSU6dyRq+jYJi tlO3jxtzIVOz8GN286VOXLaJQ9rPwCBOCmOcSpNY8GAY48G4r4swkNxA4Ho5fWO5rFCH XXzy3J+sCOwcmUZvykHQErsozAg+qlM9+fqpAshMY46rvRfhrJ4nhK0bJzS4nJ0MvDHr tyDM1SdUQnaD7lEsERQXMbB+X5I1EsT2Q03scIuqAXXlpNvuuzVyhBuhlQo0G/UV7xwQ zWOF+WkXlzC8FTFK2QzWyjmvPl1mo7hR/NDHFXFcA9+McR5DM/5qda4q1yjv2PHv7ZAS KNCQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xjUCE+KTgCvm3lLXa+WwY6iVCUon+DHTfznYZ9vKPFE=; b=4DVjo78P3Ie9rHIej8V75JdaKw89H4aPqstexM8jdRH10br5/fcJaLQA0kRBm2vHMk kDmNp69kxk5XBYxKa7RiuFObsDmrqLM10N6XH1mNMiK8UMtgWOhzdwY3U8ea/wJoySZF 82mH7hd17I0qkDBCg3EBw26mq663OkFpbiNkaVv+7QRoWCa96Lh/QdYkHhfW+TnVZvm6 tGbbzLTBrQ3M2pksv59LRrAaRDKWrclA/esdKP1YyUlloWKAJu3Ng+o2PDY7rWr3Kje5 OBixo9NvR7viv9JApFE6EiT5iFNitUII6Fv3DhSpUtSGRRyPLH7cQfP3PfEpDkAYK1zZ VSvQ==
X-Gm-Message-State: AOAM531IBUK/vFcjBJp52BA7unSL/OadjosMK4DAwJfMth9DLprXVyKC +YmLjCAROSTmmTdedUIf1DNzLDAZEwSv9FyI4BVgHgxNP3M=
X-Google-Smtp-Source: ABdhPJyIHUGj2Fx7HXQesevbhx3hmOwkNd7L/1wZf928a+xdZoWkVmiHxG/9NFOlrT/kpxeBiwFqP8ud3O0J02E998g=
X-Received: by 2002:a2e:9a58:: with SMTP id k24mr821926ljj.496.1631724237170; Wed, 15 Sep 2021 09:43:57 -0700 (PDT)
MIME-Version: 1.0
References: <6130B864.50606@btconnect.com>
In-Reply-To: <6130B864.50606@btconnect.com>
From: "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
Date: Thu, 16 Sep 2021 01:43:20 +0900
Message-ID: <CAPK2DezAec7aFH3OTVeE8GRm7LcHNLixQ9F2+4xqGt-Nmf0uhA@mail.gmail.com>
To: t petch <ietfa@btconnect.com>
Cc: "i2nsf@ietf.org" <i2nsf@ietf.org>, Patrick Lingga <patricklink888@gmail.com>, "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com>
Content-Type: multipart/mixed; boundary="000000000000874bd905cc0b67e5"
Archived-At: <https://mailarchive.ietf.org/arch/msg/i2nsf/V5T8uQNOnJxImmP_R8UmqPC5i98>
Subject: Re: [I2nsf] [Last-Call] Yangdoctors last call review of draft-ietf-i2nsf-nsf-monitoring-data-model-06
X-BeenThere: i2nsf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "*I2NSF: Interface to Network Security Functions mailing list*" <i2nsf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/i2nsf>, <mailto:i2nsf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/i2nsf/>
List-Post: <mailto:i2nsf@ietf.org>
List-Help: <mailto:i2nsf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/i2nsf>, <mailto:i2nsf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Sep 2021 16:44:07 -0000
Hi Tom, Here is the revision to reflect your comments on the I2NSF Monitoring Interface Data Model: https://datatracker.ietf.org/doc/html/draft-ietf-i2nsf-nsf-monitoring-data-model-10 I attach the revision letter. Thanks. Best Regards, Paul and Patrick On Thu, Sep 2, 2021 at 8:41 PM t petch <ietfa@btconnect.com> wrote: > ----- Original Message ----- > From: "Mr. Jaehoon Paul Jeong" <jaehoon.paul@gmail.com> > Sent: Tuesday, August 24, 2021 3:27 PM > > > Hi Tom, > > Patrick and I have addressed your comments below with -09 version: > > > > I attach the revision letter to explain how to address them. > > > > Please let us know where this revision satisfies you or not. > > Paul > > Getting there. > > You have added some references to the YANG module - good - but you must > also add them to the I-D References > > I see > RFC854, RFC913, RFC1081, RFC4340, RFC4960, RFC5321, RFC7230, RFC7231. > RFC1081 is obsoleted by RFC1225 so that would likely be a better > reference. In other I-D you have cited RFC793bis - I do not know if > that is appropriate here. > > You import > ietf-i2nsf-policy-rule-for-nsf { > with prefix nsfi but in nsf-facing the prefix is nsfintf > Needs to be consistent > > In identity, derived from application-protocol (a base which I like), I > note that 'imap' is present elsewhere but not here. I do not know if > that is relevant to this module or not. > > In the data module: > > /http:/https:/ > > leaf src-zone { > I was thrown by this thinking of IPv6 address zones but the description > makes in clear that this is nothing of the sort. Probably not worth > changing but if you do I would suggest src-location as is used in the > description clause. > > leaf-list user-agent { > I think that the description violates (!) the limit on line length for > an RFC > > container i2nsf-counters { > description > "This is probably better covered by an import as this > This seems unfinished > > leaf alarm-type { > elsewhere you have switched to lower case (which I think right) but this > needs bringing in line (I do like consistency). > > 10. I2NSF Event Stream > you are using the NETMOD convention for line breaks; would benefit from > a reference > "line breaks as per [RFC8792] > > The I-D is big and I hope to find time this month to go through it again > in more detail. Meanwhile, on to capability. > > In passing, I get a bounce for skku-iotlab-members every time. > > Tom Petch > > > > > > > > > > > Thanks. > > > > Best Regards, > > Paul > > > > On Wed, May 5, 2021 at 7:44 PM t petch > <ietfa@btconnect.com<mailto:ietfa@btconnect.com>> wrote: > > Paul > > > > Top posting since this is a more general response (and leaving in YANG > > doctors since I note that five different YANG doctors reviewed the > five > > I-D and so might not see the issue that concerns me). > > > > As you have probably realised, I have now looked at the five YANG I-D > of > > I2NSF and am concerned at the disparate approaches to the same topics > > that I think will confuse a user and, likely, induce mistakes. I > > provided some detailed comments in response to WG LC on > > capability-data-model but really it cuts across all five. It may be > > that the inconsistenicies that I see can be justified but if so, then > I > > think that the I-D may need some text to say so, to relate one I-D to > > another. > > > > The treatment of YANG identity for ICMP is to me a clear example. I > > think that nsf-monitoring is good here, deriving icmpv4 and icmpv6 > from > > icmp (and ipv4 and ipv6) > > while capability is not good having icmp (sic) and icmpv6 as two > > unrelated identity, no common base. > > > > But at a higher level it may be that capability has a better treatment > > where it has > > base event; [from which is derived] > > identity system-event-capability { > > identity system-alarm-capability { > > > > base system-event-capability; > > identity access-violation { > > identity configuration-change { > > > > base system-alarm-capability; > > identity memory-alarm { > > identity cpu-alarm { > > identity disk-alarm { > > identity hardware-alarm { > > identity interface-alarm { > > > > while nsf-monitoring has > > > > base alarm-type; > > identity mem-usage-alarm { > > identity cpu-usage-alarm { > > identity disk-usage-alarm { > > identity hw-failure-alarm { > > identity ifnet-state-alarm { > > > > base event-type; > > identity access-denied { > > identity config-change { > > > > Different structure, different terminology, and these examples are > quite > > close compared to some others. I would expect at least the root of > the > > identifier to be the same if not the whole identifier. > > > > What is missing, for me, is an underlying, high-level, information > model > > to provide a consistent structure and a consistent terminology for the > > I2NSF YANG I-D. > > > > Tom Petch > > > > > > ----- Original Message ----- > > From: "Mr. Jaehoon Paul Jeong" > <jaehoon.paul@gmail.com<mailto:jaehoon.paul@gmail.com>> > > To: <tom petch> > > Cc: <Last Call>; <i2nsf@ietf.org<mailto:i2nsf@ietf.org>>; <Andy > Bierman>; <Yoav Nir>; > > > <draft-ietf-i2nsf-nsf-monitoring-data-model.all@ietf.org<mailto:draft-ie > tf-i2nsf-nsf-monitoring-data-model.all@ietf.org>>; <Linda > > Dunbar>; <Patrick Lingga>; <YANG Doctors>; <skku-iotlab-members>; <Mr. > > Jaehoon Paul Jeong> > > Sent: Thursday, April 29, 2021 3:49 PM > > Subject: Re: [I2nsf] [Last-Call] Yangdoctors last call review of > > draft-ietf-i2nsf-nsf-monitoring-data-model-06 > > > > > > > > Hi Tom, > > > > Patrick and I have addressed all your comments below with the > > following revision. > > > > > > > https://datatracker.ietf.org/doc/html/draft-ietf-i2nsf-nsf-monitoring-da > > > ta-model-08<https://datatracker.ietf.org/doc/html/draft-ietf-i2nsf-nsf-m > onitoring-data-model-08 > <https://datatracker.ietf.org/doc/html/draft-ietf-i2nsf-nsf-monitoring-data-model-08> > > > > > > > > > > I attach our revision letter. > > > > > > > > Thanks. > > > > > > > > Best Regards, > > > > Paul > > > > > > > > On Mon, Apr 12, 2021 at 6:59 PM tom petch > > > <daedulus@btconnect.com<mailto:daedulus@btconnect.com><mailto:daedulus@b > tconnect.com<mailto:daedulus@btconnect.com>>> wrote: > > > > Paul > > > > > > > > Some admin comments on -07; I think that you need to: > > > > > > > > - change the title in YANG revision reference > > > > > > > > - add to the I-D references > > > > RFC959 > > > > RFC8632 > > > > > > > > - shorten lines. There is a limit to line length in RFC as per the > > Style > > > > Guide. This is exceeded in the YANG where some of the path > statements > > > > take it over 80 while some of the examples are over 100. > > > > > > > > - add a reference for the import of > > > > ietf-i2nsf-policy-rule-for-nsf > > > > > > > > HTH > > > > > > > > Tom Petcb > > > > > > > > On 01/04/2021 03:09, Mr. Jaehoon Paul Jeong wrote: > > >>> > > > Hi Andy, Linda, and Yoav, > > >>> > > > Patrick and I have addressed all the comments from Andy. > > >>> > > > Here is the revised draft -07: > > > > ATT00001.txt 130 bytes > > > > Attachments: > > > Revision-Letter-for-NSF-Monitoring-YANG-Data-Model-version-09-20210824.d > ocx 103 kB > > > Revision-Letter-for-NSF-Monitoring-YANG-Data-Model-version-09-20210824.p > df 420 kB >
- [I2nsf] Yangdoctors last call review of draft-iet… Andy Bierman via Datatracker
- Re: [I2nsf] Yangdoctors last call review of draft… Mr. Jaehoon Paul Jeong
- Re: [I2nsf] Yangdoctors last call review of draft… Andy Bierman
- Re: [I2nsf] Yangdoctors last call review of draft… Mr. Jaehoon Paul Jeong
- Re: [I2nsf] [Last-Call] Yangdoctors last call rev… tom petch
- Re: [I2nsf] [Last-Call] Yangdoctors last call rev… Mr. Jaehoon Paul Jeong
- Re: [I2nsf] Yangdoctors last call review of draft… Mr. Jaehoon Paul Jeong
- Re: [I2nsf] [Last-Call] Yangdoctors last call rev… Mr. Jaehoon Paul Jeong
- Re: [I2nsf] [Last-Call] Yangdoctors last call rev… t petch
- Re: [I2nsf] [yang-doctors] [Last-Call] Yangdoctor… Martin Björklund
- Re: [I2nsf] [Last-Call] Yangdoctors last call rev… Mr. Jaehoon Paul Jeong
- Re: [I2nsf] [yang-doctors] [Last-Call] Yangdoctor… Mr. Jaehoon Paul Jeong
- Re: [I2nsf] [Last-Call] Yangdoctors last call rev… Mr. Jaehoon Paul Jeong
- Re: [I2nsf] [yang-doctors] [Last-Call] Yangdoctor… Mr. Jaehoon Paul Jeong
- Re: [I2nsf] [Last-Call] Yangdoctors last call rev… t petch
- Re: [I2nsf] [Last-Call] Yangdoctors last call rev… Mr. Jaehoon Paul Jeong
- Re: [I2nsf] [Last-Call] Yangdoctors last call rev… tom petch
- Re: [I2nsf] [Last-Call] Yangdoctors last call rev… Mr. Jaehoon Paul Jeong
- Re: [I2nsf] [Last-Call] Yangdoctors last call rev… Mr. Jaehoon Paul Jeong