Re: [i2rs] Yangdoctors early review of draft-ietf-i2rs-rib-data-model-09

Alia Atlas <akatlas@gmail.com> Thu, 15 February 2018 17:46 UTC

Return-Path: <akatlas@gmail.com>
X-Original-To: i2rs@ietfa.amsl.com
Delivered-To: i2rs@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 261451289B0; Thu, 15 Feb 2018 09:46:05 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ya4xxsxTv6OH; Thu, 15 Feb 2018 09:46:01 -0800 (PST)
Received: from mail-ot0-x236.google.com (mail-ot0-x236.google.com [IPv6:2607:f8b0:4003:c0f::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 207B2126C2F; Thu, 15 Feb 2018 09:46:01 -0800 (PST)
Received: by mail-ot0-x236.google.com with SMTP id w10so428313ote.13; Thu, 15 Feb 2018 09:46:01 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=OCmvQHjlDIJJ5GrtRw6bYvUdRLUCnC/joybVbGd4orA=; b=sIeit9oZV+Ot5zXpMjhPBQDggxUyfrPJOke2FJDXzfbts68QmVwiNhUOAmFS2Ljv6T Wv3gbeaYKzTU4cEJpgv5l9lmd1b1JyxWjJPRJNy8RaE4ZTlJEugKbIykAGu+GnRRAucc nPQpGtvkcZX0HtnH2dz8pyjxPDmH/RQnRa/QNrXevZqBvClHX1fIDZGYtYPCHYAM5CuM vfxKcbHa0wquf+3j2wwTrC7OCwneg/peYZPlfJWiia7+qgheH7DrwJbNDqP7kFBx+cff NDQLFPukvo0PUdQf81mJ6UPYGG/7f69/vi0ww+cy8JZMeaq+X7819Q36O+ztTUXFW806 DDPg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=OCmvQHjlDIJJ5GrtRw6bYvUdRLUCnC/joybVbGd4orA=; b=kxcn4w08rC7Hn/IXGhyKNMJY4HImwp0pH9rv/HLg0UCneypiRNKt6mhZmmBfbkS6oW vVPN6He9wrmLycm8tZ2T5irRijAY0S4A0eQvQspfEEQCcqOiZw4A+MkXtc4JPuhlFcPr DDHj3giSZrQAzRR80KxMUr1ndNOHVD6G9AuzXbIxjQpXgN32EmK2c95aY1U8sa9wnS38 N9eH8xK6X9vY+YfGpTyFRazQnmaYgQ7NQE6ftqqvzC6zDhIoIL+whCIZJYwHfqzfrQuH VFA6mUa3+mLfTSDj86iFd/7yt1EJwk8VGRV6oiggK1J33sGferabdmgGMT65SJZQk+SI YadA==
X-Gm-Message-State: APf1xPAKqdfIAVlt3H5wq/BvYDVHts0t06y3enkw9GCGuVtES4p+WBBc o060LqsVxrR291hvgPi61Tamoby/p+vXcvieVCGbYQ==
X-Google-Smtp-Source: AH8x227Xr4tJWWR0IJURW+r1GaXWjnC63L6rszYCgLwgaU5BDdHqGHIeY9YzzMQwD99N5dQqCB3ipjPkUouurFXw470=
X-Received: by 10.157.57.201 with SMTP id y67mr2630842otb.161.1518716760245; Thu, 15 Feb 2018 09:46:00 -0800 (PST)
MIME-Version: 1.0
Received: by 10.157.64.244 with HTTP; Thu, 15 Feb 2018 09:45:59 -0800 (PST)
In-Reply-To: <-fr3zxijwys35tfgc3uszu3h3-gljbeq-e2b3ap-fesm8gscai75-wh60zbguectj-2sihl4x86x6u-dgifw7-bnbnad6dxntr-b9wnyc-6924xl-ye2pzx-cuo4ms-abxxibpkbaebvbng6lo6bbu3a5y31.1518715077929@email.android.com>
References: <151626438402.10775.7250014155413667607@ietfa.amsl.com> <HE1PR0702MB35806D6985E0A7754F840EE193E80@HE1PR0702MB3580.eurprd07.prod.outlook.com> <009801d39042$6a4b08e0$3ee11aa0$@ndzh.com> <HE1PR0702MB358050A9745D827C522AB23993E80@HE1PR0702MB3580.eurprd07.prod.outlook.com> <CAG4d1rfHGYtB6iNdRS2cp=Q9qrF8trOizndwQqPx6_E8dZ-obw@mail.gmail.com> <HE1PR0702MB358079A69D1D1092F4DFA5A193F70@HE1PR0702MB3580.eurprd07.prod.outlook.com> <02e201d3a677$120087a0$360196e0$@ndzh.com> <-fr3zxijwys35tfgc3uszu3h3-gljbeq-e2b3ap-fesm8gscai75-wh60zbguectj-2sihl4x86x6u-dgifw7-bnbnad6dxntr-b9wnyc-6924xl-ye2pzx-cuo4ms-abxxibpkbaebvbng6lo6bbu3a5y31.1518715077929@email.android.com>
From: Alia Atlas <akatlas@gmail.com>
Date: Thu, 15 Feb 2018 12:45:59 -0500
Message-ID: <CAG4d1rea5yVPQuO6OhALJVqNuoXgC0vntGesQWxdR+Y0ZHzU_w@mail.gmail.com>
To: "wang_little_star@sina.com" <wang_little_star@sina.com>
Cc: Susan Hares <shares@ndzh.com>, Amit Dass <amit.dass@ericsson.com>, i2rs@ietf.org, draft-ietf-i2rs-rib-data-model.all@ietf.org
Content-Type: multipart/alternative; boundary="001a114072c8024bb7056543cd25"
Archived-At: <https://mailarchive.ietf.org/arch/msg/i2rs/0hbKm8b44TAlGf73Z1RHMKQvZPU>
Subject: Re: [i2rs] Yangdoctors early review of draft-ietf-i2rs-rib-data-model-09
X-BeenThere: i2rs@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Interface to The Internet Routing System \(IRS\)" <i2rs.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/i2rs>, <mailto:i2rs-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/i2rs/>
List-Post: <mailto:i2rs@ietf.org>
List-Help: <mailto:i2rs-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/i2rs>, <mailto:i2rs-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Feb 2018 17:46:05 -0000

Lixia,

When an internet-draft is submitted, there is an irrevocable and permanent
copyright given to the IETF.
Authors also retain their own copyright, of course.

The draft has 6 authors; there is always a need to justify that.  The IETF
strongly prefers no more than
5 authors.  The fact that you have stalled the process because you did not
respond to the IPR query
does not help.

WG Chairs may appoint and replace editors and authors of WG drafts.

Regards,
Alia

On Thu, Feb 15, 2018 at 12:17 PM, wang_little_star@sina.com <
wang_little_star@sina.com> wrote:

> Hello Susan,
> I'm the original author of this draft.
> Even now 70% of this draf is written by me, I have 70% copyright of this
> draft.
> So you cann't remove my name.
>
> Best Regards
> Lixing Wang
>
> 发自我的华为手机
>
>
> -------- 原始邮件 --------
> 主题:RE: Yangdoctors early review of draft-ietf-i2rs-rib-data-model-09
> 发件人:Susan Hares
> 收件人:'Amit Dass' ,'Alia Atlas'
> 抄送:i2rs@ietf.org,
>
>
>
> Amit:
>
>
>
> Remove one of the authors.   Please consider removing LIxing Wang.   I
> have not received an IPR statement from this person.   Please do this
> today.   I apologize for the delay in responding.
>
>
>
> Sue
>
>
>
> *From:* Amit Dass [mailto:amit.dass@ericsson.com]
> *Sent:* Monday, February 12, 2018 8:23 AM
> *To:* Alia Atlas
> *Cc:* Susan Hares; i2rs@ietf.org; draft-ietf-i2rs-rib-data-
> model.all@ietf.org
> *Subject:* FW: Yangdoctors early review of draft-ietf-i2rs-rib-data-
> model-09
>
>
>
> Hi Alia,
>
>
>
> Apologies for the delay. Needed to redo all again due to the laptop
> crashed. Updated the draft with the below comments. Couldn’t upload the
> same due to max 5 author limit kicking in.
>
>
>
> Best regards,
>
> Amit
>
>
>
> *From:* Alia Atlas [mailto:akatlas@gmail.com <akatlas@gmail.com>]
> *Sent:* Saturday, February 10, 2018 1:51 AM
> *To:* Amit Dass <amit.dass@ericsson.com>
> *Cc:* Susan Hares <shares@ndzh.com>; i2rs@ietf.org;
> draft-ietf-i2rs-rib-data-model.all@ietf.org
> *Subject:* Re: Yangdoctors early review of draft-ietf-i2rs-rib-data-
> model-09
>
>
>
> Hi Amit,
>
>
>
> It has been three weeks.
>
>
>
> Can you please get the update ASAP?  I need to get it reviewed and into
> IETF Last Call.
>
> As you know, I am closing I2RS at IETF 101 - which means this draft needs
> to be on the March 8 telechat.
>
> That means it really should be in IETF Last Call by February 16 - and I am
> traveling all next week
>
> and busy.   I REALLY need it ASAP to review.
>
>
>
> Regards,
>
> Alia
>
>
>
> On Thu, Jan 18, 2018 at 4:58 AM, Amit Dass <amit.dass@ericsson.com> wrote:
>
> Hi Sue,
>
> I expect to have some free time during this week.  Should be able to send
> the update by Monday next week.
>
> Best regards,
> Amit
>
> -----Original Message-----
>
> From: Susan Hares [mailto:shares@ndzh.com]
> Sent: Thursday, January 18, 2018 10:55 AM
> To: Amit Dass <amit.dass@ericsson.com>; 'Ebben Aries' <exa@juniper.net>;
> yang-doctors@ietf.org
> Cc: i2rs@ietf.org; draft-ietf-i2rs-rib-data-model.all@ietf.org;
> ietf@ietf.org
> Subject: RE: Yangdoctors early review of draft-ietf-i2rs-rib-data-model-09
>
> Amit:iir
>
> Do you think you and your co-authors can do this within a few days.   I
> would like to forward the publication request.
>
> Also, please remember to look at the latest Revised datastore draft and
> yang tree module drafts.
>
> Sue Hares
>
> -----Original Message-----
> From: Amit Dass [mailto:amit.dass@ericsson.com]
> Sent: Thursday, January 18, 2018 4:53 AM
> To: Ebben Aries; yang-doctors@ietf.org
> Cc: i2rs@ietf.org; draft-ietf-i2rs-rib-data-model.all@ietf.org;
> ietf@ietf.org
> Subject: RE: Yangdoctors early review of draft-ietf-i2rs-rib-data-model-09
>
> Thanks Ebben for reviewing the draft. I will update the same based on
> below comments and feedback.
>
>
> Best regards,
> Amit
>
> -----Original Message-----
> From: Ebben Aries [mailto:exa@juniper.net]
> Sent: Thursday, January 18, 2018 9:33 AM
> To: yang-doctors@ietf.org
> Cc: i2rs@ietf.org; draft-ietf-i2rs-rib-data-model.all@ietf.org;
> ietf@ietf.org
> Subject: Yangdoctors early review of draft-ietf-i2rs-rib-data-model-09
>
> Reviewer: Ebben Aries
> Review result: On the Right Track
>
> 1 module in this draft:
> - ietf-i2rs-rib@2017-12-05.yang
>
> No YANG validation errors or warnings (from pyang 1.7.3 and yanglint
> 0.14.59)
>
> 0 examples are provided in this draft (section 3.12 of
> draft-ietf-netmod-rfc6087bis-15)
>
> Module ietf-i2rs-rib@2017-12-05.yang:
> - yang-version statement missing - should be 1.1
> - prefix 'iir' is recommended for this module, would 'rib' suffice better?
> - import "ietf-inet-types" should reference RFC 6991 per (not as a comment)
>   https://tools.ietf.org/html/draft-ietf-netmod-rfc6087bis-15#section-4.7
> - import "ietf-interfaces" should reference RFC 7223 per
>   https://tools.ietf.org/html/draft-ietf-netmod-rfc6087bis-15#section-4.7
> - import "ietf-yang-types" should reference RFC 6991 per
>   https://tools.ietf.org/html/draft-ietf-netmod-rfc6087bis-15#section-4.7
> - Since this module imports "ietf-interfaces", a normative references must
> be
>   added per
>   https://tools.ietf.org/html/draft-ietf-netmod-rfc6087bis-15#section-3.9
> - prefix "if" in the import "ietf-interfaces" can remove quotes to remain
>   consistent with other imports
> - Remove WG Chairs from contact information per
>   https://tools.ietf.org/html/draft-ietf-netmod-rfc6087bis-15#appendix-C
> - Module description must contain most recent copyright notice per
>   https://tools.ietf.org/html/draft-ietf-netmod-rfc6087bis-15#appendix-C
> - Module description should contain note to RFC Ed. and placeholder
> reference
>   to RFC when assigned
>   https://tools.ietf.org/html/draft-ietf-netmod-rfc6087bis-15#appendix-C
> - Add placeholder reference and note to RFC Ed. for RFC when assigned
>   https://tools.ietf.org/html/draft-ietf-netmod-rfc6087bis-15#appendix-C
> - Security Considerations should be updated to reflect new template at
>   https://trac.ietf.org/trac/ops/wiki/yang-security-guidelines
> - Section 1.2 should be replaced with reference to
>   draft-ietf-netmod-yang-tree-diagrams-02 rather (as-is in other i2rs YANG
>   drafts in progress) per
>   https://tools.ietf.org/html/draft-ietf-netmod-rfc6087bis-
> 15#section-2.5.1
> - This module contains '12' features.  While it is understood the purpose
> of
>   these features in the module, take precaution as to complexity for
> clients
>   if they need to understand >= quantity of features per module in use on a
>   network-element.
> - A few comments exist that are either unecessary or redundant.  Encode the
>   comment intent rather in description fields if need be.
> - Per NMDA, which datastores are targeted for the module?  Will all RPC
>   operations be acting upon the dynamic/ephemeral datastore?  It is not
> clear
>   to me if the intention is to be persistent or ephemeral
>
> General comments/Nits:
> - references to 'def' could be expanded out to 'definition'
> - references to 'decap' could be expanded out to 'decapsulation' for
>   readability (across definitions and descriptions)
> - Follow consistent capitalization of 'RIB' throughout document text.
> Mixed
>   use of 'Rib' and 'rib' exists (Outside of YANG node lowercase
> definitions).
> - Is it necessary to prefix all nodes under the nexthop container with
>   "nexthop-"?
> - Section 2.5 - route-add RPC - text mentions it is required that the
> nh-add
>   RPC be called as a pre-requisite however if the nh already exists and the
>   nexthop-id is known, this should not be necessary.  In addition, the text
>   reads 'or return' which should rather be a result of querying the
>   appropriate node in the data tree.
> - In 'IANA Considerations' - s/This document requests to register/This
>   document registers/
>
>
>
>