Re: [i2rs] Yangdoctors early review of draft-ietf-i2rs-rib-data-model-09
"Susan Hares" <shares@ndzh.com> Thu, 18 January 2018 09:55 UTC
Return-Path: <shares@ndzh.com>
X-Original-To: i2rs@ietfa.amsl.com
Delivered-To: i2rs@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C27A512EB2C; Thu, 18 Jan 2018 01:55:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.945
X-Spam-Level:
X-Spam-Status: No, score=0.945 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DOS_OUTLOOK_TO_MX=2.845] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ubwk39OlG0mo; Thu, 18 Jan 2018 01:55:07 -0800 (PST)
Received: from hickoryhill-consulting.com (50-245-122-97-static.hfc.comcastbusiness.net [50.245.122.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AD41B12EB2A; Thu, 18 Jan 2018 01:55:06 -0800 (PST)
X-Default-Received-SPF: pass (skip=loggedin (res=PASS)) x-ip-name=166.176.249.181;
From: Susan Hares <shares@ndzh.com>
To: 'Amit Dass' <amit.dass@ericsson.com>, 'Ebben Aries' <exa@juniper.net>, yang-doctors@ietf.org
Cc: i2rs@ietf.org, draft-ietf-i2rs-rib-data-model.all@ietf.org, ietf@ietf.org
References: <151626438402.10775.7250014155413667607@ietfa.amsl.com> <HE1PR0702MB35806D6985E0A7754F840EE193E80@HE1PR0702MB3580.eurprd07.prod.outlook.com>
In-Reply-To: <HE1PR0702MB35806D6985E0A7754F840EE193E80@HE1PR0702MB3580.eurprd07.prod.outlook.com>
Date: Thu, 18 Jan 2018 04:55:03 -0500
Message-ID: <009801d39042$6a4b08e0$3ee11aa0$@ndzh.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQC3u74PMe0eeI3XGuaBaMtbP6kcDwEkBmjSpafs26A=
Content-Language: en-us
X-Authenticated-User: skh@ndzh.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/i2rs/B2A02TZ636TJ8ijj76aYsZSJxDA>
Subject: Re: [i2rs] Yangdoctors early review of draft-ietf-i2rs-rib-data-model-09
X-BeenThere: i2rs@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Interface to The Internet Routing System \(IRS\)" <i2rs.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/i2rs>, <mailto:i2rs-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/i2rs/>
List-Post: <mailto:i2rs@ietf.org>
List-Help: <mailto:i2rs-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/i2rs>, <mailto:i2rs-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jan 2018 09:55:09 -0000
Amit: Do you think you and your co-authors can do this within a few days. I would like to forward the publication request. Also, please remember to look at the latest Revised datastore draft and yang tree module drafts. Sue Hares -----Original Message----- From: Amit Dass [mailto:amit.dass@ericsson.com] Sent: Thursday, January 18, 2018 4:53 AM To: Ebben Aries; yang-doctors@ietf.org Cc: i2rs@ietf.org; draft-ietf-i2rs-rib-data-model.all@ietf.org; ietf@ietf.org Subject: RE: Yangdoctors early review of draft-ietf-i2rs-rib-data-model-09 Thanks Ebben for reviewing the draft. I will update the same based on below comments and feedback. Best regards, Amit -----Original Message----- From: Ebben Aries [mailto:exa@juniper.net] Sent: Thursday, January 18, 2018 9:33 AM To: yang-doctors@ietf.org Cc: i2rs@ietf.org; draft-ietf-i2rs-rib-data-model.all@ietf.org; ietf@ietf.org Subject: Yangdoctors early review of draft-ietf-i2rs-rib-data-model-09 Reviewer: Ebben Aries Review result: On the Right Track 1 module in this draft: - ietf-i2rs-rib@2017-12-05.yang No YANG validation errors or warnings (from pyang 1.7.3 and yanglint 0.14.59) 0 examples are provided in this draft (section 3.12 of draft-ietf-netmod-rfc6087bis-15) Module ietf-i2rs-rib@2017-12-05.yang: - yang-version statement missing - should be 1.1 - prefix 'iir' is recommended for this module, would 'rib' suffice better? - import "ietf-inet-types" should reference RFC 6991 per (not as a comment) https://tools.ietf.org/html/draft-ietf-netmod-rfc6087bis-15#section-4.7 - import "ietf-interfaces" should reference RFC 7223 per https://tools.ietf.org/html/draft-ietf-netmod-rfc6087bis-15#section-4.7 - import "ietf-yang-types" should reference RFC 6991 per https://tools.ietf.org/html/draft-ietf-netmod-rfc6087bis-15#section-4.7 - Since this module imports "ietf-interfaces", a normative references must be added per https://tools.ietf.org/html/draft-ietf-netmod-rfc6087bis-15#section-3.9 - prefix "if" in the import "ietf-interfaces" can remove quotes to remain consistent with other imports - Remove WG Chairs from contact information per https://tools.ietf.org/html/draft-ietf-netmod-rfc6087bis-15#appendix-C - Module description must contain most recent copyright notice per https://tools.ietf.org/html/draft-ietf-netmod-rfc6087bis-15#appendix-C - Module description should contain note to RFC Ed. and placeholder reference to RFC when assigned https://tools.ietf.org/html/draft-ietf-netmod-rfc6087bis-15#appendix-C - Add placeholder reference and note to RFC Ed. for RFC when assigned https://tools.ietf.org/html/draft-ietf-netmod-rfc6087bis-15#appendix-C - Security Considerations should be updated to reflect new template at https://trac.ietf.org/trac/ops/wiki/yang-security-guidelines - Section 1.2 should be replaced with reference to draft-ietf-netmod-yang-tree-diagrams-02 rather (as-is in other i2rs YANG drafts in progress) per https://tools.ietf.org/html/draft-ietf-netmod-rfc6087bis-15#section-2.5.1 - This module contains '12' features. While it is understood the purpose of these features in the module, take precaution as to complexity for clients if they need to understand >= quantity of features per module in use on a network-element. - A few comments exist that are either unecessary or redundant. Encode the comment intent rather in description fields if need be. - Per NMDA, which datastores are targeted for the module? Will all RPC operations be acting upon the dynamic/ephemeral datastore? It is not clear to me if the intention is to be persistent or ephemeral General comments/Nits: - references to 'def' could be expanded out to 'definition' - references to 'decap' could be expanded out to 'decapsulation' for readability (across definitions and descriptions) - Follow consistent capitalization of 'RIB' throughout document text. Mixed use of 'Rib' and 'rib' exists (Outside of YANG node lowercase definitions). - Is it necessary to prefix all nodes under the nexthop container with "nexthop-"? - Section 2.5 - route-add RPC - text mentions it is required that the nh-add RPC be called as a pre-requisite however if the nh already exists and the nexthop-id is known, this should not be necessary. In addition, the text reads 'or return' which should rather be a result of querying the appropriate node in the data tree. - In 'IANA Considerations' - s/This document requests to register/This document registers/
- [i2rs] Yangdoctors early review of draft-ietf-i2r… Ebben Aries
- Re: [i2rs] Yangdoctors early review of draft-ietf… Amit Dass
- Re: [i2rs] Yangdoctors early review of draft-ietf… Susan Hares
- Re: [i2rs] Yangdoctors early review of draft-ietf… Amit Dass
- Re: [i2rs] Yangdoctors early review of draft-ietf… Alia Atlas
- [i2rs] FW: Yangdoctors early review of draft-ietf… Amit Dass
- Re: [i2rs] Yangdoctors early review of draft-ietf… Susan Hares
- Re: [i2rs] Yangdoctors early review of draft-ietf… Alia Atlas
- Re: [i2rs] Yangdoctors early review of draft-ietf… Alia Atlas
- Re: [i2rs] Yangdoctors early review of draft-ietf… Susan Hares
- Re: [i2rs] FW: Yangdoctors early review of draft-… Alia Atlas
- Re: [i2rs] FW: Yangdoctors early review of draft-… Amit Dass
- Re: [i2rs] Yangdoctors early review of draft-ietf… t.petch
- Re: [i2rs] Yangdoctors early review of draft-ietf… Amit Dass
- Re: [i2rs] Yangdoctors early review of draft-ietf… Amit Dass
- Re: [i2rs] [yang-doctors] Yangdoctors early revie… Mahesh Jethanandani
- Re: [i2rs] [yang-doctors] Yangdoctors early revie… t.petch
- Re: [i2rs] Yangdoctors early review of draft-ietf… Ebben Aries
- Re: [i2rs] [yang-doctors] Yangdoctors early revie… Ebben Aries
- Re: [i2rs] [yang-doctors] Yangdoctors early revie… Reshad Rahman (rrahman)