Re: [i2rs] WG LC: draft-ietf-i2rs-yang-l2-network-topology-07.txt

Qin Wu <bill.wu@huawei.com> Mon, 19 August 2019 05:04 UTC

Return-Path: <bill.wu@huawei.com>
X-Original-To: i2rs@ietfa.amsl.com
Delivered-To: i2rs@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 663F212009C for <i2rs@ietfa.amsl.com>; Sun, 18 Aug 2019 22:04:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.201
X-Spam-Level:
X-Spam-Status: No, score=-4.201 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EMltW6_m3T5c for <i2rs@ietfa.amsl.com>; Sun, 18 Aug 2019 22:04:01 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7C15712007C for <i2rs@ietf.org>; Sun, 18 Aug 2019 22:04:01 -0700 (PDT)
Received: from lhreml701-cah.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id 30FCCD0D4F57E5E40CD1; Mon, 19 Aug 2019 06:03:58 +0100 (IST)
Received: from lhreml711-chm.china.huawei.com (10.201.108.62) by lhreml701-cah.china.huawei.com (10.201.108.42) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 19 Aug 2019 06:03:57 +0100
Received: from lhreml711-chm.china.huawei.com (10.201.108.62) by lhreml711-chm.china.huawei.com (10.201.108.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 19 Aug 2019 06:03:57 +0100
Received: from DGGEML423-HUB.china.huawei.com (10.1.199.40) by lhreml711-chm.china.huawei.com (10.201.108.62) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.1.1713.5 via Frontend Transport; Mon, 19 Aug 2019 06:03:57 +0100
Received: from DGGEML511-MBX.china.huawei.com ([169.254.1.9]) by dggeml423-hub.china.huawei.com ([10.1.199.40]) with mapi id 14.03.0439.000; Mon, 19 Aug 2019 13:03:51 +0800
From: Qin Wu <bill.wu@huawei.com>
To: tom petch <ietfc@btconnect.com>, Susan Hares <shares@ndzh.com>, "i2rs@ietf.org" <i2rs@ietf.org>
CC: "russ@riw.us" <russ@riw.us>
Thread-Topic: [i2rs] WG LC: draft-ietf-i2rs-yang-l2-network-topology-07.txt
Thread-Index: AdVWNoOBQxbXHgDRS5uPRBuG1NXoRQ==
Date: Mon, 19 Aug 2019 05:03:51 +0000
Message-ID: <B8F9A780D330094D99AF023C5877DABAA92A60AA@dggeml511-mbx.china.huawei.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.134.31.203]
Content-Type: text/plain; charset="gb2312"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/i2rs/MtplUkQcsd4r7q3zcRXCSWDhxIs>
Subject: Re: [i2rs] WG LC: draft-ietf-i2rs-yang-l2-network-topology-07.txt
X-BeenThere: i2rs@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Interface to The Internet Routing System \(IRS\)" <i2rs.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/i2rs>, <mailto:i2rs-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/i2rs/>
List-Post: <mailto:i2rs@ietf.org>
List-Help: <mailto:i2rs-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/i2rs>, <mailto:i2rs-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Aug 2019 05:04:05 -0000

Hi, Tom:
Thank for your valuable review. See comments inline below.
-----邮件原件-----
发件人: i2rs [mailto:i2rs-bounces@ietf.org] 代表 tom petch
发送时间: 2019年8月16日 20:00
收件人: Susan Hares <shares@ndzh.com>om>; i2rs@ietf.org
抄送: russ@riw.us
主题: Re: [i2rs] WG LC: draft-ietf-i2rs-yang-l2-network-topology-07.txt

Not ready

The text says
    /*Consider udpating this part to make use of draft-ietf-softwire-iftunnel*/ Well yes, consider it and come to a conclusion otherwise I cannot see how this is ready to advance.
[Qin]: Good catch, will fix this. The idea is to align with RFC7224 and reuse iana-interface-type.

The YANG module contains many references - good - but they are not in the I-D references; again, not ready to advance.  I see

4761
4762
6325
6326
7348

802.1ad
802.1ah
802.1Q

[Qin]:Fixed.
IANA considerations references RFC7950 - RFC 6020 is better here as all that RFC7950 says is go see RFC6020.
[Qin]:Agree, will update based on your suggestion.

OLD

       This version of this YANG module is part of
       draft-ietf-i2rs-yang-l2-network-topo-07;

NEW
       This version of this YANG module is part of
        "RFC XXXX: A YANG Data Model for Layer-2 Network Topologies"

[Qin]:Fixed.
You also have this unsuitable reference twice in the state module
[Qin]:Fixed.
The state module lacks references for the imports
[Qin]:Fixed.
The state module description clause seems misleading; it is only the state part of a module when NMDA is not supported.
[Qin]:Fixed.
Appendix A - is it Normative?  The customary convention is the Appendices are not unless stated otherwise and there is no statement here.
[Qin]:No, will make this clear.
'An Example' does not use the addresses set aside for documentation
[Qin]:Good catch, will use RFC7042 recommended address range.
What is the closing date for this Last call?

Tom Petch

----- Original Message -----
From: "Susan Hares" <shares@ndzh.com>
To: <i2rs@ietf.org>
Cc: <russ@riw.us>
Sent: Friday, August 09, 2019 4:42 PM


> Greetings:
>
>
>
> This draft on L2 network topology has been reviewed by the I2RS WG 3
times.
>
> However, in discussion with the ADs it is deemed appropriate to do one
more
>
> WG LC and include any input from rtgwg or grow.
>
>
>
> Please indicate whether you support publication of this document.
>
> In your comments, please indicate "support" or no "support".
>
>
>
> If you feel there issues that need to be resolved,
>
> Please indicate whether these issues are editorial,
>
> Yang syntax, or technical content.
>
>
>
> It would be helpful to indicate whether you know of
>
> Network deployments or potential network deployments of this draft.
>
>
>
> Cheerily,
>
>
>
> Sue Hares
>
>
>
>


------------------------------------------------------------------------
--------


> _______________________________________________
> i2rs mailing list
> i2rs@ietf.org
> https://www.ietf.org/mailman/listinfo/i2rs
>

_______________________________________________
i2rs mailing list
i2rs@ietf.org
https://www.ietf.org/mailman/listinfo/i2rs