Re: [Id-event] Roman Danyliw's No Objection on draft-ietf-secevent-http-poll-11: (with COMMENT)

Benjamin Kaduk <kaduk@mit.edu> Thu, 25 June 2020 22:32 UTC

Return-Path: <kaduk@mit.edu>
X-Original-To: id-event@ietfa.amsl.com
Delivered-To: id-event@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2C0EF3A104E; Thu, 25 Jun 2020 15:32:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.897
X-Spam-Level:
X-Spam-Status: No, score=-1.897 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZRkOLjPjaz3N; Thu, 25 Jun 2020 15:32:18 -0700 (PDT)
Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DB2283A104B; Thu, 25 Jun 2020 15:32:17 -0700 (PDT)
Received: from kduck.mit.edu ([24.16.140.251]) (authenticated bits=56) (User authenticated as kaduk@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 05PMW9qG010184 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Jun 2020 18:32:12 -0400
Date: Thu, 25 Jun 2020 15:32:09 -0700
From: Benjamin Kaduk <kaduk@mit.edu>
To: Mike Jones <Michael.Jones=40microsoft.com@dmarc.ietf.org>
Cc: Roman Danyliw <rdd@cert.org>, The IESG <iesg@ietf.org>, "secevent-chairs@ietf.org" <secevent-chairs@ietf.org>, Yaron Sheffer <yaronf.ietf@gmail.com>, "id-event@ietf.org" <id-event@ietf.org>, "draft-ietf-secevent-http-poll@ietf.org" <draft-ietf-secevent-http-poll@ietf.org>
Message-ID: <20200625223209.GC58278@kduck.mit.edu>
References: <CH2PR00MB0678403D85CEDDC7C51DBA37F5920@CH2PR00MB0678.namprd00.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CH2PR00MB0678403D85CEDDC7C51DBA37F5920@CH2PR00MB0678.namprd00.prod.outlook.com>
User-Agent: Mutt/1.12.1 (2019-06-15)
Archived-At: <https://mailarchive.ietf.org/arch/msg/id-event/1fMAiRkBpBQYDw6xfUJOPE-3tAA>
Subject: Re: [Id-event] Roman Danyliw's No Objection on draft-ietf-secevent-http-poll-11: (with COMMENT)
X-BeenThere: id-event@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "A mailing list to discuss the potential solution for a common identity event messaging format and distribution system." <id-event.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/id-event>, <mailto:id-event-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/id-event/>
List-Post: <mailto:id-event@ietf.org>
List-Help: <mailto:id-event-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/id-event>, <mailto:id-event-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Jun 2020 22:32:20 -0000

On Thu, Jun 25, 2020 at 05:44:20AM +0000, Mike Jones wrote:
> Thanks for your review, Roman.  https://tools.ietf.org/html/draft-ietf-secevent-http-poll-12 is intended to address your comments.  Detailed replies are inline, prefixed by "Mike>".
> 
> -----Original Message-----
> From: Roman Danyliw via Datatracker <noreply@ietf.org> 
> Sent: Tuesday, June 23, 2020 8:09 AM
> To: The IESG <iesg@ietf.org>
> Cc: draft-ietf-secevent-http-poll@ietf.org; secevent-chairs@ietf.org; id-event@ietf.org; Yaron Sheffer <yaronf.ietf@gmail.com>; yaronf.ietf@gmail.com
> Subject: Roman Danyliw's No Objection on draft-ietf-secevent-http-poll-11: (with COMMENT)
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> ** Section 2.2.  Per the ack array, is it fair to assume that an empty array is ignored?
> 
> Mike> It unambiguously is now. ;-)

It's good to be explicit about this.
(FWIW, my assumption in the previous undocumented state is that an empty
array was an error and would be rejected, though I don't think we
particularly benefit from such strict parsing semantics in this case.)

-Ben