IETF Logo Mail Archive

Re: [Id-event] WG Last Call for draft-ietf-secevent-token-02

Nat Sakimura <sakimura@gmail.com> Wed, 02 August 2017 17:07 UTC

Return-Path: <sakimura@gmail.com>
X-Original-To: id-event@ietfa.amsl.com
Delivered-To: id-event@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4D3601317C1 for <id-event@ietfa.amsl.com>; Wed, 2 Aug 2017 10:07:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.988
X-Spam-Level:
X-Spam-Status: No, score=-1.988 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7BDsGy3qxNJx for <id-event@ietfa.amsl.com>; Wed, 2 Aug 2017 10:07:25 -0700 (PDT)
Received: from mail-qt0-x230.google.com (mail-qt0-x230.google.com [IPv6:2607:f8b0:400d:c0d::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2CB20120713 for <id-event@ietf.org>; Wed, 2 Aug 2017 10:07:25 -0700 (PDT)
Received: by mail-qt0-x230.google.com with SMTP id p3so30541051qtg.2 for <id-event@ietf.org>; Wed, 02 Aug 2017 10:07:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hQsBc1GrVTaQDp3l9KJeuZ0CsjjeSpDEAMjWZPA9OL8=; b=S14bls9eyUa339fD6ru+YwJ5RGWH5sdczyMVpIah5MFHjBxa+sPrlFBlstZb1rd5fE q/rQFLjg3nazfPEso0pN6vafvHeat/1eWuHgGTxfi/0xVrvB0TtGmTUBJZiHbIbcxiKY O5jcRzfUWHnQq6FeBoARCmLFBP1zRQQLGaS7fF27fVUcgs4l/9M5yD+R0Vk5q8hh/O3x FghkxMCfdMFLYMt4qSFDuNJSKbVYstNxSQcF5vo1J+Z8TD1MUqyI4e17rGDvqUNOcXgo PlcwYAgR5ExHkh4M8cHHbyCWqz+fG9thKpf3OQPNO5GIerFNI+Id1FC1fiDm7GSNRsv6 bS4g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hQsBc1GrVTaQDp3l9KJeuZ0CsjjeSpDEAMjWZPA9OL8=; b=q36oMfwlsxjax6XaMkv30X6J52VZl1N3K0QcRfRvJmicudZJlIiA4dm4zK7/A5vxBA vHu9KyFJAUBFZBNEBF9MkKsyHwtXMLWwQpqNgJ3H3X66RLUas3lqgaE0HTewcR6e5BJ2 6FE23wPuT4/Fv06lqqxpOuTZd/vAFVqXXdYXkB/CHkukkNqb+BJzvq2Sy1rCFDsK1QMJ WfgOzlB2sxvdo1UtjEy/KMx9a5NDY0uvRO6n6Oxw1W3YL/a/Gh6TxmVdOA9HgW7aU9al B8/fDLQyijs+NWvqr2N7CNRA8WL1LBwt17sEh9R3GH/aj0Mutstyls8YWE5IQLt4qSIZ RHLw==
X-Gm-Message-State: AIVw1128fT1AZrsAaCGzURU3RbzRKnwwzv0HyUs7XepXuvuIXIBoeQPA ipTIJOqm1QWvt3oLK+cR5GOB221vWA==
X-Received: by 10.200.40.23 with SMTP id 23mr31995362qtq.206.1501693644005; Wed, 02 Aug 2017 10:07:24 -0700 (PDT)
MIME-Version: 1.0
References: <e6649728-f94a-93f5-9885-c948a5b0ed49@gmail.com> <CY4PR21MB0504DEA69A048EADE122995DF5B20@CY4PR21MB0504.namprd21.prod.outlook.com> <D263DE2D-48F7-4AF5-B96F-B83AAED779F6@openconsentgroup.com>
In-Reply-To: <D263DE2D-48F7-4AF5-B96F-B83AAED779F6@openconsentgroup.com>
From: Nat Sakimura <sakimura@gmail.com>
Date: Wed, 02 Aug 2017 17:07:12 +0000
Message-ID: <CABzCy2Cxhs_4soMY+iKwva4YrCpKD9fGngb+ffMV6z2nwzJg0A@mail.gmail.com>
To: "M.Lizar@OCG" <m.lizar@openconsentgroup.com>, Mike Jones <Michael.Jones@microsoft.com>
Cc: Yaron Sheffer <yaronf.ietf@gmail.com>, SecEvent <id-event@ietf.org>
Content-Type: multipart/alternative; boundary="001a11407a0a3668f30555c84c13"
Archived-At: <https://mailarchive.ietf.org/arch/msg/id-event/F4MhXa0bzrjTSPQyGrf0UEtmT3Q>
Subject: Re: [Id-event] WG Last Call for draft-ietf-secevent-token-02
X-BeenThere: id-event@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "A mailing list to discuss the potential solution for a common identity event messaging format and distribution system." <id-event.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/id-event>, <mailto:id-event-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/id-event/>
List-Post: <mailto:id-event@ietf.org>
List-Help: <mailto:id-event-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/id-event>, <mailto:id-event-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Aug 2017 17:07:27 -0000

Thanks, it looks generally good. I had only three small nits.

*1) "MUST NOT" in the introduction. *
---------------------------------------------------
I feel that it is better to have this MUST NOT in the main text. The
introduction often is skipped by a reader.

*2) Potentially missing "defined in " in Section 2 the first bullet*
------------------------------------------------------------------------------------------------------
There seems to be missing "defined in" in the sentence "the JWT Token
Claims Registry Section 10.1".

*3) Issuer validation*
----------------------------------
I am not sure how to do an issuer validation when using unsecured JWT.
Adding more explanation would be beneficial.

Best,

Nat

On Wed, Aug 2, 2017 at 1:18 AM M.Lizar@OCG <m.lizar@openconsentgroup.com>
wrote:

> +1 on existing text .
>
> Agree the document is ready to publish
>
> - Mark
>
> On 31 Jul 2017, at 16:53, Mike Jones <Michael.Jones@microsoft.com> wrote:
>
> I believe that the specification is ready to publish as-is.  It already
> meets the needs of the known use cases and is in production use.
>
>                                                                 -- Mike
>
> *From:* Id-event [mailto:id-event-bounces@ietf.org
> <id-event-bounces@ietf.org>] *On Behalf Of *Yaron Sheffer
> *Sent:* Monday, July 31, 2017 1:40 PM
> *To:* SecEvent <id-event@ietf.org>
> *Subject:* [Id-event] WG Last Call for draft-ietf-secevent-token-02
>
>
> This is to announce working group last call on this draft (
> https://datatracker.ietf.org/doc/draft-ietf-secevent-token/).
>
> Please send your comments to the list. Even if you are perfectly happy
> with the draft, please let us know that you support its publication as-is
> by posting to the list.
>
> Because of the summer holidays, this last call is open for 3 weeks, until
> Aug. 21.
>
> Thanks,
>     Dick and Yaron
>
> _______________________________________________
> Id-event mailing list
> Id-event@ietf.org
> https://www.ietf.org/mailman/listinfo/id-event
>
> _______________________________________________
> Id-event mailing list
> Id-event@ietf.org
> https://www.ietf.org/mailman/listinfo/id-event
>
-- 

Nat Sakimura

Chairman of the Board, OpenID Foundation

v2.23.0 | Report a Bug | By Email