[Idr] RtgDir review: draft-ietf-idr-bgp-ls-flex-algo-05.txt

"Andrew G. Malis" <agmalis@gmail.com> Mon, 16 November 2020 21:57 UTC

Return-Path: <agmalis@gmail.com>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost []) by ietfa.amsl.com (Postfix) with ESMTP id 9DC893A14EF; Mon, 16 Nov 2020 13:57:00 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([]) by localhost (ietfa.amsl.com []) (amavisd-new, port 10024) with ESMTP id 7g5YhTY8acVB; Mon, 16 Nov 2020 13:56:58 -0800 (PST)
Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id ADDA83A14EA; Mon, 16 Nov 2020 13:56:55 -0800 (PST)
Received: by mail-qk1-x735.google.com with SMTP id q5so18544285qkc.12; Mon, 16 Nov 2020 13:56:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=gll2AuoqugXFFNTW8JuarzkuTB/sBpDsZ8k4VRjVmiE=; b=GL5pi7OWN7q/uvcxVC6uXZGVCSN8+nipjiydAZOKyzDmfbKt7uwLD9o1l6yJ9PoICY 8J2k7LxSIUXlpVtjnwBwO30AI7M1EjOt9kSU3U2eOXMGbqilasYmKtMl2ayZ96ktAOI8 UXd+2WlULyr1UjjRh4wyDAG4rLlwBO/3LRYXVSJLelRsm2MHTz+G0X82ezzHOpQw4i94 tV1PxHJTNDXU5LR6bgJHyeOxxticxVMDEUMf9RaM3Oxa0lgt0gkCaqS2+tnVYpbXzowP WZ+rtCmTa0J+qPsAMLzsopo5S3EjBspT0QYFfJo2oe9N0G1QBy4yvwtfqZv1mzcikrhZ 4mog==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=gll2AuoqugXFFNTW8JuarzkuTB/sBpDsZ8k4VRjVmiE=; b=gG3KvtTwIb+4tlExOSg+TWqNPIsvVklRXTYn1/kybfCaeeotEKuuSh3JW59Oqhf0DR iPHkkL3e0tQKrUxsN+cB9v59K0v5+/B65/mgqilSFRUT05G7lARQbKqEb2opG9VX327r 4b+OtDYaBOHwyLYI8TCR95SDz+5PEFh4SWR8TM93lM61Mm8vdnKQ7HH8v5MQGacCb/Hb T+ajnwUJBZGmjVrMdCMlM3l0MMFtFugUl5tq7+uIp61p8oSlGuvZq+mmVcCwOqmDludl uJY8yVooQXxGHld3czHwNA1q8QDZWpXb3g/reoyiGRDPuAPZD7jpT9u003e0L4c74dSz +ZXA==
X-Gm-Message-State: AOAM531RIrpqg1+WO0Bj4SmV8Ukg/zc86x0ZrDx5bJCfP9AziAhY04hO UshN4uv1YQSl4a/oRAuqXa9GI1wHmnwn3B88q3GJ7WGGBo4=
X-Google-Smtp-Source: ABdhPJwbSN4Uetb5HoqkFbHLcchhTIyXN2nnRDqtAcq0p+iVbJOq8s+KPAc7Y2DGQ3CjnhbWNt9IvztH8MFQm0KdCrc=
X-Received: by 2002:a37:4c81:: with SMTP id z123mr17067562qka.249.1605563814490; Mon, 16 Nov 2020 13:56:54 -0800 (PST)
MIME-Version: 1.0
From: "Andrew G. Malis" <agmalis@gmail.com>
Date: Mon, 16 Nov 2020 16:56:43 -0500
Message-ID: <CAA=duU3h29Fzdy=nfAwafBc32CA1fjTMU1LO4jBfYdbT59RHNA@mail.gmail.com>
To: "<rtg-ads@ietf.org>" <rtg-ads@ietf.org>
Cc: Routing Directorate <rtg-dir@ietf.org>, draft-ietf-idr-bgp-ls-flex-algo.all@ietf.org, idr@ietf.org
Content-Type: multipart/alternative; boundary="000000000000d3b91505b44074a1"
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/-pKiCXL2PA9pjt1FCVPz976ddXk>
Subject: [Idr] RtgDir review: draft-ietf-idr-bgp-ls-flex-algo-05.txt
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Nov 2020 21:57:01 -0000


I have been selected as the Routing Directorate reviewer for this draft.
The Routing Directorate seeks to review all routing or routing-related
drafts as they pass through IETF last call and IESG review, and sometimes
on special request (in this case, WG last call). The purpose of the review
is to provide assistance to the Routing ADs. For more information about the
Routing Directorate, please see

Although these comments are primarily for the use of the Routing ADs, it
would be helpful if you could consider them along with any other WG Last
Call comments that you receive, and strive to resolve them through
discussion or by updating the draft.

Document: draft-ietf-idr-bgp-ls-flex-algo-05.txt
Reviewer: Andy Malis
Review Date: Nov. 16, 2020
WG LC End Date: Nov. 23, 2020
Intended Status: Standards Track


I have some minor concerns about this document that I think should be
resolved before publication.

Overall, the draft is straightforward and easy to follow. In particular, I
appreciated the summary of draft-ietf-lsr-flex-algo as a part of the

Once the comments below have been addressed, it should be ready to be
forwarded to the IESG for approval.

Major Issues:

No major issues found.

Minor Issues:

While at least one early implementation has been publicly disclosed, an
early IANA allocation is required for the Flex Algorithm Exclude SRLG TLV
so that early implementations can interoperate.

It would also be helpful for the reader if Section 5 (IANA Considerations)
contained the URL reference to the IANA "BGP-LS Node Descriptor, Link
Descriptor, Prefix Descriptor, and Attribute TLVs" registry at


idnits ran clean except for two out-of-date references.

There are some English language nits with the text, such as "distribute
manner" should be "distributed manner", "This definition provisioned"
should be "This definition is provisioned", "constraint based" should be
"constraint-based", "Flexible Algorithm is called so as it allows" should
be "Flexible Algorithm is so called as it allows", "The operations" should
be "The operation", and so on (and this is just on pages 1-3). I recommend
a language cleanup pass on the draft before forwarding it to the IESG.