Re: [Idr] Éric Vyncke's No Objection on draft-ietf-idr-bgpls-srv6-ext-12: (with COMMENT)

Ketan Talaulikar <ketant.ietf@gmail.com> Sat, 14 January 2023 13:22 UTC

Return-Path: <ketant.ietf@gmail.com>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F284EC1524DA; Sat, 14 Jan 2023 05:22:50 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.095
X-Spam-Level:
X-Spam-Status: No, score=-2.095 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DmIzJyGdvMR6; Sat, 14 Jan 2023 05:22:50 -0800 (PST)
Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 21254C1522CA; Sat, 14 Jan 2023 05:22:50 -0800 (PST)
Received: by mail-ed1-x532.google.com with SMTP id w14so17486950edi.5; Sat, 14 Jan 2023 05:22:50 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=zmOAgFFabsqYtlDaxnfRh1soWbGPFRTt+RtGauPQwAA=; b=kCSOKGkJzGym7Pu/BgJyLbrtl2AwQ/uQIOoCjapL/Tr8xP3ywmJVTBOBWbjULbmDOS efGf12GRo1MQoUftNuJLUKxTjEsLn1wTsr07DyVmdVHJrBwUbcDqdjFbjd7sbO5h9FLF Imc7kIeqi+0QrO8ucboAb3P6tRydr2wgXENJwJbUxSeKKiATciRdYawtac1iX2lHHhz0 ZfpafYE8BQ0FmkFkCgzsmkjEFjFayrDHcUBrqwQjalM84K3RAs1sD8z1Y1mPFqzkgk1k OzyiyxpOAogC8RkgHd5QupTdUO286rDRt+c/22SISJBrKu9AmIHyyGBUkZluSFwUZSna 2q3Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zmOAgFFabsqYtlDaxnfRh1soWbGPFRTt+RtGauPQwAA=; b=EtP0AULPmhBmkySTiAfsWvMfMRyndj0KS0xCW7yysEipFHV+C7XoOmsrTUQqkcNKNH e4GKAiMj7Cq8sEpsKOK5CgZxSZFWCxSK3avkYh0wvXMK+MICfUaPBjGKzZ9pUUp5aD9q gEUhfbBLqQgnuYHhtVI9bu2GYxffrEKftO0YsefvBAT1HwqxIijaVrbQOzGS2wDXojmZ 3n4KFSmhfkQyNdnvJwif4uLugpM0h+q0wx4cNYjGnoXh7Op0kqIKI6kkgVh4g29G42D8 E4HUW+7nejvWj52QP8ESPjmBFfGNaH6TN1bcdKoPGk9j+kKUofEhGUDIIYacrU4JKL9B OMpQ==
X-Gm-Message-State: AFqh2krsOusYcAXqTptsoSV3vsb7d/yxE6ZyBdCNMIx4hDz1vVj6OuZN OzBRKNtXrSAB8BAvM7PvU9tu+5jLIfcZX6KvA8w=
X-Google-Smtp-Source: AMrXdXuBJcyI39vxwhLSdzK7QG6VoqRqVJMOPf+7sGJJqth94GuXSllcHhqIybxh4VP9JyrAjA031GkwfKA5oq0H1uM=
X-Received: by 2002:aa7:de08:0:b0:468:4cd4:f133 with SMTP id h8-20020aa7de08000000b004684cd4f133mr11041187edv.18.1673702567881; Sat, 14 Jan 2023 05:22:47 -0800 (PST)
MIME-Version: 1.0
References: <167109596075.47967.10385839179673983356@ietfa.amsl.com>
In-Reply-To: <167109596075.47967.10385839179673983356@ietfa.amsl.com>
From: Ketan Talaulikar <ketant.ietf@gmail.com>
Date: Sat, 14 Jan 2023 18:52:34 +0530
Message-ID: <CAH6gdPxYWM1Bk2yhjRde565aEh5j68vv=G4GcabPL3jLjXNQ1w@mail.gmail.com>
To: Éric Vyncke <evyncke@cisco.com>
Cc: The IESG <iesg@ietf.org>, draft-ietf-idr-bgpls-srv6-ext@ietf.org, idr-chairs@ietf.org, idr@ietf.org, shares@ndzh.com, aretana.ietf@gmail.com, tim@qacafe.com
Content-Type: multipart/alternative; boundary="00000000000004b23605f2393f2e"
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/Axh3Q-Nf5IpOCLnHSoR9Tlm-bXU>
Subject: Re: [Idr] Éric Vyncke's No Objection on draft-ietf-idr-bgpls-srv6-ext-12: (with COMMENT)
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Jan 2023 13:22:51 -0000

Hi Eric,

Thanks for your review and comments.

Please check inline below for responses.

On Thu, Dec 15, 2022 at 2:49 PM Éric Vyncke via Datatracker <
noreply@ietf.org> wrote:

> Éric Vyncke has entered the following ballot position for
> draft-ietf-idr-bgpls-srv6-ext-12: No Objection
>
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
>
>
> Please refer to
> https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/
> for more information about how to handle DISCUSS and COMMENT positions.
>
>
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-idr-bgpls-srv6-ext/
>
>
>
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
>
> # Éric Vyncke, INT AD, comments for draft-ietf-idr-bgpls-srv6-ext-12
> CC @evyncke
>
> Thank you for the work put into this document.
>
> Please find below some non-blocking COMMENT points (but replies would be
> appreciated even if only for my own education).
>
> Special thanks to Susan Hares for the shepherd's detailed write-up
> including
> the WG consensus *and* the justification of the intended status.
>
> Other thanks to Timothy Winters, the Internet directorate reviewer (at my
> request), please consider this int-dir review:
>
> https://datatracker.ietf.org/doc/review-ietf-idr-bgpls-srv6-ext-12-intdir-telechat-winters-2022-12-07/
>
> I hope that this review helps to improve the document,
>
> Regards,
>
> -éric
>
> ## COMMENTS
>
> ### Section 3.1
>
> I second John's point on the lack of specification for the Flag field. This
> document does not specify how to interpret the values. It happens that the
> IS-IS and OSPFv3 specify a 16-bit value with currently the same semantic
> associated to the 16-bit but I fear that this is quite dangerous to have
> the
> *same* field specified in several documents. Strongly suggest creating a
> IANA
> registry for this 16-bit field shared by (at least) 3 IETF drafts.
>
> The same comment applies to many other values in the document.
>

KT> Thanks to Alvaro and John for clarifying this from the separate
discussion thread that we've had including the authors of the corresponding
IGP specs. Please also look at the most recent update posted and my
responses to John on this.


>
> ### Section 4.2
>
> Suggest to replace the very specific "LAN" to the broader "broadcast link"
> ?
>

KT> We are trying to be consistent here with the IGP specs. More
importantly this is reflecting the IGP behavior/working on LAN - I am not
very sure what other broadcast links we are looking to cover and hence not
sure whether or not this would apply so broadly.


>
> ### Section 5.1
>
> ```
>    As specified in [RFC8986], an SRv6 SID comprises Locator, Function
>    and Argument parts.
> ```
> Does the above text assume that *all* SIDs are network programming SIDs ?
> Suggest to qualify as in "a network programming SRv6 DIS"
>

KT> RFC8986 is not introducing a new type of "network programming" SIDs.
This applies to all SRv6 SID.

Thanks,
Ketan


>
> ## Notes
>
> This review is in the ["IETF Comments" Markdown format][ICMF], You can use
> the
> [`ietf-comments` tool][ICT] to automatically convert this review into
> individual GitHub issues.
>
> [ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md
> [ICT]: https://github.com/mnot/ietf-comments
>
>
>
>