Re: [Idr] Routing Directorate Review for draft-ietf-idr-wide-bgp-communities-07 - BGP Community Container

Robert Raszuk <robert@raszuk.net> Mon, 11 July 2022 14:01 UTC

Return-Path: <robert@raszuk.net>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2D116C16ECF3 for <idr@ietfa.amsl.com>; Mon, 11 Jul 2022 07:01:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.105
X-Spam-Level:
X-Spam-Status: No, score=-2.105 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=raszuk.net
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rAast1yTe-pU for <idr@ietfa.amsl.com>; Mon, 11 Jul 2022 07:01:29 -0700 (PDT)
Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4A824C16ECC3 for <idr@ietf.org>; Mon, 11 Jul 2022 07:01:24 -0700 (PDT)
Received: by mail-lf1-x12c.google.com with SMTP id r9so837997lfp.10 for <idr@ietf.org>; Mon, 11 Jul 2022 07:01:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raszuk.net; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5NerkvtlfRJX4zsw0BOZ4adndrDrnfL7MMYKwbol8k4=; b=G0NpxowkVjhLe2peK0sc41myDXii9ZGPpztSsAfB+sAIdMbU4nsbKu5Elbw27/qSuC wmdQN/377q00urAzpZY7Xd1Zgu48pFegG/ICUWdgORu9pp0l8Qw2ukFbT/jQh0QxufEy IlpCxfg1vcJsBxJlFyoqg8whfgfopKL3JarGWGQfZJt9cn4L/kplyCAPWRxzqA/inDrV 7vOldl+gad0TRXOz74xOujQo4t2OknHI+KYHB+A+P740vUjK3zxPBUachV/ZQ30ZTonj 1ArEViIkVsJp4MPT+ETdELUb4U/h2HuWQC02Cum3GxD8yoI3wY52ZTPYz4mO7XtwJohK Fl8g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5NerkvtlfRJX4zsw0BOZ4adndrDrnfL7MMYKwbol8k4=; b=oHcZ5OsxPWlyqNlQNYd739k6oKD8WHYHKB2mDg7/u6U7xil/SVncHVr9o/QXFF/Bej W4z4RWleaWEuaSAJszS99Mp5Nx4QoBJAEd9RyOWMEyezZadOmUdBoGD6bUgUulLn0Yin nvYZLiuTHnMhPe4vEM54wok4AkRlZzYoxM69CS+HX05AlYVeZgnKYxwzr+MCH5ZI4HKE nIbu1GM4M6NV82reX+G5LEbOa7oVrAfjEb9xfVLzd9ZtEYSldTVjKAcgNUIE+h+zoHyD DoJSZkL7VRmh12EkmWxfFT4uVSDtJac1nIgq6f7XozbmmC0b+haRBQt1eav4z8DAvQMe yvmw==
X-Gm-Message-State: AJIora9Lo9zKROZdQ3VTRwbW9Uiu15wvbxn0BuRJR1GvWj1Wpp8NLQeU bC54JYJ2lOgcCdpiBaXk53tKgXvnZnTvJyqVd9hFLw==
X-Google-Smtp-Source: AGRyM1uEWZ2Q/bqDZ3CKnLwmDymEzfSm8yAMwOLb2wjPjNr+D7Jk+DGuSqXdjFrbK5uN1tWxO6r99emYbH2mXLIydn0=
X-Received: by 2002:a05:6512:e9b:b0:489:e034:cfc9 with SMTP id bi27-20020a0565120e9b00b00489e034cfc9mr2655403lfb.366.1657548082360; Mon, 11 Jul 2022 07:01:22 -0700 (PDT)
MIME-Version: 1.0
References: <31784442-7A03-46E2-B255-7D7FF46FD88F@cisco.com> <20220708195701.GB29763@pfrc.org> <E109F29A-8701-443E-BCFA-14A370E6B736@cisco.com> <CAOj+MMGXCZ674h=XuF0AqV4o0n+-wBVzfpLuihGcQh7VOktaew@mail.gmail.com> <E094DB91-02E5-4C33-82EB-CB3995521589@cisco.com> <CAOj+MMExYuXfPAjkZkgdTFPPfuMNPxFXtO0inUgZKZetCzbU=g@mail.gmail.com> <52B1B5E4-ABF6-40DC-8BD4-875A613B8068@cisco.com>
In-Reply-To: <52B1B5E4-ABF6-40DC-8BD4-875A613B8068@cisco.com>
From: Robert Raszuk <robert@raszuk.net>
Date: Mon, 11 Jul 2022 16:01:11 +0200
Message-ID: <CAOj+MMFpnczHmvdKSQr5bkYsBfaeLhMT+rguMF2Ks1wEV3QLXA@mail.gmail.com>
To: "Acee Lindem (acee)" <acee@cisco.com>
Cc: Jeffrey Haas <jhaas@pfrc.org>, "Acee Lindem (acee)" <acee=40cisco.com@dmarc.ietf.org>, "draft-ietf-idr-wide-bgp-communities@ietf.org" <draft-ietf-idr-wide-bgp-communities@ietf.org>, IDR List <idr@ietf.org>, Routing Directorate <rtg-dir@ietf.org>
Content-Type: multipart/related; boundary="000000000000a5e90605e387fc4b"
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/E6hWhrnoUjXIiOiLfUFafxTPHo8>
Subject: Re: [Idr] Routing Directorate Review for draft-ietf-idr-wide-bgp-communities-07 - BGP Community Container
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jul 2022 14:01:33 -0000

Hi Acee,

> Would it make sense to note that this should be logged (subject to
rate-limiting)?

Good point - yes it should be logged.

But do we always need to spell it out in the protocol extensions
documents ? Isn't this sort of well known default for any decent
implementation ? It is a much wider question.

In other words, IMO good implementations will log it irrespective of
this sentence being present or not. Bad ones will not unless it is enforced
by "MUST".

Btw I am fine with adding this irrespectively.

Many thx,
R.


On Mon, Jul 11, 2022 at 3:51 PM Acee Lindem (acee) <acee@cisco.com> wrote:

> Hi Robert,
>
>
>
> *From: *Robert Raszuk <robert@raszuk.net>
> *Date: *Monday, July 11, 2022 at 9:31 AM
> *To: *Acee Lindem <acee@cisco.com>
> *Cc: *Jeff Haas <jhaas@pfrc.org>, "Acee Lindem (acee)" <acee=
> 40cisco.com@dmarc.ietf.org>, "draft-ietf-idr-wide-bgp-communities@ietf.org"
> <draft-ietf-idr-wide-bgp-communities@ietf.org>, IDR List <idr@ietf.org>,
> Routing Directorate <rtg-dir@ietf.org>
> *Subject: *Re: [Idr] Routing Directorate Review for
> draft-ietf-idr-wide-bgp-communities-07 - BGP Community Container
>
>
>
> Hi Acee,
>
>
>
> Ok I was not really clear on your comment if it applies to entire diff or
> just to the part of "ignoring" elements. Was just trying to show that the
> -08 diff shows lots of changes :)
>
>
>
> Anyhow to your point. First let's observe that use of any BGP Community is
> advisory. We have no mechanism in BGP to force to apply any action on BGP
> speaker when receiving given extended, large or wide community. For
> standard well-knows there is exception that they will be obeyed but this is
> an exception here.
>
>
>
> Good point.
>
>
>
> With that being said as Jeff mentioned semantics if target is to match any
> so if one implementation does not recognize  one atom type yet can
> successfully parse entire community there is no reason why applying partial
> match of ANY form would be worse then not applying it at all. That is in
> context of Sub-Type 1 section 4.4.1
>
>
>
> I agree. I guess this would also be true in the exclude case that it would
> be better to exclude at least the routes for the understood atoms. Would it
> make sense to note that this should be logged (subject to rate-limiting)?
>
>
>
> I am discussing with co-authors if the same applies to 4.4.2 as currently
> written. Especially in the light of section 8.2 which stands in contrast to
> 4.4.2.
>
>
>
> On the topic of ignoring entire community section 4.4.3 provides such
> example - when parameter is not recognized or not being able to be
> correctly parsed.
>
>
>
> I certainly agree if it can’t be parsed and I can accept similar behavior
> if it is unrecognized. My comment was more toward why unrecognized atoms
> didn’t result in ignoring the wide community (as discussed above). I can
> see the distinction of the parameters applying to the community actions and
> not recognizing one would dictate ignoring the community.
>
>
>
> Thanks,
> Acee
>
>
>
>  For treat as withdraw section 8.1 provides a description. In general when
> we can not parse the attribute it should undergo procedures as described in
> RFC7606 section 7.14
>
>
>
> Many thx,
>
> R.
>
>
>
> On Mon, Jul 11, 2022 at 2:17 PM Acee Lindem (acee) <acee@cisco.com> wrote:
>
> Hi Robert, Jeff,
>
>
>
> *From: *Robert Raszuk <robert@raszuk.net>
> *Date: *Monday, July 11, 2022 at 8:09 AM
> *To: *Acee Lindem <acee@cisco.com>
> *Cc: *Jeff Haas <jhaas@pfrc.org>, "Acee Lindem (acee)" <acee=
> 40cisco.com@dmarc.ietf.org>, "draft-ietf-idr-wide-bgp-communities@ietf.org"
> <draft-ietf-idr-wide-bgp-communities@ietf.org>, IDR List <idr@ietf.org>,
> Routing Directorate <rtg-dir@ietf.org>
> *Subject: *Re: [Idr] Routing Directorate Review for
> draft-ietf-idr-wide-bgp-communities-07 - BGP Community Container
>
>
>
> Hi Acee,
>
>
>
>     Otherwise, we can resume comments vs. the published -08 on Monday.
>
> I'm looking at the version just published - I'm missing any changes here
> in the diff?
>
>
>
>
>
>
>
> Can you be more specific ? The diff shows all of those changes made.
>
>
>
> This why I hate when people who prune my Emails beyond comprehension…. I
> mean specifically the changes relative to my comment on undefined atoms vs
> undefined parameters that immediately preceded my response.
>
>
>
>
>     >    2. It wasn't clear to me why undefined Atoms are ignored and the
> BGP Wide Community
>
>     >       is still used. Similarly, undefined parameters result in the
> BGP Wide Community
>
>     >       being ignored. I think the draft should explain impetus for
> the three error actions –
>
>     >       ignore Atom only, ignore  BGP Wide Community, and treat as
> malformed.
>
>
>
>
>
> Thanks,
>
> Acee
>
>
>
> Thx,
>
> R.
>
>
>
>