Re: [Idr] I-D Action: draft-ietf-idr-rtc-hierarchical-rr-04.txt

Alexander Okonnikov <alexander.okonnikov@gmail.com> Tue, 05 March 2024 11:39 UTC

Return-Path: <alexander.okonnikov@gmail.com>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 82614C14F6AA for <idr@ietfa.amsl.com>; Tue, 5 Mar 2024 03:39:17 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.104
X-Spam-Level:
X-Spam-Status: No, score=-7.104 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aU-udAL18zbz for <idr@ietfa.amsl.com>; Tue, 5 Mar 2024 03:39:16 -0800 (PST)
Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5EA93C14F698 for <idr@ietf.org>; Tue, 5 Mar 2024 03:39:16 -0800 (PST)
Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-5135540c40dso512748e87.3 for <idr@ietf.org>; Tue, 05 Mar 2024 03:39:16 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709638754; x=1710243554; darn=ietf.org; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=Rpi99ifsH6bgytmaPs2C/YX7GE5fgY+aum7FipRn5Zs=; b=WPGhDfKAHG9NzKxkcBOU9vopKU/Tv8yPaeT0HvVBIi9CIAsJccmaqJZOo3x1fDxiEz Yn6LmhIqAUDlssL0rDMPsU9Vr+pTlNx+RPAOonDZvt3/gqvG+IjaMd26hkIGjafg3tmv /QGYqInE5G4/TVoARoBccHL68hHWt2ltUSNSyDKfQ/IIC1SVRF5kaFcHwCnZje1IOcz9 N6kBKxS46xzJXbROO6fvKfRxHx5xUby1cCs5jwYdu7RdAYtw5Oe4zSQ5Fbc5ua51a5GS 5bOEjOcAlcblEg202fzaJ2W/QpN83NF10NwUtj02u0hYsf+GqKG+I/evzNPEyWDeuLmQ EZ2Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709638754; x=1710243554; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Rpi99ifsH6bgytmaPs2C/YX7GE5fgY+aum7FipRn5Zs=; b=Iv/YeXl/vU/u6iboIpAVFKBsXXlzk59wjsF5e+iJTmTW1PP66KJQj/y9uGz/6r8scu baVCgN4a1Tahmdbcx43B81lqEghUSPMoVdXpzBTC1FW8T5dSKgOStrLnSd3rv159pceB LYWeYt3ufi6EXKq4pPtzOem/tHPs1wiy+N/HooPENXFhwJZJ3M5jqRbwR47vEniwBnMT JjBf7WCPu71aRNPypHggMb6XPQtMwTHRcnZT7yHySpOddlurEHjyBD9ymkbbufe0HaJz 3s4fOame9ZC0UI/94atlMzeWM0SvrRiGva/mDADvCYVexhkWrxD5EbAwZEbzK04vq6B0 3ICA==
X-Gm-Message-State: AOJu0YzfCTGupyxeEZLD1zreAqAVN4FdlY/eKIMq27TutsDrBEplWttM H0TK5eqnTgt5pUSl7NG5GVQynIH4HSBJujTUbtvu0u4cC8VkyRH+fuoY3ni1
X-Google-Smtp-Source: AGHT+IHai1ttnfviJJ9e6+71XkJI+kQuNbw2nQbFEa55jIFa5lzgJysLLy7redznboJO/MZ/L6hkMQ==
X-Received: by 2002:a05:6512:5c5:b0:513:3bb2:325f with SMTP id o5-20020a05651205c500b005133bb2325fmr878026lfo.24.1709638754242; Tue, 05 Mar 2024 03:39:14 -0800 (PST)
Received: from smtpclient.apple ([94.19.48.224]) by smtp.gmail.com with ESMTPSA id o6-20020ac24bc6000000b0051357109ac6sm148357lfq.285.2024.03.05.03.39.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Mar 2024 03:39:13 -0800 (PST)
From: Alexander Okonnikov <alexander.okonnikov@gmail.com>
Message-Id: <47AC356C-9107-4028-A766-99A5CB7FB452@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_3481AEF5-A662-440F-A730-3D2113A7DDBB"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6.1.1\))
Date: Tue, 05 Mar 2024 14:39:02 +0300
In-Reply-To: <CAOj+MMH3J_XnVAYUcWC7L5G8qmvknoh+PCsL1L9=nnOdCDE_Gg@mail.gmail.com>
Cc: IDR List <idr@ietf.org>
To: Robert Raszuk <robert@raszuk.net>
References: <170954803408.43395.8450424120941872596@ietfa.amsl.com> <60B94E98-3D0E-44CF-8521-96A0F217AFDA@gmail.com> <CAOj+MMH7PrQGaZ__-ZGnEmvkZWT38xuaP+fhraUtJ4C=iK=Thw@mail.gmail.com> <667F1B5D-68AC-410C-B490-5DD020B8D5E0@gmail.com> <CAOj+MMHTmvXqgLmJtkOZcb-ZF-3T7UZpbaaCmys2kw7eEtwS7w@mail.gmail.com> <BDF5AD35-7F4C-4F28-9406-E82BBD52B2C5@gmail.com> <CAOj+MMH3J_XnVAYUcWC7L5G8qmvknoh+PCsL1L9=nnOdCDE_Gg@mail.gmail.com>
X-Mailer: Apple Mail (2.3731.700.6.1.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/KkCG7SBvmj6TreNuwNEuHJcPXoM>
Subject: Re: [Idr] I-D Action: draft-ietf-idr-rtc-hierarchical-rr-04.txt
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Mar 2024 11:39:17 -0000

Regarding taking into account ORIGINATOR_ID in addition to CLUSTER_LIST in draft-ietf-idr-rtc-hierarchical-rr - draft-ietf-idr-best-external takes it into account as well:

"2.  When advertising a route to a Route Reflection client peer, in
       case the overall best path has been received from the same
       cluster, a BGP speaker MUST be able to advertise the best overall
       path to all the members of the cluster other than the originator,
       unless "client-to-client" reflection is disabled.  The
       implementation MAY choose to advertise an alternate path to the
       specific peer that originates the best overall path by excluding
       from consideration all paths with the same originator-id."

What we need here is to use SHOULD vs MAY for routes of RT family. I.e. rule 2 of draft-ietf-idr-best-external replaces rule i) of RFC 4684. Rules 1 and 3 in draft-ietf-idr-best-external replace rule ii) of RFC 4684.

Only comment to the draft-ietf-idr-best-external is that I'm not sure we need separate rules for non-client mesh (1) and 'no client-to-client' client mesh (3). For me the former is just specific case of the latter.


My thoughts are that we need rfc4684-bis. The problem with propagating RT routes in presence of hierarchical RRs is not only problem with RFC 4684. Per my view we have other ones:

* no clear rules for propagating default route target - some implementations handle received default route target in ORF manner and don't propagate such route further; others treat it like regular BGP RT route and may propagate it (according to the Decision process).

- no ECMP considerations - some implementations don't provide multipath for RT routes at all; others allow it, though via special commands rather than applying regular 'multipath' logic like it is done for other families.

BR
Alexander Okonnikov

> 5 марта 2024 г., в 13:41, Robert Raszuk <robert@raszuk.net> написал(а):
> 
> Great. 
> 
> But this does not change the fact that we still do not have any RFC specifying this change to best path selection rules. 
> 
> I guess this would be a good time for WG input on which draft should be progressed assuming original authors of best-external still want to work on their document. 
> 
> Regards,
> R.
> 
> 
> On Tue, Mar 5, 2024 at 11:35 AM Alexander Okonnikov <alexander.okonnikov@gmail.com <mailto:alexander.okonnikov@gmail.com>> wrote:
>> Hi Robert,
>> 
>> Actually, I successfully performed PoC few years ago using this solution ('best external') for exact problem your draft describes. Implementation was JunOS.
>> 
>> BR
>> Alexander Okonnikov
>> 
>>> 5 марта 2024 г., в 13:32, Robert Raszuk <robert@raszuk.net <mailto:robert@raszuk.net>> написал(а):
>>> 
>>> Hi Alex,
>>> 
>>> I am not actually aware of implementations supporting best external on IBGP per this paragraph: 
>>> 
>>> Quote from https://datatracker.ietf.org/doc/html/draft-ietf-idr-best-external
>>> 
>>> When selecting the path to add to the Adj-RIB-OUT, this document specifies that the path that originate from the same mesh MAY be excluded from consideration.  This results in an Adj-RIB-OUT selection per mesh (the set of non-client peers or a specific cluster).
>>> 
>>> But you are right that this will/would address the issue. In fact our draft is pretty much proposing the very same as the second option: 
>>> 
>>> Quote from https://datatracker.ietf.org/doc/html/draft-ietf-idr-rtc-hierarchical-rr
>>> 
>>> When advertising an RT membership NLRI to a route-reflector peer (either client or non-client), if the best path as selected by the path selection procedure described in Section 9.1 of [RFC4271] is the path received from this peer, and there are alternative paths received from other peers, then the most disjoint alternative route SHOULD be advertised to this peer. The most disjoint alternative path is the path whose CLUSTER_LIST and ORIGINATOR_ID attributes are diverse from the attributes of the best path.
>>> 
>>> Except we specify this further and include not only different mesh criteria but also ORIGINATOR_ID difference when selecting a different path. 
>>> 
>>> Many thx,
>>> Robert
>>> 
>>> 
>>> On Tue, Mar 5, 2024 at 11:09 AM Alexander Okonnikov <alexander.okonnikov@gmail.com <mailto:alexander.okonnikov@gmail.com>> wrote:
>>>> Hi Robert,
>>>> 
>>>> Yes, initially 'best external' addressed eBGP, but later it was generalized for RR clusters as well.
>>>> 
>>>> BR
>>>> Alexander Okonnikov
>>>> 
>>>>> 5 марта 2024 г., в 12:53, Robert Raszuk <robert@raszuk.net <mailto:robert@raszuk.net>> написал(а):
>>>>> 
>>>>> Alex,
>>>>> 
>>>>> The draft applies to reflected IBGP routes. 
>>>>> 
>>>>> Best external draft you are quoting - which is extremely useful and deployed proposal - is applicable to ASBRs/PEs learning BGP routes over EBGP.
>>>>> 
>>>>> Thx,
>>>>> R.
>>>>> 
>>>>> 
>>>>> 
>>>>> On Tue, Mar 5, 2024 at 10:45 AM Alexander Okonnikov <alexander.okonnikov@gmail.com <mailto:alexander.okonnikov@gmail.com>> wrote:
>>>>>> Hi authors,
>>>>>> 
>>>>>> We have already more generic alternative for the second solution - 'Best external route' described in https://datatracker.ietf.org/doc/html/draft-ietf-idr-best-external-05. What about choosing one of two solutions - I lean towards 'best external' based solution. It seems lightweight and doesn't require Add-paths support.
>>>>>> 
>>>>>> Thanks.
>>>>>> 
>>>>>> BR
>>>>>> Alexander Okonnikov
>>>>>> 
>>>>>>> 4 марта 2024 г., в 13:27, internet-drafts@ietf.org <mailto:internet-drafts@ietf.org> написал(а):
>>>>>>> 
>>>>>>> Internet-Draft draft-ietf-idr-rtc-hierarchical-rr-04.txt is now available. It
>>>>>>> is a work item of the Inter-Domain Routing (IDR) WG of the IETF.
>>>>>>> 
>>>>>>>   Title:   Extensions to RT-Constrain in Hierarchical Route Reflection Scenarios
>>>>>>>   Authors: Jie Dong
>>>>>>>            Mach(Guoyi) Chen
>>>>>>>            Robert Raszuk
>>>>>>>   Name:    draft-ietf-idr-rtc-hierarchical-rr-04.txt
>>>>>>>   Pages:   6
>>>>>>>   Dates:   2024-03-04
>>>>>>> 
>>>>>>> Abstract:
>>>>>>> 
>>>>>>>   The Route Target (RT) Constrain mechanism specified in RFC 4684 is
>>>>>>>   used to build a route distribution graph in order to restrict the
>>>>>>>   propagation of Virtual Private Network (VPN) routes.  In network
>>>>>>>   scenarios where hierarchical route reflection (RR) is used, the
>>>>>>>   existing RT-Constrain mechanism cannot guarantee a correct route
>>>>>>>   distribution graph.  This document describes the problem scenario and
>>>>>>>   proposes a solution to address the RT-Constrain issue in hierarchical
>>>>>>>   RR scenarios.
>>>>>>> 
>>>>>>> The IETF datatracker status page for this Internet-Draft is:
>>>>>>> https://datatracker.ietf.org/doc/draft-ietf-idr-rtc-hierarchical-rr/
>>>>>>> 
>>>>>>> There is also an HTMLized version available at:
>>>>>>> https://datatracker.ietf.org/doc/html/draft-ietf-idr-rtc-hierarchical-rr-04
>>>>>>> 
>>>>>>> A diff from the previous version is available at:
>>>>>>> https://author-tools.ietf.org/iddiff?url2=draft-ietf-idr-rtc-hierarchical-rr-04
>>>>>>> 
>>>>>>> Internet-Drafts are also available by rsync at:
>>>>>>> rsync.ietf.org::internet-drafts
>>>>>>> 
>>>>>>> 
>>>>>>> _______________________________________________
>>>>>>> Idr mailing list
>>>>>>> Idr@ietf.org <mailto:Idr@ietf.org>
>>>>>>> https://www.ietf.org/mailman/listinfo/idr
>>>>>> 
>>>>>> _______________________________________________
>>>>>> Idr mailing list
>>>>>> Idr@ietf.org <mailto:Idr@ietf.org>
>>>>>> https://www.ietf.org/mailman/listinfo/idr
>>>> 
>>