[Idr] Shepherd's review - Pre-WGLC for draft-ietf-idr-bgp-sr-policy-ifit-06

[Susan Hares <[e-mail]>]

Draft-ietf-idr-bgp-sr-policy-ift is the next draft in the WG LC list.

This draft needs to resolve the technical and editorial issues list in this shepherd report before WG LC.
The authors also need to place an implementation report at:

an implementation report before WG LC.
https://wiki.ietf.org/group/idr/implementations/draft-ietf-idr-sr-policy-ifit


Technical:
1.  section 3
How is draft-ietf-ippm-ioam-ipv6-options and
a normative reference for this BGP feature?

2.  section 4 needs to be rewritten after
Draft-ietf-idr-segment-routing-te-policy is
Split into two different documents.

3. Section 5 - Consider whether the method of
Stopping IFIT has any potential for error.
IFIT stopping based on empty IFIT subtlv seems
lack a positive ack of the stopping.
For such an intensive use of the network facilities,
It would seem a positive ack is useful.

Text:

   The process of stopping IFIT methods can be done by setting empty

   IFIT Attributes Sub-TLV, while, for modifying IFIT methods

   parameters, the IFIT Attributes Sub-TLVs can be updated accordingly./


4.  Section 5.1
Please give a reference on what happens if the length is incorrect

Text:/

  Length: 6, it is the total length of the value field (not including

   Type and Length fields)./

Are there invalid values of the fields Namespace ID, IOAM Trace Type, or Flags?
If so, what happens if the invalid values are set in fields
are set in the fields: Namespace ID, IOAM Trace Type, and  Flags.

5. Section 5.2

Same questions as for section 5.1

6. Section 5.3
Please give a reference on what happens if the length is incorrect.

Text:/

  Length: 12, it is the total length of the value field (not including

   Type and Length fields)./


Are there invalid values of the fields Namespace ID, IOAM Trace Type,
Flags or flow ID?  If so, what happens if the invalid values are set in fields
are set in the fields: Namespace ID, IOAM Trace Type, Flags and Flow ID?


7. Section 5.4
Text:/   Length: 4, it is the total length of the value field (not including

   Type and Length fields)./



What happens if the length is not 4.


Are there invalid values of the fields Namespace ID or IOAM E2E Type?
 so, what happens if the invalid values are set in fields
are set in the fields: Namespace ID or IOAM E2E Type?



8. Section 5.



What happens if the length is not "4".
Are there invalid values of the fields FlowMonID or Period?
If so, what happens if the invalid values are set in fields
are set in the fields FlowMonID or Period?



Old:/

   H: A flag indicating that the measurement is Hop-By-Hop.



   E: A flag indicating that the measurement is end to end.

/

New: /

   H: A flag when set indicates that the measurement is Hop-By-Hop.



   E: A flag when set indicates that the measurement is end to end.

/



9. Section 6 must be rewritten after

Draft-ietf-idr-segment-routing-te-policy is split.



Please note that you must indicate in the section 5, 5.1,

5.2, 5.3, 5.4, and 5.5 what causes a malformed packet.

Please point forward in the main section of 5 toward the

Error handling in section 6.

==============

Editorial only:

Section 1, paragraph 2:

Old;/packet loss).In
   particular, IFIT refers to network OAM (Operations, Administration/
New: / packet loss). In
   particular, IFIT refers to network OAM (Operations, Administration/

Section 1, paragraph 3
Why: English textual flow.

Old:/

   An automatic network requires the Service Level Agreement (SLA)

   monitoring on the deployed service.  So that the system can quickly

   detect the SLA violation or the performance degradation, hence to

   change the service deployment.  For this reason, the SR policy native

   IFIT can facilitate the closed loop control and enable the automation

   of SR service./



New:/ Many networks require monitoring of traffic flows to match

Service Level Agreements (SLA) on the deployed service.  Network

Management systems need to quickly detect SLA violations or

performance degradation in order to adjust performance.
The SR policy functions for IFIT can enable automation of the
SR service. /


Section 1, paragraph 4 and 5


Old:/

   This document defines extensions to Border Gateway Protocol (BGP) to

   distribute SR policies carrying IFIT information.  So that IFIT

   behavior can be enabled automatically when the SR policy is applied.



   This BGP extension allows to signal the IFIT capabilities together

   with the SR-policy.  In this way IFIT methods are automatically

   activated and running.  The flexibility and dynamicity of the IFIT

   applications are given by the use of additional functions on the

   controller and on the network nodes, but this is out of scope here.

/



New: /

This document defines extensions to the Border Gateway Protocol (BGP)

to distribute SR policies that include IFIT information.



The use specific functions of IFIT applications that utilize this

IFIT information are out of scope for  this document./



Section 5:



Old:/ Anyway the validation of the individual fields of the IFIT

   Attributes sub-TLVs are handled by the SRPM (SR Policy Module)./

New:/ Rhe validation of the individual fields of the IFIT

   Attributes sub-TLVs are handled by the SRPM (SR Policy Module)./







Section 8:



Old:/ Anyway incorrect IFIT

   parameters in the BGP extension SHOULD NOT have an adverse effect on

   the SR Policy as well as on the network, since it affects only the

   operation of the telemetry methodology./



New:/Any incorrect IFIT

   parameters in the BGP extension SHOULD NOT have an adverse effect on

   the SR Policy as well as on the network, since it affects only the

   operation of the telemetry methodology./



Section 9:

Old:/ Anyway incorrect IFIT

   parameters in the BGP extension SHOULD NOT have an adverse effect on

   the SR Policy as well as on the network, since it affects only the

   operation of the telemetry methodology./



New:/ Any incorrect IFIT

   parameters in the BGP extension SHOULD NOT have an adverse effect on

   the SR Policy as well as on the network, since it affects only the

   operation of the telemetry methodology./