Re: [Idr] Poll on the RFC5575bis implementations about the suggested changes during IETF review

Jeffrey Haas <jhaas@pfrc.org> Thu, 30 April 2020 02:41 UTC

Return-Path: <jhaas@slice.pfrc.org>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 56B543A0DD5; Wed, 29 Apr 2020 19:41:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 12qdqxV0BR_4; Wed, 29 Apr 2020 19:41:12 -0700 (PDT)
Received: from slice.pfrc.org (slice.pfrc.org [67.207.130.108]) by ietfa.amsl.com (Postfix) with ESMTP id 7C9C53A0DCA; Wed, 29 Apr 2020 19:41:12 -0700 (PDT)
Received: by slice.pfrc.org (Postfix, from userid 1001) id C254C1E2D6; Wed, 29 Apr 2020 22:48:17 -0400 (EDT)
Date: Wed, 29 Apr 2020 22:48:17 -0400
From: Jeffrey Haas <jhaas@pfrc.org>
To: "Dongjie (Jimmy)" <jie.dong@huawei.com>
Cc: "Kirill.Kasavchenko@netscout.com" <Kirill.Kasavchenko@netscout.com>, "thomas.mangin@exa.net.uk" <thomas.mangin@exa.net.uk>, "jhaas@juniper.net" <jhaas@juniper.net>, "bduvivie@cisco.com" <bduvivie@cisco.com>, IDR List <idr@ietf.org>, "idr-chairs@ietf.org" <idr-chairs@ietf.org>
Message-ID: <20200430024817.GE28692@pfrc.org>
References: <14293c9f9c2e41219a13f09adacb6289@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <14293c9f9c2e41219a13f09adacb6289@huawei.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/fVSKzCCXnXwU1XYGbhVPqfBK450>
Subject: Re: [Idr] Poll on the RFC5575bis implementations about the suggested changes during IETF review
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Apr 2020 02:41:15 -0000

Jie,

On Wed, Apr 29, 2020 at 02:52:30AM +0000, Dongjie (Jimmy) wrote:
> Hi all,
> 
> As you may have noticed, during the IETF review of draft-ietf-idr-rfc5575bis, there was some discussion about the description of bit/flag settings in this draft.
> 
> Based on the discussion in IESG, our AD Alvaro suggested to make following changes to the draft:
> 
> (1) A bit is defined as 0, but the definition is: "0 -  SHOULD be set to 0…” (§4.2.1.1).  If it’s 0, then I see no reason for that not to be a MUST.  In fact, if always set to 0 we’re probably over specifying the field.   There are 3 occurrences of this in the document.
> 
> (2) Unused (§7.3) or reserved (§7.5) defined as "SHOULD be set to 0...MUST be ignored”.  Again, if unused/reserved, I see no reason not to change to MUST.  I think Rob makes a good point about extensibility.
> 
> In summary, it is suggested that in the bit/flag descriptions, “SHOULD be set to 0…”  is replaced with “MUST be set to 0…”.

The pattern we normally want to see is "MUST be set to zero and SHOULD be
ignored on receipt".

By requiring it to be set, you have expectations for a compliant
implementation of a given draft.

By ignoring it on receipt, you permit the field to be used for something
further in the future.

The above is consistent with Postel's Maxim.

With regard to Juniper's implementation:
- In sections 4.2.1.1 and 4.2.1.2 for operators, we originate zeroes when
  generating new NLRI in the reserved bits and we ignore them on receipt.
  However, we also propagate what we are sent and use when we're not the
  originator of that NLRI.
- In section 7.3 (traffic action), we similarly originate only the two bits
  in question and zero the rest of the fields if we set the community, but
  otherwise ignore the rest of the bits on receipt.
- In section 7.5 (DSCP), we originate zero and ignore the top order bit and
  any other bits that should be zero.

However, there are related things you're not asking:
- If we receive two NLRI that are otherwise functionally equivalent but have
  the must-be-zero bits set differently, they are different NLRI per the
  memcmp rule.
- The BGP extended communities suffer the common curse of all "magic"
  communities: More than one such extended community is present, we will
  pick the "first" one for use, where first is the internal lexicographical ordering
  of the collection of extended communities (again, roughly memcmp order).  We
  will also propagate all such received communities.  

-- Jeff