Re: [Idr] AD Review of draft-ietf-idr-bgp-prefix-sid-20

"Acee Lindem (acee)" <acee@cisco.com> Tue, 29 May 2018 20:55 UTC

Return-Path: <acee@cisco.com>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C627612EC4B; Tue, 29 May 2018 13:55:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.509
X-Spam-Level:
X-Spam-Status: No, score=-14.509 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rbnJPoXpoU4D; Tue, 29 May 2018 13:55:51 -0700 (PDT)
Received: from alln-iport-4.cisco.com (alln-iport-4.cisco.com [173.37.142.91]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 30D6A12FA91; Tue, 29 May 2018 13:55:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=15624; q=dns/txt; s=iport; t=1527627351; x=1528836951; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=5xjV/59JOmbR0XKRZMn4cDuR6RyUze1wvD4tjKF1CkI=; b=EucoId/Hfsut8r25aWaMCIvq2iaQ6+fAvdbJxCZbsngLOCOljR9CUAWy Q05EC8AUENG5hH1/f6JIt1jOtMfTlHuo1pAzwfVwkNVn8DzUjyXMNW/46 +oGHhn+k75h8z2l2POzCJpFD+hKrmiVgU/It6g4zluYkP+HebYv1R7dbi E=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0BVAgBSvQ1b/5RdJa1cGQEBAQEBAQEBAQEBAQcBAQEBAYJOdmJ/KAqDbZRxgXmBD4cGhz6FC4FkC4RsAheCACE4FAECAQEBAQEBAmwohSgBAQEEI1YQAgEIDgMDAQIrAgICHxEdCAIEAQ0FgyICgRtMAxWlVoIchwcNgSyBaIg2ghOBDySCaYJPgWxYgmCCVAKIL4hyhxUsCQKLXYMBgTuDb4dcijaGLgIREwGBJDQhgVJwFTsqAYIYCYIXF44Xb45rgRkBAQ
X-IronPort-AV: E=Sophos;i="5.49,457,1520899200"; d="scan'208,217";a="121838188"
Received: from rcdn-core-12.cisco.com ([173.37.93.148]) by alln-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 May 2018 20:55:50 +0000
Received: from XCH-RTP-015.cisco.com (xch-rtp-015.cisco.com [64.101.220.155]) by rcdn-core-12.cisco.com (8.14.5/8.14.5) with ESMTP id w4TKtofr013610 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 29 May 2018 20:55:50 GMT
Received: from xch-rtp-015.cisco.com (64.101.220.155) by XCH-RTP-015.cisco.com (64.101.220.155) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Tue, 29 May 2018 16:55:49 -0400
Received: from xch-rtp-015.cisco.com ([64.101.220.155]) by XCH-RTP-015.cisco.com ([64.101.220.155]) with mapi id 15.00.1320.000; Tue, 29 May 2018 16:55:49 -0400
From: "Acee Lindem (acee)" <acee@cisco.com>
To: Alvaro Retana <aretana.ietf@gmail.com>, "draft-ietf-idr-bgp-prefix-sid@ietf.org" <draft-ietf-idr-bgp-prefix-sid@ietf.org>
CC: "idr@ietf. org" <idr@ietf.org>, "idr-chairs@ietf.org" <idr-chairs@ietf.org>, John Scudder <jgs@juniper.net>
Thread-Topic: AD Review of draft-ietf-idr-bgp-prefix-sid-20
Thread-Index: AQHT94qLoUwhV+NmFESn7PGpr0/OOqRHL8OA
Date: Tue, 29 May 2018 20:55:49 +0000
Message-ID: <9F0A965E-6A9A-472D-8E59-625163853099@cisco.com>
References: <CAMMESswH3mEDApDezPWosth-6SO72x+k7qtUgqu9OTC9DeJ4yg@mail.gmail.com>
In-Reply-To: <CAMMESswH3mEDApDezPWosth-6SO72x+k7qtUgqu9OTC9DeJ4yg@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.116.152.196]
Content-Type: multipart/alternative; boundary="_000_9F0A965E6A9A472D8E59625163853099ciscocom_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/tCNyEiKZCs6CXQpABQ2Nh16TmXU>
Subject: Re: [Idr] AD Review of draft-ietf-idr-bgp-prefix-sid-20
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 29 May 2018 20:56:04 -0000

Hi Alvaro,
I agree with your comments and have published the -21 version with only these changes.
Thanks,
Acee

From: Alvaro Retana <aretana.ietf@gmail.com>
Date: Tuesday, May 29, 2018 at 4:20 PM
To: "draft-ietf-idr-bgp-prefix-sid@ietf.org" <draft-ietf-idr-bgp-prefix-sid@ietf.org>
Cc: IDR List <idr@ietf.org>, "idr-chairs@ietf.org" <idr-chairs@ietf.org>, John Scudder <jgs@juniper.net>
Subject: AD Review of draft-ietf-idr-bgp-prefix-sid-20
Resent-From: <alias-bounces@ietf.org>
Resent-To: Stefano Previdi <stefano@previdi.net>, <cf@cisco.com>, Acee Lindem <acee@cisco.com>, Arjun Sreekantiah <arjunhrs@gmail.com>, <hannes@rtbrick.com>
Resent-Date: Tuesday, May 29, 2018 at 4:20 PM

Dear authors:

Thanks for working on the revision of this document!

I just have a couple of minor comments (please see below).  I am starting the IETF Last Call.

Thanks!

Alvaro.


(1) Move the reference:
s/
   [I-D.ietf-spring-segment-routing] also describes how segment routing
   can be applied to an IPv6 dataplane
   [I-D.ietf-6man-segment-routing-header] (SRv6) using a new IPv6
   routing header containing a stack of SR SIDs encoded as IPv6
   addresses./
   [I-D.ietf-spring-segment-routing] also describes how segment routing
   can be applied to an IPv6 dataplane
   (SRv6) using a new IPv6
   routing header containing a stack of SR SIDs encoded as IPv6
   addresses [I-D.ietf-6man-segment-routing-header].


(2) The IANA-MPLS-SPECIAL-LABEL is not where the NULL labels are defined -- I think a better reference would be rfc3032.


(3) s/Ah SR domain/An SR domain