Gen-ART LC/Telechat review of draft-ietf-pals-ms-pw-protection-03

"Peter Yee" <peter@akayla.com> Fri, 16 October 2015 02:07 UTC

Return-Path: <peter@akayla.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 434391B2A47; Thu, 15 Oct 2015 19:07:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cnkFec2zyJDZ; Thu, 15 Oct 2015 19:07:39 -0700 (PDT)
Received: from p3plsmtpa08-10.prod.phx3.secureserver.net (p3plsmtpa08-10.prod.phx3.secureserver.net [173.201.193.111]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B31811B2A4B; Thu, 15 Oct 2015 19:07:39 -0700 (PDT)
Received: from spectre ([173.8.184.78]) by p3plsmtpa08-10.prod.phx3.secureserver.net with id Ve7d1r0031huGat01e7dzN; Thu, 15 Oct 2015 19:07:37 -0700
From: Peter Yee <peter@akayla.com>
To: draft-ietf-pals-ms-pw-protection.all@ietf.org
Subject: Gen-ART LC/Telechat review of draft-ietf-pals-ms-pw-protection-03
Date: Thu, 15 Oct 2015 19:07:36 -0700
Message-ID: <00f301d107b7$6db17110$49145330$@akayla.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AdEHtMzOJ/UwFD5/SsuEbOoyCxUZ7g==
Content-Language: en-us
Archived-At: <http://mailarchive.ietf.org/arch/msg/ietf/6AKiTjooVVWTe88trBamMZ4e5uw>
Cc: gen-art@ietf.org, ietf@ietf.org
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Oct 2015 02:07:41 -0000

I am the assigned Gen-ART reviewer for this draft. The General Area Review
Team (Gen-ART) reviews all IETF documents being processed by the IESG for
the IETF Chair. Please wait for direction from your document shepherd or AD
before posting a new version of the draft.

For more information, please see the FAQ at
<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-ietf-pals-ms-pw-protection-03
Reviewer: Peter Yee
Review Date: Oct-15-2015
IETF LC End Date: Oct-15-2015
IESG Telechat date: Oct-22-2015

Summary: This draft is basically ready for publication as a Standards Track
RFC, but has nits (and a question) that should be fixed before publication.
[Ready with nits]

The draft provides two mechanisms that can be used to provide protection to
static Multi-Segment Pseudowires against failure of switching Provider Edge
nodes.  I'm not familiar enough with the topic to determine if the mechanism
works as easily as described in the draft, but the concept helpfully does
not require invention of new protocols, so a determination of suitability
shouldn't be difficult for MPLS experts to make.

Question: Wouldn't it make sense to provide some explanation in Appendix A
for why it exists and when it should be used?  Currently it's just offered
as an alternate approach without real guidance.

Major issues: None

Minor issues: None

Nits:

General:

Expand all acronyms on initial use.  Some of them are probably well-known in
the MPLS community, but their expansion wouldn't hurt either.

Specific:

Page 4, 1st paragraph, 1st sentence: replace "MS PW" with "MS-PW" to match
other usage in the document.

Page 4,  2nd paragraph, 2nd sentence: append commas after "which" and "PWs".

Page 4, 3rd paragraph, 1st sentence: replace the comma with a semicolon.

Page 8, Section A.2, 1st paragraph, 1st sentence: append a comma after
"link".

Page 8, Section A.2, 2nd paragraph, 1st sentence: append "entity" at the end
of the sentence.  As it is, the sentence ends ambiguously in an adjective.

Page 8, Section A.2, 3rd paragraph, 1st sentence: change "a SS-PW" to "an
SS-PW".