Re: Last Call: <draft-ietf-dcrup-dkim-crypto-09.txt> (A new cryptographic signature method for DKIM) to Proposed Standard

Russ Housley <housley@vigilsec.com> Wed, 30 May 2018 20:26 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CCB6912EA7F for <ietf@ietfa.amsl.com>; Wed, 30 May 2018 13:26:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sl23Okf4YkuG for <ietf@ietfa.amsl.com>; Wed, 30 May 2018 13:26:15 -0700 (PDT)
Received: from mail.smeinc.net (mail.smeinc.net [209.135.209.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BE94412E6D7 for <ietf@ietf.org>; Wed, 30 May 2018 13:26:15 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mail.smeinc.net (Postfix) with ESMTP id B480D300681 for <ietf@ietf.org>; Wed, 30 May 2018 16:26:13 -0400 (EDT)
X-Virus-Scanned: amavisd-new at mail.smeinc.net
Received: from mail.smeinc.net ([127.0.0.1]) by localhost (mail.smeinc.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id op_VBbsRdn1X for <ietf@ietf.org>; Wed, 30 May 2018 16:26:12 -0400 (EDT)
Received: from a860b60074bd.home (pool-108-45-101-150.washdc.fios.verizon.net [108.45.101.150]) by mail.smeinc.net (Postfix) with ESMTPSA id 8DC4D300261; Wed, 30 May 2018 16:26:12 -0400 (EDT)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: Last Call: <draft-ietf-dcrup-dkim-crypto-09.txt> (A new cryptographic signature method for DKIM) to Proposed Standard
From: Russ Housley <housley@vigilsec.com>
In-Reply-To: <152759906865.25595.11709363913593626988.idtracker@ietfa.amsl.com>
Date: Wed, 30 May 2018 16:26:13 -0400
Cc: dcrup@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <D4920629-1B2C-4123-A2FC-209A4986C8C4@vigilsec.com>
References: <152759906865.25595.11709363913593626988.idtracker@ietfa.amsl.com>
To: IETF <ietf@ietf.org>
X-Mailer: Apple Mail (2.3273)
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf/8qAqWn1rd2NZopsdYahhub9ZCOw>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 30 May 2018 20:26:19 -0000

I have three comments on draft-ietf-dcrup-dkim-crypto-09.

In section 3, this document says that it uses "PureEDdSA"; however, RFC 8032 provide a definition for PureEdDSA.  I assume this is a simple typo.

How hard would it be to expand section 6 to include an example of two selectors being used, one with RSA and one with ed25519?  If it is pretty easy, I think it would help the reader.

RFC 6376 have an extensive security considerations section.  This document should point out that the private key protection discussed in Section 8.3 of RFC 6376 applies to the ed25519 private key.  In addition, I think there should be a section similar to Section 8.13 of RFC 6376 in this document; it might just be a pointer to Section 8 of RFC 8032.

Russ


> On May 29, 2018, at 9:04 AM, The IESG <iesg-secretary@ietf.org> wrote:
> 
> 
> The IESG has received a request from the DKIM Crypto Update WG (dcrup) to
> consider the following document: - 'A new cryptographic signature method for
> DKIM'
>  <draft-ietf-dcrup-dkim-crypto-09.txt> as Proposed Standard
> 
> The IESG plans to make a decision in the next few weeks, and solicits final
> comments on this action. Please send substantive comments to the
> ietf@ietf.org mailing lists by 2018-06-12. Exceptionally, comments may be
> sent to iesg@ietf.org instead. In either case, please retain the beginning of
> the Subject line to allow automated sorting.
> 
> Abstract
> 
> 
>   This document adds a new signing algorithm to DKIM.
> 
> 
> 
> 
> The file can be obtained via
> https://datatracker.ietf.org/doc/draft-ietf-dcrup-dkim-crypto/
> 
> IESG discussion can be tracked via
> https://datatracker.ietf.org/doc/draft-ietf-dcrup-dkim-crypto/ballot/
> 
> The following IPR Declarations may be related to this I-D:
> 
>   https://datatracker.ietf.org/ipr/3025/
> 
> 
> 
> 
>