Re: Gen-ART LC review of draft-ietf-idr-bgp-enhanced-route-refresh-06

"Keyur Patel (keyupate)" <keyupate@cisco.com> Fri, 06 June 2014 19:54 UTC

Return-Path: <keyupate@cisco.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 893C01A00FC; Fri, 6 Jun 2014 12:54:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -15.152
X-Spam-Level:
X-Spam-Status: No, score=-15.152 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RP_MATCHES_RCVD=-0.651, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fmr65Q05R04P; Fri, 6 Jun 2014 12:54:49 -0700 (PDT)
Received: from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 05E4F1A024D; Fri, 6 Jun 2014 12:54:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2777; q=dns/txt; s=iport; t=1402084482; x=1403294082; h=from:to:cc:subject:date:message-id:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=Hnpo9X3GMWUatXOLextq917u+1nqumJ7C2hu7B7OCj8=; b=ljFA/QBn20K4WpgnhhkBumDvJmyxGdEk87/1OA9wd/BO17eTL3o/GCQD HRSQw5XZ46oaCmqQSv/1FxPdh2KBNIh3gSg4/Bl0XjKwqK9fTGY4CfKj2 r3y9MO+D8WZvmcWx9poeAOKLY2FY0LtAg8M3ni/OHCVgxYxn4LFDTpF8I M=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AvZbACEcklOtJA2G/2dsb2JhbABZgw1SWapxBm+YIQGBBxZ1hAo6PxIBCBQiQiUCBAENBYhCDc1OF4VdhxCBfAeEQQEDmh2BQpICgzxsgUM
X-IronPort-AV: E=Sophos;i="4.98,991,1392163200"; d="scan'208";a="331269309"
Received: from alln-core-12.cisco.com ([173.36.13.134]) by rcdn-iport-4.cisco.com with ESMTP; 06 Jun 2014 19:54:42 +0000
Received: from xhc-aln-x10.cisco.com (xhc-aln-x10.cisco.com [173.36.12.84]) by alln-core-12.cisco.com (8.14.5/8.14.5) with ESMTP id s56JsfrH006384 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Fri, 6 Jun 2014 19:54:41 GMT
Received: from xmb-aln-x09.cisco.com ([169.254.4.72]) by xhc-aln-x10.cisco.com ([173.36.12.84]) with mapi id 14.03.0123.003; Fri, 6 Jun 2014 14:54:41 -0500
From: "Keyur Patel (keyupate)" <keyupate@cisco.com>
To: Peter Yee <peter@akayla.com>, "draft-ietf-idr-bgp-enhanced-route-refresh.all@tools.ietf.org" <draft-ietf-idr-bgp-enhanced-route-refresh.all@tools.ietf.org>
Subject: Re: Gen-ART LC review of draft-ietf-idr-bgp-enhanced-route-refresh-06
Thread-Topic: Gen-ART LC review of draft-ietf-idr-bgp-enhanced-route-refresh-06
Thread-Index: AQHPgcEn6/H8S8nfwU6yLqGHmoWlNw==
Date: Fri, 06 Jun 2014 19:54:40 +0000
Message-ID: <CFB76C32.752A3%keyupate@cisco.com>
In-Reply-To: <00e101cf80ed$4a0e9d70$de2bd850$@akayla.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/14.13.0.110805
x-originating-ip: [128.107.163.125]
Content-Type: text/plain; charset="us-ascii"
Content-ID: <FE30BCA54FA66343824D5BBDFD47458B@emea.cisco.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: http://mailarchive.ietf.org/arch/msg/ietf/F787_BdRNHGQLD-nsZoY0lbbqKw
Cc: "gen-art@ietf.org" <gen-art@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Jun 2014 19:54:50 -0000

Hi Peter,

Thank you for the draft review. I have fixed the nits in the draft.

More comments inlined. #Keyur

On 6/5/14 11:38 AM, "Peter Yee" <peter@akayla.com> wrote:

>I am the assigned Gen-ART reviewer for this draft. For background on
>Gen-ART, please see the FAQ at
><http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>
>
>Please resolve these comments along with any other Last Call comments you
>may receive.
>
>Document: draft-ietf-idr-bgp-enhanced-route-refresh-06
>Reviewer: Peter Yee
>Review Date: June-04-2014
>IETF LC End Date: June-03-2014
>IESG Telechat date: June-12-2014
>
>This review is a couple of days late owing to my being unavailable during
>most of the review period.
>
>Summary: This draft is basically ready for publication as a Standards
>Track
>RFC, but has some nits that should be fixed before publication. [Ready
>with
>nits.]
>
>No major complaints with this draft -- just a few consistency nits and a
>couple of questions.
>
>Questions:
>
>Page 3, Section 3.2: the set of available values is enumerated.  Is the
>encoding format of these values understood from other context?  Older BGP
>specifications seem to give guidance such as "unsigned integer" at a
>minimum.

#Keyur: Yes.

>
>Page 3, Section 3.2, table of values: the value is a "should" in RFC 2918.
>That RFC indicated that it was to be ignored by recipients.  Now that
>values
>will actually matter, is there any concern about senders that don't abide
>by
>the "should" clause in RFC 2918?

#Keyur: Yes. This functionality is controlled using BGP capabilities.

>
>Page 4, 1st full paragraph, 3rd sentence: the behavior for receipt of a
>BoRR
>is described.  What happens if an EoRR is somehow received prior to
>receipt
>of a BoRR?  Is it just ignored?  Or should an error notification be
>returned?

#Keyur: It would be a no-op operation. 07 version of draft covers it.

Best Regards,
Keyur

>
>Nits:
>
>Page 3, Section 4, 4th paragraph, 2nd sentence: change "comprise of both,
>the" to "comprise both the".
>
>Page 4, 1st partial paragraph: change "ADJ-RIB-Out" to "Adj-RIB-Out" for
>consistency.
>
>Page 4, 1st full paragraph, 3rd sentence: change "anytime" to "any time".
>
>Page 4, 3rd paragraph, 2nd sentence: use upper/lower case consistently for
>the term 'EoR'.  RFC 4724 does not give specific guidance, but the spelled
>out form would tend to indicate that 'EoR' is preferred.
>
>Page 5, Section 6, table: value 255 is shown reserved.  This clashes with
>the text in Section 3.2 which indicates all values outside of 0 - 2 are
>reserved.
>
>Page 5, last paragraph, 2nd sentence: change "need" to "needs".
>
>Page 7, authors' addresses: drop "95124" from both addresses.
>
>