RE: Review of draft-ietf-dime-load-07

Roni Even <roni.even@huawei.com> Wed, 08 March 2017 06:39 UTC

Return-Path: <roni.even@huawei.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ED3EA129480 for <ietf@ietfa.amsl.com>; Tue, 7 Mar 2017 22:39:57 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.222
X-Spam-Level:
X-Spam-Status: No, score=-4.222 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CAF0vjeSf1n5 for <ietf@ietfa.amsl.com>; Tue, 7 Mar 2017 22:39:56 -0800 (PST)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3318712941D for <ietf@ietf.org>; Tue, 7 Mar 2017 22:39:56 -0800 (PST)
Received: from 172.18.7.190 (EHLO lhreml703-cah.china.huawei.com) ([172.18.7.190]) by lhrrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id DCJ65574; Wed, 08 Mar 2017 06:39:54 +0000 (GMT)
Received: from DGGEMM403-HUB.china.huawei.com (10.3.20.211) by lhreml703-cah.china.huawei.com (10.201.108.44) with Microsoft SMTP Server (TLS) id 14.3.301.0; Wed, 8 Mar 2017 06:39:53 +0000
Received: from DGGEMM506-MBS.china.huawei.com ([169.254.4.77]) by DGGEMM403-HUB.china.huawei.com ([10.3.20.211]) with mapi id 14.03.0301.000; Wed, 8 Mar 2017 14:39:45 +0800
From: Roni Even <roni.even@huawei.com>
To: Steve Donovan <srdonovan@usdonovans.com>, "ietf@ietf.org" <ietf@ietf.org>
Subject: RE: Review of draft-ietf-dime-load-07
Thread-Topic: Review of draft-ietf-dime-load-07
Thread-Index: AQHSl1pAwVKbCs8uhUmqxDAuAs02/6GKfpuA
Date: Wed, 08 Mar 2017 06:39:46 +0000
Message-ID: <6E58094ECC8D8344914996DAD28F1CCD78E455@DGGEMM506-MBS.china.huawei.com>
References: <148784049413.20240.15876379956092850264.idtracker@ietfa.amsl.com> <0390f072-bf67-d77b-a47f-b76140be81ae@usdonovans.com>
In-Reply-To: <0390f072-bf67-d77b-a47f-b76140be81ae@usdonovans.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.200.201.224]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090206.58BFA73A.0067, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=169.254.4.77, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: f18fa6d5fdf9278fa46629f36c32d4a9
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf/NcqrrqtXnE8vkQTTw0NMbygmFw8>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Mar 2017 06:39:58 -0000

Hi Steve,
Thanks, I have no more comments
Roni

> -----Original Message-----
> From: ietf [mailto:ietf-bounces@ietf.org] On Behalf Of Steve Donovan
> Sent: יום ג 07 מרץ 2017 17:45
> To: ietf@ietf.org
> Subject: Re: Review of draft-ietf-dime-load-07
> 
> Roni,
> 
> Thank you for your review.  Please see my comments inline.
> 
> Steve
> 
> On 2/23/17 3:01 AM, Roni Even wrote:
> > Reviewer: Roni Even
> > Review result: Ready with Nits
> >
> > I am the assigned Gen-ART reviewer for this draft. The General Area
> > Review Team (Gen-ART) reviews all IETF documents being processed by
> > the IESG for the IETF Chair.  Please treat these comments just like
> > any other last call comments.
> >
> > For more information, please see the FAQ at
> >
> > <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> >
> > Document: draft-ietf-dime-load-07
> > Reviewer: Roni Even
> > Review Date: 2017-02-23
> > IETF LC End Date: 2017-02-27
> > IESG Telechat date: 2017-03-16
> >
> > Summary: This draft is almost ready for publication as a standard
> > track RFC
> >
> > Major issues:
> >
> > Minor issues:
> >
> > I understand that each node can calculate the load differently , the
> > example in figure 8 demonstrate that the agent selection may be
> > different if the agent aggregates load from the servers to calculate
> > its load or just conveys his load, possibly even that each one of the
> > agents will use different method. Why not mandate load calculation
> > using aggregated weighted loads?
> SRD> The working group thought it was best to leave this as an
> implementation decision.
> >
> > Nits/editorial comments:
> > 1. In section 5 paragraph 9 "The load report includes a value
> > indicating the load of the sending
> >     node relative load of the sending node, " should be just "The load
> > report includes a value indicating the relative load of the sending
> > node,"
> SRD> Yes, change made.
> > 2. In section 6.2 "weigth "
> SRD> Change made.
> > 3. in the security consideration what about an endpoint in the middle
> > changing the host load value causing a change in the routing
> > decisions.
> SRD> I'm assuming that you mean an agent in the middle changing the host
> value.  I've added the following to the security considerations section
> -- "Given that routing decisions are impacted by load information, there is
> potential for negative impacts on a Diameter network caused by erroneous
> or malicious load reports. This includes the malicious changing of load values
> by Diameter Agents."
> >
> >
> >
> >