Gen-art review of draft-ietf-rmt-bb-fec-basic-schemes-revised-05
Elwyn Davies <elwynd@googlemail.com> Mon, 21 July 2008 16:33 UTC
Return-Path: <ietf-bounces@ietf.org>
X-Original-To: ietf-archive@megatron.ietf.org
Delivered-To: ietfarch-ietf-archive@core3.amsl.com
Received: from [127.0.0.1] (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id C4D3828C113; Mon, 21 Jul 2008 09:33:53 -0700 (PDT)
X-Original-To: ietf@core3.amsl.com
Delivered-To: ietf@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id A15B628C17E for <ietf@core3.amsl.com>; Fri, 18 Jul 2008 08:53:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.427
X-Spam-Level:
X-Spam-Status: No, score=-2.427 tagged_above=-999 required=5 tests=[AWL=0.172, BAYES_00=-2.599]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S6k1T-ryrAqn for <ietf@core3.amsl.com>; Fri, 18 Jul 2008 08:53:03 -0700 (PDT)
Received: from fk-out-0910.google.com (fk-out-0910.google.com [209.85.128.191]) by core3.amsl.com (Postfix) with ESMTP id 4C1B73A6AD8 for <ietf@ietf.org>; Fri, 18 Jul 2008 08:53:03 -0700 (PDT)
Received: by fk-out-0910.google.com with SMTP id 18so272019fkq.5 for <ietf@ietf.org>; Fri, 18 Jul 2008 08:53:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:content-type :content-transfer-encoding; bh=9wL4N1E216TSIy6sP3UMZb2hvhuSpUoRxcL7lQPeQkI=; b=PnhVljrTqa0/XBBv5bRboJGtN3DfSI0A3jb4o3OtxhHC+T73YnQyjjA6/p2E5Vd5HF AWRos7AOIqnVj0vf/ycDj1mTG8u9DXr5nJHr0UnOlXG7nBV1XdG4PxojN6BgfpmNruEq oMEY0nBkOEaB6/Oqp6lHRUnJe++97gbiW92d0=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :content-type:content-transfer-encoding; b=RbtJ3TofC2O24QkjVKFplBb6QVwAepirx6U8oJzZVTzk+LK68iGCZdZKSqAo6JpiEl NHpWORgG4uhJtHkIpU2tbWRZ+FR9oqhzEkREbBc+VQwTfp6J4uMq//HtYqEJrrudvK7n 8zGN7Pm5HrIlA9F23GTMThoCBNB9dqXWJfFgQ=
Received: by 10.180.246.10 with SMTP id t10mr185405bkh.104.1216396414268; Fri, 18 Jul 2008 08:53:34 -0700 (PDT)
Received: from ?81.187.254.247? ( [81.187.254.247]) by mx.google.com with ESMTPS id 36sm5073294hub.59.2008.07.18.08.53.32 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 18 Jul 2008 08:53:33 -0700 (PDT)
Message-ID: <4880BD70.2000407@googlemail.com>
Date: Fri, 18 Jul 2008 16:57:36 +0100
From: Elwyn Davies <elwynd@googlemail.com>
User-Agent: Thunderbird 2.0.0.14 (Windows/20080421)
MIME-Version: 1.0
To: General Area Review Team <gen-art@ietf.org>, Mark Watson <mark@digitalfountain.com>, IETF Discussion <ietf@ietf.org>, rmt-chairs@tools.ietf.org, rmt-ads@tools.ietf.org
Subject: Gen-art review of draft-ietf-rmt-bb-fec-basic-schemes-revised-05
X-Mailman-Approved-At: Mon, 21 Jul 2008 09:33:51 -0700
Cc: Mary Barnes <mary.barnes@nortel.com>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Sender: ietf-bounces@ietf.org
Errors-To: ietf-bounces@ietf.org
I have been selected as the General Area Review Team (Gen-ART) reviewer for this draft (for background on Gen-ART, please see _http://www.alvestrand.no/ietf/gen/art/gen-art-FAQ.html_). Please resolve these comments along with any other Last Call comments you may receive. Document: draft-ietf-rmt-bb-fec-basic-schemes-revised-05.txt Reviewer: Elwyn Davies Review Date: 18 July 2008 IETF LC End Date: 29 July 2008 IESG Telechat date: n/a Summary: Nearly ready for IESG. A few minor issues mainly with failure to specify encodings and a couple of corner cases. A few editorial nits noted below. Comments: s3.2.1: Need to explicitly document the encoding used for SBNs (also applies to s4.2.1 and s5.2.1. s5.2.1 also needs to specify encoding for Source Block Length). s3.2.1, bottom of page 6/top of page 7: s/is processed at/to process the block by/ (two places) (or some such .. it doesn't read well at present). s3.2.2.2: need to explicitly state encoding of various values (unsigned integers I assume). (also applies to s4.2.2.2, s4.2.2.3, s5.2.2.2 s4.2.2.3: The case where the length is zero is a lttle odd! I think it would be worth explicitly stating that (either) the whole object is just one octet long (or) it is four octets padded with zeroes. The latter case might make processing more consistent since otherwise the zero case is special and the only case where the object is not four octet aligned. s5.1: it is not possible to encode the source block length of 65536 in 16 bits unless 0 is overloaded to mean 2^^16. This isn't specified. (I assume 'at most' to be read as 'less than or equal'). Editorial: Abstract: Need to expand FEC at least once! s1, 2nd para after bullets: genrally not recommended to mention WG s1, last para: s/listed/are listed/ s3.2.1: Need to asociate Source Block Number and SBN explicitly (well, I assume that is what SBN means!). s3.4.1, next to last para: s/implementor of/implementor/ s3.4.2, lastpara: s/substracting/subtracting/ s4.4.2.2: I take the reference in the last para of the section (just above Fig 4) should be to s3.2.2.2. s10, 2nd bullet: s/th/the/ s10, 3rd bullet: s/sis/did/ _______________________________________________ Ietf mailing list Ietf@ietf.org https://www.ietf.org/mailman/listinfo/ietf
- Gen-art review of draft-ietf-rmt-bb-fec-basic-sch… Elwyn Davies
- Re: [Gen-art] Gen-art review of draft-ietf-rmt-bb… Elwyn Davies
- Re: Gen-art review of draft-ietf-rmt-bb-fec-basic… Mark Watson