RE: TSVDIR Review for draft-ietf-mpls-ip-options-05
"David Smith (djsmith)" <djsmith@cisco.com> Wed, 15 December 2010 20:21 UTC
Return-Path: <djsmith@cisco.com>
X-Original-To: ietf@core3.amsl.com
Delivered-To: ietf@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 8D5133A705A; Wed, 15 Dec 2010 12:21:41 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -10.599
X-Spam-Level:
X-Spam-Status: No, score=-10.599 tagged_above=-999 required=5 tests=[AWL=0.000, BAYES_00=-2.599, RCVD_IN_DNSWL_HI=-8]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z8dAqcDGz4Uh; Wed, 15 Dec 2010 12:21:39 -0800 (PST)
Received: from rtp-iport-1.cisco.com (rtp-iport-1.cisco.com [64.102.122.148]) by core3.amsl.com (Postfix) with ESMTP id E1C053A6FBF; Wed, 15 Dec 2010 12:21:38 -0800 (PST)
Authentication-Results: rtp-iport-1.cisco.com; dkim=neutral (message not signed) header.i=none
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AvsEAK+yCE2tJXHB/2dsb2JhbACkMHOoKJtRhUoEhGSJMw
X-IronPort-AV: E=Sophos;i="4.59,350,1288569600"; d="scan'208";a="193307850"
Received: from rcdn-core2-6.cisco.com ([173.37.113.193]) by rtp-iport-1.cisco.com with ESMTP; 15 Dec 2010 20:23:21 +0000
Received: from xbh-rcd-201.cisco.com (xbh-rcd-201.cisco.com [72.163.62.200]) by rcdn-core2-6.cisco.com (8.14.3/8.14.3) with ESMTP id oBFKNLO6008573; Wed, 15 Dec 2010 20:23:21 GMT
Received: from xmb-rcd-202.cisco.com ([72.163.62.209]) by xbh-rcd-201.cisco.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 15 Dec 2010 14:23:20 -0600
X-MimeOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Subject: RE: TSVDIR Review for draft-ietf-mpls-ip-options-05
Date: Wed, 15 Dec 2010 14:23:19 -0600
Message-ID: <BBA8913F1B2BDA43A022D5D7F48A1E4403192330@XMB-RCD-202.cisco.com>
In-Reply-To: <201012100015.oBA0F47M011963@sj-core-1.cisco.com>
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Thread-Topic: TSVDIR Review for draft-ietf-mpls-ip-options-05
Thread-Index: AcuX/04EWdVH/YIUSqWxlVW19TxSPwEjYcNA
References: <201012100015.oBA0F47M011963@sj-core-1.cisco.com>
From: "David Smith (djsmith)" <djsmith@cisco.com>
To: "James Polk (jmpolk)" <jmpolk@cisco.com>, wjaeger@att.com, "John Mullooly (jmullool)" <jmullool@cisco.com>, tscholl@nlayer.net, mpls@ietf.org
X-OriginalArrivalTime: 15 Dec 2010 20:23:20.0984 (UTC) FILETIME=[EA945180:01CB9C95]
X-Mailman-Approved-At: Thu, 16 Dec 2010 12:21:12 -0800
Cc: ietf@ietf.org, tsv-dir@ietf.org
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ietf>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Dec 2010 20:21:41 -0000
Hi James, Many thanks for the review & comments. We will incorporate them into -06 which we'll post soon. See our feedback inline below as well [djsmith]. Regards, /dave -----Original Message----- From: James Polk (jmpolk) Sent: Thursday, December 09, 2010 7:15 PM To: wjaeger@att.com; John Mullooly (jmullool); tscholl@nlayer.net; David Smith (djsmith); mpls@ietf.org Cc: tsv-dir@ietf.org; ietf@ietf.org Subject: TSVDIR Review for draft-ietf-mpls-ip-options-05 I've reviewed this document as part of the transport area directorate's ongoing effort to review key IETF documents. These comments were written primarily for the transport area directors, but are copied to the document's authors for their information and to allow them to address any issues raised. The authors should consider this review together with any other last-call comments they receive. Please always CC <mailto:tsv-dir@ietf.org>tsv-dir@ietf.org if you reply to or forward this review. Summary: This is a well written, concise and needed modification to MPLS. That said, I don't understand why the 1st minor issue below is present. Recommend (fairly strongly) adding the "Document Updates: RFC 3031, RFC 3032" as mentioned below on this first page of this RFC to be. [djsmith] ack, changed to ID updates RFC 3031 (but not RFC 3032). Changed ID header and Motivation text per below. Transport Issues: There are no issues minor issues: - S2 "Motivation", last sentence is "We believe that this document adds details that have not been fully addressed in [RFC3031] and [RFC3032] as well as complements [RFC3270], [RFC3443] and [RFC4950]. " I find it surprising that this document does not formally update 3031 and 3032, given that it is mandatory to implement, optional to invoke. ISTM, as an outsider to MPLS, this would in fact be the case given the impact of/to IP stacks not adhering to this proposed standard. [djsmith] ack, changed to ID updates RFC 3031 (but not RFC 3032). Changed ID header and Motivation text "We believe that this document adds details that have not been fully addressed in [RFC3031] and [RFC3032], and that the methods presented in this document update [RFC3031] as well as complement [RFC3270], [RFC3443] and [RFC4950]." - Section 5.2 is about Router Alert Options, and states "At the time of this writing ...". I wonder if this subsection is valid, or needs another review against this IntArea ID http://tools.ietf.org/html/draft-ietf-intarea-router-alert-consideration s-02 to still be valid in a month or two once the IntArea ID (currently in WGLC) is processed by the IESG and RFC-Editor? IMO - these two docs are progressing near enough to each other to each consider what the other says - with or without a normative or informative reference in either or both docs to the other. [djsmith] Note, the text relating to "at the time of this writing" is referring to the (MPLS) Router Alert Label not the (IP) Router Alert Option. Hence, this section remains valid given no existing standard for Router Alert Label imposition. This ID specifies that a IP RAO cannot influence imposition of a RAL (Router Alert Label). So we've kept this section as is. nits: - I'm surprised to see the Abstract on page 2. I thought we collectively fixed the case in which the Abstract can be on any page other than page 1. [djsmith] ack, changed. I think you meant Abstract _cannot_ be on any page other than page 1. - at the page Footer, in the middle of the line, there isn't a "short document name" - which has been there on all previous well formed IDs and RFCs that I have seen (which of course is not all of them). It is recommended the authors pick a short form name for the subject of this doc for this location, such as LER Header Option Behaviors [djsmith] ack, changed. - S3, 4th para, second to last sentence is: "First a downstream LSR may have not have sufficient IP routing information to forward the packet resulting in packet loss. " recommend removing the first instance of "have". The sentence reads better without it. [djsmith] ack, changed. - S3, 4th para, last two sentences list a "First" and a "Second" reason correctly, but are missing required commas after each word (i.e., "First, ...", and "Second, ..." ) [djsmith] ack, changed. - S3, 5th para, 1st sentence is lacking commas here: "...FEC, yet are forwarded into an IP/MPLS network without being MPLS-encapsulated, present..." [djsmith] ack, changed. - S5.1, last bullet has this: "...MPLS encapsulation at a ingress LER ..." ^^^^^ s/a/an [djsmith] ack, changed. James
- TSVDIR Review for draft-ietf-mpls-ip-options-05 James M. Polk
- RE: TSVDIR Review for draft-ietf-mpls-ip-options-… David Smith (djsmith)