Gen-ART LC/Telechat review of draft-ietf-pce-iro-update-06

Peter Yee <peter@akayla.com> Sun, 17 April 2016 20:10 UTC

Return-Path: <peter@akayla.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 700CF12DE12; Sun, 17 Apr 2016 13:10:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, MIME_QP_LONG_LINE=0.001, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id taz873cNHEaI; Sun, 17 Apr 2016 13:10:25 -0700 (PDT)
Received: from p3plsmtpa11-03.prod.phx3.secureserver.net (p3plsmtpa11-03.prod.phx3.secureserver.net [68.178.252.104]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C4C2912DE77; Sun, 17 Apr 2016 13:10:25 -0700 (PDT)
Received: from [10.10.0.32] ([181.110.255.3]) by p3plsmtpa11-03.prod.phx3.secureserver.net with id jYAK1s00505AX1901YANUq; Sun, 17 Apr 2016 13:10:25 -0700
User-Agent: Microsoft-MacOutlook/14.6.2.160219
Date: Sun, 17 Apr 2016 13:10:17 -0700
Subject: Gen-ART LC/Telechat review of draft-ietf-pce-iro-update-06
From: Peter Yee <peter@akayla.com>
To: draft-ietf-pce-iro-update.all@ietf.org
Message-ID: <D3393302.16A48%peter@akayla.com>
Thread-Topic: Gen-ART LC/Telechat review of draft-ietf-pce-iro-update-06
Mime-version: 1.0
Content-type: text/plain; charset="UTF-8"
Content-transfer-encoding: quoted-printable
Archived-At: <http://mailarchive.ietf.org/arch/msg/ietf/wE0AaY7H8zQzD4r1nrlGgjud3mg>
Cc: gen-art@ietf.org, IETF <ietf@ietf.org>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Apr 2016 20:10:27 -0000

I am the assigned Gen-ART reviewer for this draft. The General Area Review
Team (Gen-ART) reviews all IETF documents being processed by the IESG for
the IETF Chair. Please wait for direction from your document shepherd or
AD before posting a new version of the draft.

For more information, please see the FAQ at
<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-ietf-pce-iro-update-06
Reviewer: Peter Yee
Review Date: Apr-17-2016
IETF LC End Date: Mar-29-2016
IESG Telechat date: Apr-21-2016

Summary: This draft is basically ready for publication as a Standards
Track RFC, but has some nits that should be fixed before publication.
[Ready with nits]

This specification documents the results of a survey regarding
implementation of the Include Route Object for PCEP and uses those results
to clarify the meaning of section 7.12 of RFC 5440 with updated text.

Major issues: None

Minor issues: None really

Page 5, Section 4, 1st paragraph, 2nd sentence: Are you sure that
confusing interpretation of the IRO ordering or the L bit doesn’t cause
any security issues?  I’m not PCEP savvy enough to know if mistakenly
sending information that should have gone strictly through a loose node
would disclose anything that the originator didn’t really wish any nodes
outside of the strict list to see.


Nits:

Page 3, first full paragraph: insert “an” before “IRO”.

Page 3, Section 2 title: insert “the” before “IRO”.

Page 3, Section 2, 3rd paragraph, 2nd sentence: insert “them” before the
second “as”.

Page 4, Section 2, 1st paragraph: append a colon to the end of the
paragraph.

Page 4, Section 2, indented bullet item: remove the hyphen and put the
remainder between double quotes, not single quotes.

Page 4, Section 2, 1st major bullet item, 1st sentence: insert “an” before
“IRO”.  

Page 4, Section 2, 1st major bullet item, 2nd sentence: change
“comprising” to “comprised”.  Insert “to” before “section”.

Page 4, Section 2, 2nd major bullet item, 1st sentence: insert “an” before
“IRO”.  Change the comma to a semicolon.

Page 4, Section 2, 2nd major bullet item, 3rd sentence: insert “the”
before “Loose”.

Page 4, Section 3, 2nd paragraph, 1st sentence: delete comma.

Page 4, Section 3, 2nd paragraph, 2nd sentence: change trailing space and
hyphen to a colon.

Page 4, Section 3, 1st bullet item: delete comma after “IRO”.  Insert
“the” before the last “IRO”.

Page 5, Section 3, 1st paragraph: insert “the” before “IRO”.

Page 5, Section 4, 1st paragraph, 1st sentence: insert “the” before “IRO”.