[Int-dir] INTDIR Review of draft-ietf-nvo3-bfd-geneve-12
Donald Eastlake <d3e3e3@gmail.com> Sat, 05 August 2023 11:23 UTC
Return-Path: <d3e3e3@gmail.com>
X-Original-To: int-dir@ietfa.amsl.com
Delivered-To: int-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F0E33C14CF0D; Sat, 5 Aug 2023 04:23:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.855
X-Spam-Level:
X-Spam-Status: No, score=-1.855 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zX_9D9KVBU4T; Sat, 5 Aug 2023 04:23:35 -0700 (PDT)
Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 05115C14CF05; Sat, 5 Aug 2023 04:23:29 -0700 (PDT)
Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5231f439968so1787059a12.0; Sat, 05 Aug 2023 04:23:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691234608; x=1691839408; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=okforGfLQeckxVhizmQkKKwpCt6ulEdnuTdq4k+G1eE=; b=QwsBof+h50K5auiB3T5gCWrHNxzMBtW5cVuDlsci9min1RrFnd2Lgp/aHMbSvA5/+s mwoZqHUSjtJgcz8xFlSik3zirUppeEWuF0MFuCpXJyZtwvjG5wAYP3vkrnfu5bqHWf8R oPXpB/kIH5Jv43LZutinSaZWxBhFpwVpQ8K8TEupzKqGWXPf+RpXB9anjINn9HU4HCSU RCqeokUqOzg4mmjkbag5R6JsKZtIfJO47y8KGthkvPMMWGRMa5uuXloWJDex4xJQLiaL DWdE3G9X7ekqRGpMGx87SADLbN1L0sVS9v4u5ungYnqiIduMVv8kcJ9Wa5fVIJ2QYIvu 3k1Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691234608; x=1691839408; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=okforGfLQeckxVhizmQkKKwpCt6ulEdnuTdq4k+G1eE=; b=RoWsr255+5Kr5sTGdISfb++lrHh8wzg+1pKx8+GV1l1BlXcKo4gisFiB1RoynXz6bb NJqmRE0RfI+48NaVfpBds+bI/AZt0vc6p8kIvi0RFUhKXYMVt9081pfHaISGdiTJFVdq crtPCi2I5J4wdo+qQ9bTGN65KrqJijZqL+6XhEMtPX2Knd3MNysLkllzhqrEoRI1eghg WdTNRkrIBtQ1z5Qfu6bILuIK7lU84eNjM3jWeI9cEEsdFmB3FpSWy2vCW/c6UUsSLtSV 5lBsPqA3EH82LSojDE5lmqol9i55Aoqk9SPjrNOi66eKAp5KAWNg9k+ANZRPN27IgIR1 xAJw==
X-Gm-Message-State: AOJu0Yz6B2JnYP0s4VZkW/sqRjue16yB01h1PL0pEiQJSVvx4W4cGCUI VJ77LJkqcaQxGWxlQKqs6gZK5GuQ5ujeDGInOr7iZXMhpUkmfQ==
X-Google-Smtp-Source: AGHT+IGcEHVOzsekm4qbRU0OmHXRF2M7LNw3eMQBbiBvoAphOj4W/Aibs52VdM3JeygRpJnTYDlfZngc4veLdUSPALo=
X-Received: by 2002:a05:6402:148b:b0:522:55cb:ad88 with SMTP id e11-20020a056402148b00b0052255cbad88mr3090095edv.6.1691234607592; Sat, 05 Aug 2023 04:23:27 -0700 (PDT)
MIME-Version: 1.0
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Sat, 05 Aug 2023 07:23:16 -0400
Message-ID: <CAF4+nEG39egEFAaRQtkO6rqoyPqk2bVnfxAZHB_jWHMX7VzKgA@mail.gmail.com>
To: int-ads@ietf.org, draft-ietf-nvo3-bfd-geneve.all@ietf.org
Cc: int-dir@ietf.org, nvo3-chairs@ietf.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/int-dir/EsOz_uqyKJArXs3qz2HznHTV_B8>
Subject: [Int-dir] INTDIR Review of draft-ietf-nvo3-bfd-geneve-12
X-BeenThere: int-dir@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "This list is for discussion between the members of the Internet Area directorate." <int-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/int-dir>, <mailto:int-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/int-dir/>
List-Post: <mailto:int-dir@ietf.org>
List-Help: <mailto:int-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/int-dir>, <mailto:int-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Aug 2023 11:23:39 -0000
I am an assigned INT directorate reviewer for <draft-ietf-nvo3-geneve-12.txt>. These comments were written primarily for the benefit of the Internet Area Directors. Document editors and shepherd(s) should treat these comments just like they would treat comments from any other IETF contributors and resolve them along with any other Last Call comments that have been received. For more details on the INT Directorate, see https://datatracker.ietf.org/group/intdir/about/ <https://datatracker.ietf.org/group/intdir/about/>. Based on my review, if I was on the IESG I would ballot this document as DISCUSS. I have the following DISCUSS/ABSTAIN level issues: - I do not understand the second half of the last paragraph of Section 1. It says: "BFD for Geneve MUST be used within a TMCE unless BFD is congestion controlled." But then seems to specify that it be congestion controlled inside a TMCE. Would it be simpler to say that BFD for Geneve must always be congestion controlled, if that is what is intended? - The wording in Section 4.1 first paragraph seems confusing and incomplete. (I believe this has been covered in other reviews.) - In the first paragraph of Section 6: How can it be that both "Geneve provides security" and "Geneve does not have any inherent security mechanisms" ? The following are other issues I found with this document that SHOULD be corrected before publication: - In section 4, the Inner Ethernet Header MAC addresses are in the wrong order. The Destination MAC comes first, followed by the Source MAC in an Ethernet header, the opposite of IP. The following are minor issues (typos, misspelling, minor text improvements) with the document: - Given the prominence of "tunnels" in the one sentence abstract, I think it would be good to use that word in the first paragraph of the Introduction. Possibly: "... an overlay network of tunnels by decoupling ..." - Section 1, last line of first paragraph on page 3: payload -> payloads - Section 4.1, first paragraph: "Protocol Type" -> "Ethertype" - Section 5, last line: that -> when - Section 6, "not low" -> "high" Thanks, Donald =============================== Donald E. Eastlake 3rd +1-508-333-2270 (cell) 2386 Panoramic Circle, Apopka, FL 32703 USA d3e3e3@gmail.com
- [Int-dir] INTDIR Review of draft-ietf-nvo3-bfd-ge… Donald Eastlake
- Re: [Int-dir] INTDIR Review of draft-ietf-nvo3-bf… Eric Vyncke (evyncke)
- Re: [Int-dir] INTDIR Review of draft-ietf-nvo3-bf… xiao.min2
- Re: [Int-dir] INTDIR Review of draft-ietf-nvo3-bf… xiao.min2
- Re: [Int-dir] INTDIR Review of draft-ietf-nvo3-bf… Donald Eastlake
- Re: [Int-dir] INTDIR Review of draft-ietf-nvo3-bf… xiao.min2
- Re: [Int-dir] INTDIR Review of draft-ietf-nvo3-bf… Donald Eastlake
- Re: [Int-dir] [nvo3] INTDIR Review of draft-ietf-… xiao.min2
- Re: [Int-dir] INTDIR Review of draft-ietf-nvo3-bf… Eric Vyncke (evyncke)