Re: [Int-dir] INTDIR Review of draft-ietf-nvo3-bfd-geneve-12
xiao.min2@zte.com.cn Tue, 15 August 2023 08:56 UTC
Return-Path: <xiao.min2@zte.com.cn>
X-Original-To: int-dir@ietfa.amsl.com
Delivered-To: int-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3DD92C15107B; Tue, 15 Aug 2023 01:56:03 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.903
X-Spam-Level:
X-Spam-Status: No, score=-1.903 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KvB_7g_Slf6o; Tue, 15 Aug 2023 01:55:59 -0700 (PDT)
Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.35]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 26381C14F747; Tue, 15 Aug 2023 01:55:57 -0700 (PDT)
Received: from mse-fl2.zte.com.cn (unknown [10.5.228.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4RQ4qL0Rm5z5PLmr; Tue, 15 Aug 2023 16:55:42 +0800 (CST)
Received: from njy2app04.zte.com.cn ([10.40.12.64]) by mse-fl2.zte.com.cn with SMTP id 37F8tmFo014967; Tue, 15 Aug 2023 16:55:48 +0800 (+08) (envelope-from xiao.min2@zte.com.cn)
Received: from mapi (njy2app03[null]) by mapi (Zmail) with MAPI id mid201; Tue, 15 Aug 2023 16:55:51 +0800 (CST)
Date: Tue, 15 Aug 2023 16:55:51 +0800
X-Zmail-TransId: 2afb64db3d97ffffffffe4b-b07ec
X-Mailer: Zmail v1.0
Message-ID: <202308151655511228781@zte.com.cn>
In-Reply-To: <33B8AC93-9B56-43EB-B3AE-A24C7372CBD4@cisco.com>
References: CAF4+nEG39egEFAaRQtkO6rqoyPqk2bVnfxAZHB_jWHMX7VzKgA@mail.gmail.com, 33B8AC93-9B56-43EB-B3AE-A24C7372CBD4@cisco.com
Mime-Version: 1.0
From: xiao.min2@zte.com.cn
To: evyncke@cisco.com
Cc: d3e3e3@gmail.com, int-ads@ietf.org, draft-ietf-nvo3-bfd-geneve.all@ietf.org, int-dir@ietf.org, nvo3-chairs@ietf.org
Content-Type: multipart/mixed; boundary="=====_001_next====="
X-MAIL: mse-fl2.zte.com.cn 37F8tmFo014967
X-Fangmail-Gw-Spam-Type: 0
X-Fangmail-Anti-Spam-Filtered: true
X-Fangmail-MID-QID: 64DB3D8E.000/4RQ4qL0Rm5z5PLmr
Archived-At: <https://mailarchive.ietf.org/arch/msg/int-dir/izCHZTajkusz_fsxO5VxDB5-oZU>
Subject: Re: [Int-dir] INTDIR Review of draft-ietf-nvo3-bfd-geneve-12
X-BeenThere: int-dir@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "This list is for discussion between the members of the Internet Area directorate." <int-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/int-dir>, <mailto:int-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/int-dir/>
List-Post: <mailto:int-dir@ietf.org>
List-Help: <mailto:int-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/int-dir>, <mailto:int-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Aug 2023 08:56:03 -0000
Hi Eric, I've replied to Donald's review. Will address your balloting comments after Donald and I converge. Best Regards, Xiao Min Original From: EricVyncke(evyncke) <evyncke@cisco.com> To: Donald Eastlake <d3e3e3@gmail.com>;int-ads@ietf.org <int-ads@ietf.org>;draft-ietf-nvo3-bfd-geneve.all@ietf.org <draft-ietf-nvo3-bfd-geneve.all@ietf.org>; Cc: int-dir@ietf.org <int-dir@ietf.org>;nvo3-chairs@ietf.org <nvo3-chairs@ietf.org>; Date: 2023年08月07日 19:41 Subject: Re: [Int-dir] INTDIR Review of draft-ietf-nvo3-bfd-geneve-12 Donald, Thank you for your int-dir review. As you may have read, I have balloted a DISCUSS on this document, notably based on your review. I am also expecting the authors to reply to your review. Regards -éric On 05/08/2023, 13:23, "Int-dir on behalf of Donald Eastlake" <int-dir-bounces@ietf.org <mailto:int-dir-bounces@ietf.org> on behalf of d3e3e3@gmail.com <mailto:d3e3e3@gmail.com>> wrote: I am an assigned INT directorate reviewer for <draft-ietf-nvo3-geneve-12.txt>. These comments were written primarily for the benefit of the Internet Area Directors. Document editors and shepherd(s) should treat these comments just like they would treat comments from any other IETF contributors and resolve them along with any other Last Call comments that have been received. For more details on the INT Directorate, see https://datatracker.ietf.org/group/intdir/about/ <https://datatracker.ietf.org/group/intdir/about/> <https://datatracker.ietf.org/group/intdir/about/> <https://datatracker.ietf.org/group/intdir/about/>>. Based on my review, if I was on the IESG I would ballot this document as DISCUSS. I have the following DISCUSS/ABSTAIN level issues: - I do not understand the second half of the last paragraph of Section 1. It says: "BFD for Geneve MUST be used within a TMCE unless BFD is congestion controlled." But then seems to specify that it be congestion controlled inside a TMCE. Would it be simpler to say that BFD for Geneve must always be congestion controlled, if that is what is intended? - The wording in Section 4.1 first paragraph seems confusing and incomplete. (I believe this has been covered in other reviews.) - In the first paragraph of Section 6: How can it be that both "Geneve provides security" and "Geneve does not have any inherent security mechanisms" ? The following are other issues I found with this document that SHOULD be corrected before publication: - In section 4, the Inner Ethernet Header MAC addresses are in the wrong order. The Destination MAC comes first, followed by the Source MAC in an Ethernet header, the opposite of IP. The following are minor issues (typos, misspelling, minor text improvements) with the document: - Given the prominence of "tunnels" in the one sentence abstract, I think it would be good to use that word in the first paragraph of the Introduction. Possibly: "... an overlay network of tunnels by decoupling ..." - Section 1, last line of first paragraph on page 3: payload -> payloads - Section 4.1, first paragraph: "Protocol Type" -> "Ethertype" - Section 5, last line: that -> when - Section 6, "not low" -> "high" Thanks, Donald =============================== Donald E. Eastlake 3rd +1-508-333-2270 (cell) 2386 Panoramic Circle, Apopka, FL 32703 USA d3e3e3@gmail.com <mailto:d3e3e3@gmail.com> _______________________________________________ Int-dir mailing list Int-dir@ietf.org <mailto:Int-dir@ietf.org> https://www.ietf.org/mailman/listinfo/int-dir <https://www.ietf.org/mailman/listinfo/int-dir>
- [Int-dir] INTDIR Review of draft-ietf-nvo3-bfd-ge… Donald Eastlake
- Re: [Int-dir] INTDIR Review of draft-ietf-nvo3-bf… Eric Vyncke (evyncke)
- Re: [Int-dir] INTDIR Review of draft-ietf-nvo3-bf… xiao.min2
- Re: [Int-dir] INTDIR Review of draft-ietf-nvo3-bf… xiao.min2
- Re: [Int-dir] INTDIR Review of draft-ietf-nvo3-bf… Donald Eastlake
- Re: [Int-dir] INTDIR Review of draft-ietf-nvo3-bf… xiao.min2
- Re: [Int-dir] INTDIR Review of draft-ietf-nvo3-bf… Donald Eastlake
- Re: [Int-dir] [nvo3] INTDIR Review of draft-ietf-… xiao.min2
- Re: [Int-dir] INTDIR Review of draft-ietf-nvo3-bf… Eric Vyncke (evyncke)