Re: [Int-dir] Intdir last call review of draft-ietf-add-split-horizon-authority-06

tirumal reddy <kondtir@gmail.com> Tue, 05 December 2023 05:55 UTC

Return-Path: <kondtir@gmail.com>
X-Original-To: int-dir@ietfa.amsl.com
Delivered-To: int-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 60425C14F60C; Mon, 4 Dec 2023 21:55:23 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.605
X-Spam-Level:
X-Spam-Status: No, score=-6.605 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLACK=0.5, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GqZ7zONYIiTj; Mon, 4 Dec 2023 21:55:19 -0800 (PST)
Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B7CD1C14F601; Mon, 4 Dec 2023 21:55:19 -0800 (PST)
Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-a1c9f65a45bso1921166b.1; Mon, 04 Dec 2023 21:55:19 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701755718; x=1702360518; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=CN14VCocrpy7ZBNIOaor0TpN3Ga4orV6YIe7z9VuLkA=; b=WxklAQr7cRDfFR1WokhBTesNf5o6Aw3T490h1bBTyjI/2tECmKe9ntAHIuZ3DB6IzV GDby//P9YtCAyMEpBlbPPtWdGxVNSbM2ZyMiSj+hCfuuyvtlyQVfWoETfbNFXmO0HFUv 8IelzIkSpA7m5riDf2ZG0NPgODZjULbakQ+G3VJczKryiCXoV7PFmg1oSkRobmVwja5E sfpMW8IZBnM8h3TiO4F9TMKGXS9k161yqH8ExcrVv1Gdx7A9HlLt85VfNrR0RN2TPLqC YFS1kI4wcCuZgb2Gpgrx6GT5OM2vDFHv4uia44cXDLN4erxcPCU5aq7ZORKU4sxRsNVT ZCVQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701755718; x=1702360518; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CN14VCocrpy7ZBNIOaor0TpN3Ga4orV6YIe7z9VuLkA=; b=fFaDH8ps23vWcEJBaTFfddlhXyCuKeNXSyPXpb5mk6Ptp45032hhaIPlbRldEPAhJ+ Yv6YFYfxz9wBXpdq0CKo6QyKK6b0+LmAziWCRfGktqNz3IEfhjjGMAqih2r8HPz5NZhR HNuwjaoWsFYxAtuBj0zrUfG/WFnC7kAmV4ceKPXIC2Kn/DIhmpE++tA3V5x69gVTaKU/ xMJGJllEY5tAlcQhYJCheRzBGfO0zfmC7KIOu2HQayEK1BbdcKa+jfV6YCwYbBxZLpYm auBCNpaXDI/OySoubOKAiYwGAGl5TEUjZSVCDHJ1hir51F9ItY/indtwbMzqNaZRFb12 J6Tg==
X-Gm-Message-State: AOJu0YxgjfXo8b17KGSflZox+HGy7Fgcf58Qe6F67iH1s5i+TRXkVPUk vrH2oBO57zPzHdD4vmnCa9IMTiBiETJTJxwdW4wCer6GguE=
X-Google-Smtp-Source: AGHT+IFgK1JY460SureRnnkXsRkHZGTiU5tP/4+v4nxADf0jRUzAFUFKMPVxBx3SXJTKAE6PAYfUPHwO15aVu0PoXjA=
X-Received: by 2002:a17:907:390:b0:a01:b9bd:87a with SMTP id ss16-20020a170907039000b00a01b9bd087amr9806995ejb.7.1701755717635; Mon, 04 Dec 2023 21:55:17 -0800 (PST)
MIME-Version: 1.0
References: <170128861441.15427.1958437411331145929@ietfa.amsl.com>
In-Reply-To: <170128861441.15427.1958437411331145929@ietfa.amsl.com>
From: tirumal reddy <kondtir@gmail.com>
Date: Tue, 05 Dec 2023 11:24:40 +0530
Message-ID: <CAFpG3gerbDqYyzf2sDTdhDNTWL16xzvrTHNW4i-z+ZG_oabEcQ@mail.gmail.com>
To: Bob Halley <rthalley@gmail.com>
Cc: int-dir@ietf.org, add@ietf.org, draft-ietf-add-split-horizon-authority.all@ietf.org, last-call@ietf.org
Content-Type: multipart/alternative; boundary="0000000000000b51c0060bbce1d6"
Archived-At: <https://mailarchive.ietf.org/arch/msg/int-dir/aY9GFGd78O1xWeMzDlWhN3zpc2o>
Subject: Re: [Int-dir] Intdir last call review of draft-ietf-add-split-horizon-authority-06
X-BeenThere: int-dir@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "This list is for discussion between the members of the Internet Area directorate." <int-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/int-dir>, <mailto:int-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/int-dir/>
List-Post: <mailto:int-dir@ietf.org>
List-Help: <mailto:int-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/int-dir>, <mailto:int-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Dec 2023 05:55:23 -0000

Thanks Bob for the review. Please see inline

On Thu, 30 Nov 2023 at 01:40, Bob Halley via Datatracker <noreply@ietf.org>
wrote:

> Reviewer: Bob Halley
> Review result: Ready with Nits
>
> I am an assigned INT directorate reviewer for
> <draft-ietf-add-split-horizon-authority-06.txt>. These comments were
> written
> primarily for the benefit of the Internet Area Directors. Document editors
> and
> shepherd(s) should treat these comments just like they would treat comments
> from any other IETF contributors and resolve them along with any other Last
> Call comments that have been received. For more details on the INT
> Directorate,
> see https://datatracker.ietf.org/group/intdir/about/
> <https://datatracker.ietf.org/group/intdir/about/>.
>
> Based on my review, if I was on the IESG I would ballot this document as
> YES.
>
> The following are other issues I found with this document that SHOULD be
> corrected before publication:
>
> The example has the wrong value for the token.  The authors have already
> corrected this for future versions of the draft.
>
> The duration of authorization is not discussed explicitly in the
> document.  The
> natural assumption would be that it is limited to the DNS record lifetime,
> but
> I could also imagine it being a matter of local policy or being
> incorporated
> into the claim.  It would be nice if the document said something on this
> topic,
> but it's not a showstopper for me.
>

We added a new section to discuss it in detail, please see
https://author-tools.ietf.org/api/iddiff?doc_1=draft-ietf-add-split-horizon-authority&url_2=https://ietf-wg-add.github.io/draft-ietf-add-split-horizon-authority/draft-ietf-add-split-horizon-authority.txt


-Tiru


>
> It might be good to have a version in the token format, though the
> "_splitdns-challenge" label could also be updated in the future if needed,
> e.g.
> to "_splitdns-challenge-v2".
>
>
>