[Int-dir] Intdir last call review of draft-ietf-add-split-horizon-authority-06

Bob Halley via Datatracker <noreply@ietf.org> Wed, 29 November 2023 20:10 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: int-dir@ietf.org
Delivered-To: int-dir@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 69356C15154D; Wed, 29 Nov 2023 12:10:14 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Bob Halley via Datatracker <noreply@ietf.org>
To: int-dir@ietf.org
Cc: add@ietf.org, draft-ietf-add-split-horizon-authority.all@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 11.15.1
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <170128861441.15427.1958437411331145929@ietfa.amsl.com>
Reply-To: Bob Halley <rthalley@gmail.com>
Date: Wed, 29 Nov 2023 12:10:14 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/int-dir/mm02KeccfYmLrHFoXyXU1zNDjck>
Subject: [Int-dir] Intdir last call review of draft-ietf-add-split-horizon-authority-06
X-BeenThere: int-dir@ietf.org
X-Mailman-Version: 2.1.39
List-Id: "This list is for discussion between the members of the Internet Area directorate." <int-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/int-dir>, <mailto:int-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/int-dir/>
List-Post: <mailto:int-dir@ietf.org>
List-Help: <mailto:int-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/int-dir>, <mailto:int-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Nov 2023 20:10:14 -0000

Reviewer: Bob Halley
Review result: Ready with Nits

I am an assigned INT directorate reviewer for
<draft-ietf-add-split-horizon-authority-06.txt>. These comments were written
primarily for the benefit of the Internet Area Directors. Document editors and
shepherd(s) should treat these comments just like they would treat comments
from any other IETF contributors and resolve them along with any other Last
Call comments that have been received. For more details on the INT Directorate,
see https://datatracker.ietf.org/group/intdir/about/
<https://datatracker.ietf.org/group/intdir/about/>.

Based on my review, if I was on the IESG I would ballot this document as YES.

The following are other issues I found with this document that SHOULD be
corrected before publication:

The example has the wrong value for the token.  The authors have already
corrected this for future versions of the draft.

The duration of authorization is not discussed explicitly in the document.  The
natural assumption would be that it is limited to the DNS record lifetime, but
I could also imagine it being a matter of local policy or being incorporated
into the claim.  It would be nice if the document said something on this topic,
but it's not a showstopper for me.

It might be good to have a version in the token format, though the
"_splitdns-challenge" label could also be updated in the future if needed, e.g.
to "_splitdns-challenge-v2".