[IPsec] Lars Eggert's No Objection on draft-ietf-ipsecme-ikev1-algo-to-historic-08: (with COMMENT)

Lars Eggert via Datatracker <noreply@ietf.org> Mon, 12 December 2022 13:56 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: ipsec@ietf.org
Delivered-To: ipsec@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 539A1C1522BE; Mon, 12 Dec 2022 05:56:52 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Lars Eggert via Datatracker <noreply@ietf.org>
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-ipsecme-ikev1-algo-to-historic@ietf.org, ipsecme-chairs@ietf.org, ipsec@ietf.org, kivinen@iki.fi, kivinen@iki.fi
X-Test-IDTracker: no
X-IETF-IDTracker: 9.2.1
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Lars Eggert <lars@eggert.org>
Message-ID: <167085341233.45639.17513606555372164162@ietfa.amsl.com>
Date: Mon, 12 Dec 2022 05:56:52 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/ipsec/sd7zTQ2Yf_6wFRVAJQNO_ldrD9Q>
Subject: [IPsec] Lars Eggert's No Objection on draft-ietf-ipsecme-ikev1-algo-to-historic-08: (with COMMENT)
X-BeenThere: ipsec@ietf.org
X-Mailman-Version: 2.1.39
List-Id: Discussion of IPsec protocols <ipsec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ipsec>, <mailto:ipsec-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ipsec/>
List-Post: <mailto:ipsec@ietf.org>
List-Help: <mailto:ipsec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ipsec>, <mailto:ipsec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Dec 2022 13:56:52 -0000

Lars Eggert has entered the following ballot position for
draft-ietf-ipsecme-ikev1-algo-to-historic-08: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ 
for more information about how to handle DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-ipsecme-ikev1-algo-to-historic/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

# GEN AD review of draft-ietf-ipsecme-ikev1-algo-to-historic-08

CC @larseggert

Thanks to Roni Even for the General Area Review Team (Gen-ART) review
(https://mailarchive.ietf.org/arch/msg/gen-art/rK3E1XT4aINFH14eXi90vEqPa0o).

## Nits

All comments below are about very minor potential issues that you may choose to
address in some way - or ignore - as you see fit. Some were flagged by
automated tools (via https://github.com/larseggert/ietf-reviewtool), so there
will likely be some false positives. There is no need to let me know what you
did with these suggestions.

### Typos

#### Section 4.2, paragraph 1
```
-    method was never standarized in IKEv1.  Those IKEv1 systems that
+    method was never standardized in IKEv1.  Those IKEv1 systems that
+                            +
```

### Outdated references

Reference `[RFC4306]` to `RFC4306`, which was obsoleted by `RFC5996` (this may
be on purpose).

Reference `[RFC2407]` to `RFC2407`, which was obsoleted by `RFC4306` (this may
be on purpose).

Reference `[RFC2409]` to `RFC2409`, which was obsoleted by `RFC4306` (this may
be on purpose).

Reference `[RFC2408]` to `RFC2408`, which was obsoleted by `RFC4306` (this may
be on purpose).

### URLs

These URLs point to tools.ietf.org, which has been taken out of service:

 * https://tools.ietf.org/id/draft-ietf-ipsecme-labeled-ipsec-06.txt

### Grammar/style

#### Section 6, paragraph 1
```
ocument instructs IANA to add an additional Status column to the IKEv2 Transf
                          ^^^^^^^^^^^^^^^^^^^^^^^^
```
This phrase might be redundant. Consider either removing or replacing the
adjective "additional".

#### Section 7, paragraph 5
```
ment] Figure 3 Transform Type 4 - Diffie Hellman Group Transform IDs Number
                                  ^^^^^^^^^^^^^^
```
This word is normally spelled with a hyphen.

## Notes

This review is in the ["IETF Comments" Markdown format][ICMF], You can use the
[`ietf-comments` tool][ICT] to automatically convert this review into
individual GitHub issues. Review generated by the [`ietf-reviewtool`][IRT].

[ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md
[ICT]: https://github.com/mnot/ietf-comments
[IRT]: https://github.com/larseggert/ietf-reviewtool