Re: [Isis-wg] draft-eastlake-isis-trill-00.txt

mike shand <mshand@cisco.com> Fri, 25 June 2010 08:06 UTC

Return-Path: <mshand@cisco.com>
X-Original-To: isis-wg@core3.amsl.com
Delivered-To: isis-wg@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 2CADC3A6846 for <isis-wg@core3.amsl.com>; Fri, 25 Jun 2010 01:06:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -10.599
X-Spam-Level:
X-Spam-Status: No, score=-10.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, RCVD_IN_DNSWL_HI=-8]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0e9Fxsx-aWSQ for <isis-wg@core3.amsl.com>; Fri, 25 Jun 2010 01:06:30 -0700 (PDT)
Received: from rtp-iport-1.cisco.com (rtp-iport-1.cisco.com [64.102.122.148]) by core3.amsl.com (Postfix) with ESMTP id 95C273A69F4 for <isis-wg@ietf.org>; Fri, 25 Jun 2010 01:06:30 -0700 (PDT)
Authentication-Results: rtp-iport-1.cisco.com; dkim=neutral (message not signed) header.i=none
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AvsEAM//I0xAZnwN/2dsb2JhbACfQXGmKJpTgneCKgQ
X-IronPort-AV: E=Sophos;i="4.53,479,1272844800"; d="scan'208";a="125309666"
Received: from rtp-core-2.cisco.com ([64.102.124.13]) by rtp-iport-1.cisco.com with ESMTP; 25 Jun 2010 08:06:38 +0000
Received: from [10.61.106.123] (dhcp-10-61-106-123.cisco.com [10.61.106.123]) by rtp-core-2.cisco.com (8.13.8/8.14.3) with ESMTP id o5P86blC024582 for <isis-wg@ietf.org>; Fri, 25 Jun 2010 08:06:38 GMT
Message-ID: <4C24638D.9060302@cisco.com>
Date: Fri, 25 Jun 2010 09:06:37 +0100
From: mike shand <mshand@cisco.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.1.10) Gecko/20100512 Lightning/1.0b1 Thunderbird/3.0.5
MIME-Version: 1.0
To: isis-wg@ietf.org
References: <AANLkTikhOPPBmFjQo7geYIo4Rv9FqICCCBE9X-fRjBUs@mail.gmail.com> <AANLkTikyMSGnwxlBwrtvO03ZmajgvjMHCxFCCmJROtbQ@mail.gmail.com> <CB068181C8EA45C4A356FF5BD84E661C@vishwasd520> <AANLkTimI1VvHAIgsqwbQXbSy7jCgdLGV9SuAzBl-QFYe@mail.gmail.com>
In-Reply-To: <AANLkTimI1VvHAIgsqwbQXbSy7jCgdLGV9SuAzBl-QFYe@mail.gmail.com>
Content-Type: text/plain; charset="windows-1252"; format="flowed"
Content-Transfer-Encoding: 8bit
Subject: Re: [Isis-wg] draft-eastlake-isis-trill-00.txt
X-BeenThere: isis-wg@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: IETF IS-IS working group <isis-wg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/isis-wg>, <mailto:isis-wg-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/isis-wg>
List-Post: <mailto:isis-wg@ietf.org>
List-Help: <mailto:isis-wg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/isis-wg>, <mailto:isis-wg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Jun 2010 08:06:32 -0000

I agree with Donald that we don't want to unnecessarily burn the TLV 
codespace, and that the overhead of the occasional large sub-TLV within 
a TLV is not significant.

     Mike


On 25/06/2010 03:56, Donald Eastlake wrote:
> Hi Vishwas,
>
> On Sun, Jun 20, 2010 at 11:13 PM, Vishwas Manral<vishwas@ipinfusion.com>  wrote:
>    
>> Hi Don,
>>
>> I had a cursory look at the draft.
>>
>> I thought there was one issue you need to consider which might change the
>> shape of the draft itself. Unlike all other protocols IS-IS TLV’s has a
>> length field of only 8 bits which means that having sub-TLV’s which are very
>> big is not preferred. Seeing the size of sub-TLV’s defined it seems we will
>> as well need different TLV’s for each sub-TLV. I would think it is better to
>> define them as separate TLV’s.
>>      
> Thanks for your comment. I guess it would be nice for TRILL if some or
> all of the proposed sub-TLVs were TLVs. But TLV types are a limited
> resource.
>
> I've done a scan of the draft. I don't see any problem with the fixed
> length sub-TLVs, which are small. They should fit fine within the TLV
> specified to contain them. There are also a number of variable length
> sub-TLVs. But I believe that, in many cases, these variable length
> sub-TLVs will be fairly short. And in cases where they are larger,
> perhaps not fitting in a single enclosing TLV, the enclosing TLV can
> be repeated and I don't think the two bytes of overhead per repetition
> are a big deal.
>
> So, if there is a consensus to change one or more of these sub-TLVs to
> TVLs, I'd be happy to do that. Otherwise, I don't plan to make such
> changes.
>
>    
>> Have a look at the TE related TLV’s. You will notice that SRLG is a separate
>> TLV in itself (if memory serves me right). Let me go through the draft and
>> give you information about the content itself.
>>      
> SRLG? RFC 5305 specified three TLVs:
>        Extended IS Reachability
>        Traffic Engineering Router ID
>        Extended IP Reachability
>
>    
>> Thanks,
>> Vishwas
>>      
> Thanks,
> Donald
>
>    
>> ________________________________
>>
>> From: isis-wg-bounces@ietf.org [mailto:isis-wg-bounces@ietf.org] On Behalf
>> Of Donald Eastlake
>> Sent: Sunday, June 20, 2010 7:32 PM
>> To: isis mailing list
>> Subject: Re: [Isis-wg] draft-eastlake-isis-trill-00.txt
>>
>>
>>
>> A error has been pointed out on the TRILL WG mailing list:
>>
>> In Section 2.5, Page 17, Length is "1 + 9*n" not "2 + 9*n".
>>
>>
>>
>> Thanks,
>>
>> Donald
>>
>> On Fri, Jun 11, 2010 at 1:53 PM, Donald Eastlake<d3e3e3@gmail.com>  wrote:
>>
>> Hi,
>>
>>
>>
>> I've submitted a draft proposing IS-IS support for TRILL:
>>
>> http://tools.ietf.org/html/draft-eastlake-isis-trill-00
>>
>> Thanks,
>>
>> Donald
>>
>> =============================
>> Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
>> 155 Beaver Street
>> Milford, MA 01757 USA
>> d3e3e3@gmail.com
>>
>>
>>      
> _______________________________________________
> Isis-wg mailing list
> Isis-wg@ietf.org
> https://www.ietf.org/mailman/listinfo/isis-wg
>
>    

-- 
For corporate legal information go to:
www.cisco.com/web/about/doing_business/legal/cri