[Isis-wg] AD Review of draft-ietf-isis-prefix-attributes-09

Alia Atlas <akatlas@gmail.com> Thu, 03 December 2015 21:14 UTC

Return-Path: <akatlas@gmail.com>
X-Original-To: isis-wg@ietfa.amsl.com
Delivered-To: isis-wg@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BF0EC1ACD68; Thu, 3 Dec 2015 13:14:06 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -101.999
X-Spam-Level:
X-Spam-Status: No, score=-101.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dNvF_Y1xQwek; Thu, 3 Dec 2015 13:14:05 -0800 (PST)
Received: from mail-ob0-x22e.google.com (mail-ob0-x22e.google.com [IPv6:2607:f8b0:4003:c01::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1B5931ACD55; Thu, 3 Dec 2015 13:14:05 -0800 (PST)
Received: by obbnk6 with SMTP id nk6so60878214obb.2; Thu, 03 Dec 2015 13:14:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=98mdeaTh9+HNn7lUH3Go8n9RbhHEnj3pWl9J2NOW/TI=; b=JQy0xkO3y0GO7H4RNLiOFAVWLj3Yj9FTo4z+5lQGEVAEFDLa5WMPTImfszg5bDMrc6 uPl98KVXkapVD3fFMhaWUbT3HsF5qnaumDHmsQOKyzdZY+zyq9vzbzIsVQQ5sT85ckVc DFGK6GwxyBVSZZYPLdcZYAosEYAjkzXFuyzPuhF8iadCkOepSoQubhgJbYV/1yag297J PbDSZrHuUPeziVxtC5MlNltwTFZmR8Mxj4AhjDgmg6faRgZm9xL2q/mHascjJgx5Vo1E 4mUATql6BGghdodJ4wID1PRZdYQLuOLQD+hGghtROO0D2HpJZwGJMf9Vd9QppgkvVv/e i35A==
MIME-Version: 1.0
X-Received: by 10.60.67.234 with SMTP id q10mr9786927oet.73.1449177244536; Thu, 03 Dec 2015 13:14:04 -0800 (PST)
Received: by 10.60.177.103 with HTTP; Thu, 3 Dec 2015 13:14:04 -0800 (PST)
Date: Thu, 03 Dec 2015 16:14:04 -0500
Message-ID: <CAG4d1rfToDWjcfdPm7-8paowk8ZTpdZvTp14rMd0SxD3B3y-Aw@mail.gmail.com>
From: Alia Atlas <akatlas@gmail.com>
To: "isis-wg@ietf.org" <isis-wg@ietf.org>, draft-ietf-isis-prefix-attributes@ietf.org
Content-Type: multipart/alternative; boundary="001a11c3229ce0970e052604de56"
Archived-At: <http://mailarchive.ietf.org/arch/msg/isis-wg/JH-TeVtTKg3GSJd6J0U-33O70Ys>
Subject: [Isis-wg] AD Review of draft-ietf-isis-prefix-attributes-09
X-BeenThere: isis-wg@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: IETF IS-IS working group <isis-wg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/isis-wg>, <mailto:isis-wg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/isis-wg/>
List-Post: <mailto:isis-wg@ietf.org>
List-Help: <mailto:isis-wg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/isis-wg>, <mailto:isis-wg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Dec 2015 21:14:06 -0000

Hi,

As is customary, I have done my AD review of this draft before progressing
it.
First, let me thank you for a well-written draft and the work you have put
into it.

Next, I believe that a revised version is needed.

1)  This draft has 7 authors.  The limit is 5; you can pick an editor if
you can't trim
down to 5.  I can, of course, listen to a clear write-up of contributions
made by each
author of this 7 page draft, if you feel that an exception is truly
warranted.   Until this
issue is addressed, I will not progress this draft.

2) The Security Considerations section is completely empty.  You know that
this
needs to be filled in - if only as a reference to the existing ISIS
security and a bit
on why sending additional information isn't a concern.

3)  As a minor kvetch (meaning that you don't have to agree), I'd prefer to
see
a bit of motivation or how this is expected to be used.  There's a very
small amount
of motivation from SR - but that doesn't really explain the need to send
the originating
Router ID.

4) Clarifying question:  When a prefix has the external prefix flag set and
the Router ID is sent, is that the Router ID of the router that is doing
the redistribution or of the original advertising router (if it were
available)?

If you can address these issues quickly, then I can issue an IETF Last Call
and we can have
it on the agenda for the Jan 7, 2016 telechat.  That means that I can issue
the IETF Last Call no later than Dec 17.

Thanks,
Alia