Re: [Jmap] [art] Artart last call review of draft-ietf-jmap-smime-08

Alexey Melnikov <alexey.melnikov@isode.com> Fri, 24 September 2021 11:39 UTC

Return-Path: <alexey.melnikov@isode.com>
X-Original-To: jmap@ietfa.amsl.com
Delivered-To: jmap@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5BF783A253E; Fri, 24 Sep 2021 04:39:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=isode.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id X_vP_7CxG3Ch; Fri, 24 Sep 2021 04:39:51 -0700 (PDT)
Received: from statler.isode.com (Statler.isode.com [62.232.206.189]) by ietfa.amsl.com (Postfix) with ESMTP id AA0113A2541; Fri, 24 Sep 2021 04:39:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1632483589; d=isode.com; s=june2016; i=@isode.com; bh=Jkr8Qd2AgcAF5dtLYfXTmSvzaS4SjEbxJjoukH8NC+M=; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version: In-Reply-To:References:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description; b=CRdlbGpB27ikdgEed3UyDl09509Ys8ppbloGcu10p+Fa8JBTP6O1Wig1a8ekuB+vSBx8q9 pBrnqqLAd+IOpVGTUugkF5lcM2JhTVb+RNzHa6MsQJz2TFGViF7lg8d2YEFP04or7WyLy7 2pwIV/TnQxIDdpJpds+e28EEWawq0Ow=;
Received: from smtpclient.apple ((unknown) [185.69.144.156]) by statler.isode.com (submission channel) via TCP with ESMTPSA id <YU25BQBY=w-5@statler.isode.com>; Fri, 24 Sep 2021 12:39:49 +0100
X-SMTP-Protocol-Errors: NORDNS
From: Alexey Melnikov <alexey.melnikov@isode.com>
In-Reply-To: <163232991808.32122.9195451729619651354@ietfa.amsl.com>
Date: Fri, 24 Sep 2021 12:39:47 +0100
Cc: art@ietf.org, jmap@ietf.org, draft-ietf-jmap-smime.all@ietf.org, last-call@ietf.org
Message-Id: <8C7AC576-1748-4AAC-B720-45206A1051E7@isode.com>
References: <163232991808.32122.9195451729619651354@ietfa.amsl.com>
To: Kirsty Paine <kirsty.p@ncsc.gov.uk>
X-Mailer: iPad Mail (18G82)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/jmap/Pj4za9FdmnXw6W3JdRUXbh2m1DU>
Subject: Re: [Jmap] [art] Artart last call review of draft-ietf-jmap-smime-08
X-BeenThere: jmap@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: JSON Message Access Protocol <jmap.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/jmap>, <mailto:jmap-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/jmap/>
List-Post: <mailto:jmap@ietf.org>
List-Help: <mailto:jmap-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/jmap>, <mailto:jmap-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Sep 2021 11:39:58 -0000

Kirsty,
Thank you for your thorough review.
Quickly replying to a couple of your points and I will reply in more details in a separate email.

> On 22 Sep 2021, at 18:00, Kirsty Paine via Datatracker <noreply@ietf.org> wrote:
 [snip]
> 
> Section 4:
>  •  
>    The "string" values that are allowed for smimeStatus and smimeErrors do not
> explicitly mention the allowable charsets (standard ART area guidance). In IETF
> protocols, UTF-8 is preferred - see RFC 2277 (BCP 18), Sections 3.1 and 3.2.
> Please reference this and make it explicit what characters are allowed. •      
> Similarly, this draft has protocol elements that contain human-readable text,
> so you need to specify language tags for those fields, or justify why language
> tagging is not needed. There is text that alludes to this in smimeErrors,
> saying "in the language specified in the Content-Language header field, if any"
> – but there's no language stipulation for others, e.g. smimeStatus where it
> says "Servers MAY return other values not defined below."
smimeStatus use tokens, not free form human readable text, so use of language tags is not appropriate for it. But I will check if this can be clarified.

 [snip]

> Section 6
> •       I'm not sure why
> 10 minutes specifically is recommended – it seems to be landed there without
> rationale and without conveying why it's not longer/shorter.

It seemed like a reasonable default and making it configurable seemed like overkill (and a way to introduce unnecessary complexity into the protocol).
To be honest the proposed default hasn’t been discussed in the WG, so if you have an alternative proposal, it would be great to hear.

Best Regards,
Alexey