[Jmap] draft-ietf-jmap-blob-05 Review
Robert Stepanek <rsto@fastmailteam.com> Thu, 04 November 2021 07:26 UTC
Return-Path: <rsto@fastmailteam.com>
X-Original-To: jmap@ietfa.amsl.com
Delivered-To: jmap@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 26D503A09FB for <jmap@ietfa.amsl.com>; Thu, 4 Nov 2021 00:26:37 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.1
X-Spam-Level:
X-Spam-Status: No, score=-2.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=fastmailteam.com header.b=WA2C5Ayo; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=XTDrQT92
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4WOhV31OdKvf for <jmap@ietfa.amsl.com>; Thu, 4 Nov 2021 00:26:31 -0700 (PDT)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 875E83A0A00 for <jmap@ietf.org>; Thu, 4 Nov 2021 00:26:31 -0700 (PDT)
Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 979B55C0184 for <jmap@ietf.org>; Thu, 4 Nov 2021 03:26:29 -0400 (EDT)
Received: from imap43 ([10.202.2.93]) by compute6.internal (MEProxy); Thu, 04 Nov 2021 03:26:29 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= fastmailteam.com; h=mime-version:message-id:date:from:to:subject :content-type; s=fm1; bh=XKMWfPkDx1cn2sUwZMUOa5Fjm2Clbq+MhnT6fUG 1C8A=; b=WA2C5AyorVuobcfqE/ozj3gF5XE+wm8vuKErNxxvlAzj4P5Ct6rvWD9 jeZ5n2mkJicvnRpVIElqSqh+IWHuU+GnP6nq1MOo3ZnNpRENUdYQCbL2PIPybYzu R6qzdMbzSAKcu8PavCtCGj0vysZDWLsIytbkuClIVY4ZKRLZpVCG5khR+iykmp2n a06CyGDM6hbRuFMzjqdaWWq4kPVsbihL9nEfcLCx/JNZbpp/cxvTBHNI8EL9/UcA ybQFvuvsIszSk8fu/feN7X1txi6280Wa8NnqA1PobSy20amKYyEHRQsc4116Hmk0 lOm9wQIJozvUWLP/25S4TVODNiQpLPQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=XKMWfPkDx1cn2sUwZMUOa5Fjm2Clb q+MhnT6fUG1C8A=; b=XTDrQT92V64HxHN2VsbGb/fLNfISLPP72xGkwAGdSmNQl 8bsjZIYMXlsBOUNVADBe2+kVlqCgqQW2UDwlFOdRyOEs8Fft5ByWtjzTMjeVcHt2 nu1sX034wQyzw4/hMsI2rMm1eWmkQG9GFZED+c9V/aRIfG4qDQxlzu8XNaiq/Xvh YmsC3mYyfpHzuJ6L4x3KY3prWjUhYElxStpmcbapM5jY9Rc3RMQ5EzflC+F4TV97 aRKjlnd+1V9yVl2M7PYsKwxQ0Y9scxS32lNzdiMx1bEL8B/m51sV5bC9zWiJ/3En ofcC0qBbm4O/Os1gd3WaZiQtBDYjYVyJWqYt7kRUw==
X-ME-Sender: <xms:JYuDYcUuxSe4TU_pJPCljmGxFPIkeVzmrY9fWr_x8EuxLQbeFQNalg> <xme:JYuDYQkEjFL6ikEapJr4zIOw6Qn9PKvlvkazi0fkaf95Isjbl5xzKTJGxqDr8KN2f QwfliLb1VnKmg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrtdefgddutdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfffhffvufgtsegrtderre erredtnecuhfhrohhmpedftfhosggvrhhtucfuthgvphgrnhgvkhdfuceorhhsthhosehf rghsthhmrghilhhtvggrmhdrtghomheqnecuggftrfgrthhtvghrnhepgeeikeehkeehhe fhtdehvedvhffghfetudeljeetffdtkeeuleeufeevfedviedunecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprhhsthhosehfrghsthhmrghilh htvggrmhdrtghomh
X-ME-Proxy: <xmx:JYuDYQYm6m5JvdEMQv-rASrR6eXyJ9yNUgOW4OT_799T-4qUnO0fIQ> <xmx:JYuDYbUARx71LA6bN3ZnEukD0cH85SGO5yfBQ5061nDCy2B1etYF3w> <xmx:JYuDYWmv_YdTWlEHC7hvtyimW0dNkeSPZhwS9-TCuKwBS5sjIbdgOA> <xmx:JYuDYSzNQEJWKdVocpFSOKlFBcryieUk7AOUKPFmgl-FFM81NhFd3Q>
Received: by mailuser.nyi.internal (Postfix, from userid 501) id 67832AC0DD1; Thu, 4 Nov 2021 03:26:29 -0400 (EDT)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.5.0-alpha0-1420-gdf09e8761c-fm-20211101.001-gdf09e876
Mime-Version: 1.0
Message-Id: <6d42064a-16c9-4484-abd6-a67cf608ab54@www.fastmail.com>
Date: Thu, 04 Nov 2021 08:26:09 +0100
From: Robert Stepanek <rsto@fastmailteam.com>
To: jmap@ietf.org
Content-Type: multipart/alternative; boundary="243cf3de1d1a4ce49123329f6ff9e966"
Archived-At: <https://mailarchive.ietf.org/arch/msg/jmap/pr60W2zk_xQygOmVVt_l5eAMxwQ>
Subject: [Jmap] draft-ietf-jmap-blob-05 Review
X-BeenThere: jmap@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: JSON Message Access Protocol <jmap.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/jmap>, <mailto:jmap-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/jmap/>
List-Post: <mailto:jmap@ietf.org>
List-Help: <mailto:jmap-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/jmap>, <mailto:jmap-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Nov 2021 07:26:37 -0000
Looks good to me, except: Section 4.1.1: the asText/asBase64/asHex forms are stated here without explanation of their semantics. They are defined later in the draft in Section 4.2, and there only as result properties. Section 4.1.2: does not define which SetError type to return in notUpdated? Cheers, Robert
- [Jmap] draft-ietf-jmap-blob-05 Review Robert Stepanek