IETF Logo Mail Archive

Re: [jose] Opsdir review of draft-ietf-jose-jwk-thumbprint-05

Mike Jones <Michael.Jones@microsoft.com> Tue, 23 June 2015 18:44 UTC

Return-Path: <Michael.Jones@microsoft.com>
X-Original-To: jose@ietfa.amsl.com
Delivered-To: jose@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 33EE51B2F50; Tue, 23 Jun 2015 11:44:03 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.902
X-Spam-Level:
X-Spam-Status: No, score=-1.902 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id C5YcIUBdQ3zX; Tue, 23 Jun 2015 11:44:01 -0700 (PDT)
Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0134.outbound.protection.outlook.com [65.55.169.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6DF251B2F6B; Tue, 23 Jun 2015 11:44:01 -0700 (PDT)
Received: from BLUPR03MB439.namprd03.prod.outlook.com (10.141.78.151) by BLUPR03MB1507.namprd03.prod.outlook.com (10.163.81.25) with Microsoft SMTP Server (TLS) id 15.1.195.15; Tue, 23 Jun 2015 18:43:59 +0000
Received: from BLUPR03MB437.namprd03.prod.outlook.com (10.141.78.147) by BLUPR03MB439.namprd03.prod.outlook.com (10.141.78.151) with Microsoft SMTP Server (TLS) id 15.1.201.11; Tue, 23 Jun 2015 18:43:58 +0000
Received: from BLUPR03MB437.namprd03.prod.outlook.com ([10.141.78.147]) by BLUPR03MB437.namprd03.prod.outlook.com ([10.141.78.147]) with mapi id 15.01.0201.000; Tue, 23 Jun 2015 18:43:58 +0000
From: Mike Jones <Michael.Jones@microsoft.com>
To: Sarah Banks <sbanks@encrypted.net>, "draft-ietf-jose-jwk-thumbprint.all@tools.ietf.org" <draft-ietf-jose-jwk-thumbprint.all@tools.ietf.org>, "<ops-dir@ietf.org>" <ops-dir@ietf.org>
Thread-Topic: Opsdir review of draft-ietf-jose-jwk-thumbprint-05
Thread-Index: AQHQreN/GfDuatcgVUW5AsbFAychwZ26bIVQ
Date: Tue, 23 Jun 2015 18:43:58 +0000
Message-ID: <BLUPR03MB437271C9E968FD842B376A4F5A00@BLUPR03MB437.namprd03.prod.outlook.com>
References: <545A3564-B70F-40A4-A787-B582DFDD5D53@encrypted.net>
In-Reply-To: <545A3564-B70F-40A4-A787-B582DFDD5D53@encrypted.net>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: encrypted.net; dkim=none (message not signed) header.d=none;
x-originating-ip: [50.47.90.173]
x-microsoft-exchange-diagnostics: 1; BLUPR03MB439; 5:q7n3wUPbmCG9+tZ08HnD7HZFZhi6D6z4iwEZVbZ0x01lWIz8u/7AVAUGZ1cU3Tuy5CWZxDDH1Hhu2S08yz20+/lT7RBKSUGavGoI0EcCMAUpulMoXzkEvIMFUkKT6ZwJlsdtiVIvXBr0LQ4k/o+j7Q==; 24:dPC21M1Y0LTsv3by+qSqGP/Si9Gfxv/VBjdO3K6oUMd4RV7ASxWc+jdqaYMRNhsktacM9s8iR4w3Iw86K3j0rpSHaJFqpGikmOgqvQLwK9o=; 20:p7I6rC+2iw13d4L3EpXKA7FElbKnkZmfmIybsyTbMk+7wxCqi3oK8ay4NQ+DtDM7C2SmSL2PO/2MVasOg4Xsxg==
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:; SRVR:BLUPR03MB439; UriScan:; BCL:0; PCL:0; RULEID:; SRVR:BLUPR03MB1507;
x-microsoft-antispam-prvs: <BLUPR03MB439506F5EF5EBCD08208B4BF5A00@BLUPR03MB439.namprd03.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:;
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401001)(5005006)(3002001); SRVR:BLUPR03MB439; BCL:0; PCL:0; RULEID:; SRVR:BLUPR03MB439;
x-forefront-prvs: 06167FAD59
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(13464003)(377454003)(51914003)(164054003)(2900100001)(2950100001)(2501003)(77096005)(5001960100002)(102836002)(5002640100001)(5003600100002)(15975445007)(5001770100001)(230783001)(189998001)(76576001)(74316001)(99286002)(66066001)(106116001)(86362001)(19580395003)(19580405001)(87936001)(46102003)(2656002)(92566002)(50986999)(54356999)(40100003)(62966003)(76176999)(122556002)(86612001)(77156002)(33656002)(491001); DIR:OUT; SFP:1102; SCL:1; SRVR:BLUPR03MB439; H:BLUPR03MB437.namprd03.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en;
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2015 18:43:58.8456 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB439
X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1507; 2:DKojk9nLpIFuHNnq90755L1BNnzBmBbkux43PxUy/bfU+nzpqXg4P8jZQxCQAoG4; 3:l1+/VU6w43Dec10G0SPJY4bt2SVhe3nk/yEk8ELzLSYkZt16u7vMAKFZukQIRvzs4CHNlE0HrGBoWWyR0jP8Uvwc93KA40rddS3hBhgCs9GwXswxTuvFYb9ewM/keedYy0NKsv6Nou+d/PerhYaEBg==; 23:sFXA2L/55ZKYioMi++sRy8ajWRME5mDnKChnHQZLaMJI7JUv+OgsdbkiH0pTapNX+VVuqlnSFw8xyHyoRg8rhEQO1zWnxc5HORxp79QJwdVhP3GrFfx9MLQVbTtLacR4yRNAcqpBpT+zOzoFTia6srcLqXl9TQEqV2gUgFfqiQGuWPUZRrZeZU18W4oYY/lTHVlBAlG0Ojhc0RMcNYyCI6DPY/ofFBy8Ie6DuljzqJaZPlWGHDId8YuKbl6CaTey
X-OriginatorOrg: microsoft.com
Archived-At: <http://mailarchive.ietf.org/arch/msg/jose/IOya1kPoXxweFyR2SOByzXgnta4>
Cc: "jose@ietf.org" <jose@ietf.org>
Subject: Re: [jose] Opsdir review of draft-ietf-jose-jwk-thumbprint-05
X-BeenThere: jose@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Javascript Object Signing and Encryption <jose.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/jose>, <mailto:jose-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/jose/>
List-Post: <mailto:jose@ietf.org>
List-Help: <mailto:jose-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/jose>, <mailto:jose-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Jun 2015 18:44:03 -0000

Thanks for the review, Sarah.  Could you send us a link to the review comments in the tools?  (I poked around, including at https://svn.tools.ietf.org/area/ops/trac/wiki/Directorates, and couldn't find the review comments.)

				Thanks,
				-- Mike

-----Original Message-----
From: Sarah Banks [mailto:sbanks@encrypted.net] 
Sent: Tuesday, June 23, 2015 11:36 AM
To: draft-ietf-jose-jwk-thumbprint.all@tools.ietf.org; <ops-dir@ietf.org>
Subject: Opsdir review of draft-ietf-jose-jwk-thumbprint-05

I have reviewed this document as part of the Operational directorate's ongoing effort to review all IETF documents being processed by the IESG.  These comments were written with the intent of improving the operational aspects of the IETF drafts. Comments that are not addressed in last call may be included in AD reviews during the IESG review.  Document editors and WG chairs should treat these comments just like any other last call comments.

Document reviewed:  draft-ietf-jose-jwk-thumbprint-05

Summary: Ready to go, no nits, 5 comments (see tools).

Overall, if I were implementing this in code, I'd appreciate the preamble, thanks for the clear description. I also appreciate that the security section was well considered and discussed. I have no major comments, other than that it read like .. an algorithm to me, and I was a bit surprised to see it on the Standards track, rather than informational, but that's just a comment, not a nit or problem. The draft is ready to go.

Thanks
Sarah

v2.23.0 | Report a Bug | By Email