[Jsonpath] Opsdir last call review of draft-ietf-jsonpath-base-16
Joe Clarke via Datatracker <noreply@ietf.org> Wed, 02 August 2023 17:00 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: jsonpath@ietf.org
Delivered-To: jsonpath@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id B816FC151094; Wed, 2 Aug 2023 10:00:00 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Joe Clarke via Datatracker <noreply@ietf.org>
To: ops-dir@ietf.org
Cc: draft-ietf-jsonpath-base.all@ietf.org, jsonpath@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 11.5.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <169099560074.55569.16694235228971863023@ietfa.amsl.com>
Reply-To: Joe Clarke <jclarke@cisco.com>
Date: Wed, 02 Aug 2023 10:00:00 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/jsonpath/1wV-eyFu56IAuldjTUlAvXpXFa4>
Subject: [Jsonpath] Opsdir last call review of draft-ietf-jsonpath-base-16
X-BeenThere: jsonpath@ietf.org
X-Mailman-Version: 2.1.39
List-Id: A summary description of the list to be included in the table on this page <jsonpath.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/jsonpath>, <mailto:jsonpath-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/jsonpath/>
List-Post: <mailto:jsonpath@ietf.org>
List-Help: <mailto:jsonpath-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/jsonpath>, <mailto:jsonpath-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Aug 2023 17:00:00 -0000
Reviewer: Joe Clarke Review result: Ready I have been tasked to review this draft on behalf of OPS DIR. When I got the assignment I thought, "64 pages of JSONPath...this is going to hurt." But I found this document very well-written and informative. All in all, it was an easy and enjoyable read. I like that examples were both frequent and addressed positive and negative cases. I also liked how the authors addressed the origin of JSONPath and the rationale for creating a standard and why the standard might deviate from other usages. That said, I expected to see a more thorough comparison of the original unofficial JSONPath specification and what is being standardized. For example, I like https://cburgmer.github.io/json-path-comparison/ as a means to know how JSONPath is implemented in each language. I'm not saying this draft needs such an extensive comparison of all languages, but perhaps specific instances where it deviates from its direct and explicit ancestor would be helpful. I had two comments otherwise: * In Section 1.5, two of your examples use parentheses whereas in Section 1.4.3 the book example filter does not. I didn't find clear guidance on when to use the paren-expression and when not to. * In Section 2.3.5.2, sentence, "Applied to primitive values, it selects nothing." my gut was perhaps an additional, "and MUST NOT raise and error" should be added to be explicit that in this case an empty nodelist is expected and not an error. Moreover, as I read further and "Nothing" is called out as a special type, I felt some explicit text that an empty nodelist is returned would add clarity.
- [Jsonpath] Opsdir last call review of draft-ietf-… Joe Clarke via Datatracker
- Re: [Jsonpath] Opsdir last call review of draft-i… Glyn Normington
- Re: [Jsonpath] Opsdir last call review of draft-i… Joe Clarke (jclarke)
- Re: [Jsonpath] Opsdir last call review of draft-i… Glyn Normington
- Re: [Jsonpath] Opsdir last call review of draft-i… Tim Bray
- Re: [Jsonpath] Opsdir last call review of draft-i… Carsten Bormann
- Re: [Jsonpath] Opsdir last call review of draft-i… Tim Bray
- Re: [Jsonpath] Opsdir last call review of draft-i… Greg Dennis
- Re: [Jsonpath] Opsdir last call review of draft-i… Joe Clarke (jclarke)
- Re: [Jsonpath] [OPS-DIR] Opsdir last call review … Joe Clarke (jclarke)
- Re: [Jsonpath] Opsdir last call review of draft-i… Carsten Bormann
- Re: [Jsonpath] Opsdir last call review of draft-i… Joe Clarke (jclarke)
- Re: [Jsonpath] [Last-Call] Opsdir last call revie… Rob Sayre
- Re: [Jsonpath] [OPS-DIR] Opsdir last call review … Greg Dennis
- Re: [Jsonpath] [OPS-DIR] Opsdir last call review … Glyn Normington
- Re: [Jsonpath] [OPS-DIR] Opsdir last call review … Joe Clarke (jclarke)