IETF Logo Mail Archive

[Lake] PRs on encoding clarification and invalid test vectors

John Mattsson <john.mattsson@ericsson.com> Fri, 08 September 2023 08:52 UTC

Return-Path: <john.mattsson@ericsson.com>
X-Original-To: lake@ietfa.amsl.com
Delivered-To: lake@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 16AD3C151067 for <lake@ietfa.amsl.com>; Fri, 8 Sep 2023 01:52:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.109
X-Spam-Level:
X-Spam-Status: No, score=-2.109 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Fsuv3bqDv0Pv for <lake@ietfa.amsl.com>; Fri, 8 Sep 2023 01:51:55 -0700 (PDT)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2045.outbound.protection.outlook.com [40.107.8.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 79CA1C14CF18 for <lake@ietf.org>; Fri, 8 Sep 2023 01:51:55 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nvlJh/srsE3D8j77YhxmW6ULUPf4FyeS7dPdKn5FoRGLcpHsP04C1KgREBSPWhVwauDXj1hcgr1kxdQQCCz9hOQXwqDQWxmhlex+1O/4AV/C7XOFQ8McFmB4LtwwO7IgZUFzidEf+NnLKVmuifjyP2R+wU6A2nWzyplGQYDmMe0lpMiD2N5IwsPcHYLw4eKkCAfcKxdSNuGWCCcEjQEp8/P4WmMAXGxDQ4nFG9I+5ZpBxPrnhL5m9N5bRW3Z3/6spGUa38onNrnfRIyW0nSbJnj0QJnOUmaiykDSAoPagjWouP0mxILviIbhU92uRoFkn1hDil+XqkhQcN2lUjiisg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RUtKORVrxZNfbLzZCv5ZvpLvB61gjIYvbAPSUmvTtzk=; b=aAkwEU+/Ng3qV1QbkTZFbb1pMxj/8oKQzemV603d0muMSkSmbYxK+SjX2vwPMCGUMSxKZlhIMTcpvs2lTG5FuMRACPtOmcgdbcKFfoUIxeu75waqrjTXpgvWWI0sF0My+4KqGebzLTjBEx+s1mGK+pode5ELL+OF03wUI9kQmakALStTgXxg29yCnVeJXuXiTggabMiWdoDUAQhZt3wesbz9acy0CH7WiJcymmKGU1RAiV0kyF4goVK5cbmJFdw540jna0QDg63gox2KvkJokSfXXHACK7o0+b50sYZnOu+xwCuiZd44aLXaTsWwoIWbzoyeckUeJWeqd9Re5os3cQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RUtKORVrxZNfbLzZCv5ZvpLvB61gjIYvbAPSUmvTtzk=; b=WasjFnFhjN5/64pTXFoE4cMpgr/o2y4uHP/jqBaAzwb7KWxSkNYv7x1j7W+30Si1O24Wy1taxDsNwOJlSJj6xkmy6El/sYoz4Y4wueTeGFjdTrYKzQ+uXSMkOQx1oOMPnLdsNl+Qp/ElNCm5KquSkKBJ9S/yZ6md2umPjdAcQvo=
Received: from GVXPR07MB9678.eurprd07.prod.outlook.com (2603:10a6:150:114::10) by AS2PR07MB9148.eurprd07.prod.outlook.com (2603:10a6:20b:55b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.34; Fri, 8 Sep 2023 08:51:52 +0000
Received: from GVXPR07MB9678.eurprd07.prod.outlook.com ([fe80::cf5e:848b:9613:bfd]) by GVXPR07MB9678.eurprd07.prod.outlook.com ([fe80::cf5e:848b:9613:bfd%7]) with mapi id 15.20.6745.034; Fri, 8 Sep 2023 08:51:52 +0000
From: John Mattsson <john.mattsson@ericsson.com>
To: "lake@ietf.org" <lake@ietf.org>
Thread-Topic: PRs on encoding clarification and invalid test vectors
Thread-Index: AQHZ4i0ljlAen5sWNkS9IwAH8RL0OQ==
Date: Fri, 08 Sep 2023 08:51:52 +0000
Message-ID: <GVXPR07MB9678CD3AA66FB02D6969993389EDA@GVXPR07MB9678.eurprd07.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=ericsson.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: GVXPR07MB9678:EE_|AS2PR07MB9148:EE_
x-ms-office365-filtering-correlation-id: 00f28fb0-9d23-40f2-cd35-08dbb048d8b5
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: jRGZGTOr6/fXXxaf+kq1B6yeGg74AzSOyD1jAfnoVProWcCY63UlYF/GGhzZT5pfp7iDgP+WnUwNJ2cwnEU7RZqwrx2Gd0Qw5OrK5oRH+Fe4f8QrQJ9YQzMJhMy4+iA5ugVXA4MA7GIQ0PqIoFsx/VMvVs7QAMykuAcJ5sbtLNETvNavqx3TyOH7tVVVt11SHFUwCxcdC35GxOYNEBDXzZ3c3pvXpahUS4a5eNeABJpFKUlcdVVBK4nKCrlyid83bKRy1XPVCLuuJKQ5I8jSwz3+MDQjrt9DL3eByOEMCPToqRxFCEpxcrsMHzkKwab5Ze//iYA5LJMuBdIP7eCLQ8rFXWEaHygXFfsw2whJ+WoMbpJxvscUOwuvgBULD5agUn88w0YjaWlMi4cOo1Mm+eQilJBiGeHRIwWG6jmzqyqN4/FHsff80jriv5vusuMVxPWoYdFkITSlfH6wE1TdQYprPvKYS/OX21zOz3O8wctb/ArxCVVkvmCOyqucRWCTl0P1NbtVMq0CNlm+YjLAGJNuZQiC4eX8AShwgmZBy21GmwRS4jFXelzluMS7qnJ9SLLTyyY5+H3R2oC8ONPA3/gNVODvIHCSxvAXfKTICZrb36kDtg0aoGWXr6847RSuNkDvidtQEylYuvxB+wO1DTsvNgyFeaYKeumIsfyFr6PtecS6gs/klwUEzLkr64lf
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:GVXPR07MB9678.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(396003)(39860400002)(376002)(346002)(136003)(1800799009)(451199024)(186009)(55016003)(6506007)(71200400001)(83380400001)(316002)(26005)(66476007)(66556008)(76116006)(6916009)(66446008)(64756008)(66946007)(8676002)(5660300002)(52536014)(41300700001)(44832011)(966005)(2906002)(7696005)(8936002)(478600001)(9686003)(82960400001)(86362001)(33656002)(38070700005)(166002)(38100700002)(122000001); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 8fOnUcCzAiCOpiDiSEj2Ilu7M00ty/Wws4p7N5Qm9I0f4xcUCTSbsaDoeUyCStfacxmt2ZFo+Upthv9uJ6VxYhUV6L4dgBCx5TSwrEF+/Wr9RC9wALA0cRg/qBVDu9+y4n1rBoH6GCLRu3DmcZ0tvtZ0wf9mdwFWeR4quubsGDKR7DCeSI6IwV9pDGM15FxZI3hPdfdwcpZFKEi3PE/fGcGaNTq+kPr3uQ0Ruelplm6iMuMWmZqp442reTkbVevLNXVQYE0tV/hglr+uL9JrYyozBL9kq02Lvh0sgyE+L7JXibNVdPOLRxY2gSTJFRp62R08awxl+koGPVT4+tdssb00LPV8qFu+ICZakf36E43IUsIfCrFAnQR1wud7BO+EEnT8oT2WNvK/sGJoqm5/n2VrOd3pCvekjB2Gzpu8Vpi5jx3I/vF+HqSeIA9K6CK7afR+kLFR8GsM5xsKNqIqSG2W07ar2/ag24NdGIZBIsgePT8a2+m9ptk2axqMyWfGMQjJq1hEtDCg1FGJKhbucIHuITXWhVMvuooysnzZLq66Ts3vaeXov+6/MMazzf1oCDmoeogtqTqUrFatUnueix7tgo95ofXyOxwq4e0L5oPD2qGBe8FURufxNBlk9k6OI53Fhfy0eIFYZxnbiTP/rde2vt8xyt3WDX4nwdO01VqgWHKy4omsqV/Cm+LLGw7S6EGEGfIHFsCNryIgbWPlveNvlKIx7s7Pv1+aN2lN9L8XtdwMlYKBl0Ya8UVrbSuRr8bm36Qcu+PM5XCR99THDREQge70dkiWMyvyNFLlMmxZmIzhEpKhDXe/64AtBthLBuNFW+nqviS7NNDJL7i0WPilTZ74mm67kBwprMiJyY7Fb4XieTFxlJ7Gt712KXOtSk4nA06zRTfZXBGd3Fj9VY5roZPBNwAPKObak6Xq2dzjiJtMejoLWOa7hmS8f0PFnpWSu8iVfaBUXQwX/oFQhIp84yUkZnDSH3n49OsI6jnV9vALfwUmHf+z5eYabGQ0DifZUvobq964qu0J2WcciHXBYRCnXZahLBJlksEgDtiZSrwhLqDomD0PLc15oknBXIElbndYBeYYtEiIf1dgUvJ4WYCiDRoTE2KRxj4cyCziHWdFJ2Ono7p3zp01elwlObuk4S7iF7dSNeBARG0jw6YWc70bt3gs1HrsXAqoWZnWqnZX0xNFE0ds9ctgyAvu/Oit6pYUFbJUeEQChtllvDeER7qoURmwYr4gk7gkrfTtEwokv24dZzWdw3JsEiKP/gfNJb6Tytfr4fJWvabWMGm8EfDRRvJWZYXG1x+qg6VEi3U5BX7+80XwCfWQC8XshzWbX0b+vLw7Mt88PY4uL79zsr2CSM43yllT7d/URXSSNLWFxAeu1n1ESrQThyxIweeEDEw24/P7BCtFCikFYKfwWIIAOUD8Pb4uMdsIzwkHjjRL2SDOD52mgA5OyElrC0dJQkHDUvXLQTgQ35Utiu1kvwhl01iDLtIdyk+0U605giMHNSnffFCjahtr9aRFV/8IS1eZ/paf3HR0d4BtsGDy1Pd4BWxyGAU6wwz6vFxwBhVMsGM5Det5kVdez/cxLQ6qmFWO5MdbmVCwcfA8mtP/9l72ll0e2sKf7EvcDpE=
Content-Type: multipart/alternative; boundary="_000_GVXPR07MB9678CD3AA66FB02D6969993389EDAGVXPR07MB9678eurp_"
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: GVXPR07MB9678.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 00f28fb0-9d23-40f2-cd35-08dbb048d8b5
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2023 08:51:52.2860 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: l0g+H1pVjuz0ynxaUTF5DhYjvxanJspwGCkxbWrr4qrtoB/neFOaVpJLkR4WYEL9b6BaUVw65j6MZPuEszxTV+D2IjgWLxnEcjY5zFrrBzs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR07MB9148
Archived-At: <https://mailarchive.ietf.org/arch/msg/lake/FVwT4gcF-rgZMZ2NdgSfiSEWPHo>
Subject: [Lake] PRs on encoding clarification and invalid test vectors
X-BeenThere: lake@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Lightweight Authenticated Key Exchange <lake.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lake>, <mailto:lake-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lake/>
List-Post: <mailto:lake@ietf.org>
List-Help: <mailto:lake-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lake>, <mailto:lake-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Sep 2023 08:52:00 -0000

Hi,

The authors and implementors have worked on producing invalid test vectors, as well as clarifying instructions on encoding and validation. This has been very worthwhile and caught implementation problems and needed clarifications to the specification.

https://github.com/lake-wg/edhoc/pull/446
https://github.com/lake-wg/edhoc/pull/442

Suggestion to add to the EDHOC specification:
”For X25519 and X448, the all-zero output check MUST be done.” as suggested by Charlie but forgotten.
- “Implementations MUST abort the EDHOC session if validation of a received public key fails.”, which was missing.
- “Implementations MAY abort the EDHOC session if the received EDHOC message is not encoded using deterministic CBOR.” instead of the unnecessary hard SHOULD abort.
- CDDL for PLAINTEXT_2, PLAINTEXT_3, and PLAINTEXT_4, which were missing. There is an existing MUST abort if the CDDL does not match.

The plan is to:
- include the traces PR in the next version of the draft.
- include the EDHOC PR duing AUTH48.

Plese review and let us know if you disagree.

Cheers,
John

v2.23.0 | Report a Bug | By Email