Re: [Lake] PRs on encoding clarification and invalid test vectors

Paul Wouters <paul.wouters@aiven.io> Mon, 11 September 2023 20:02 UTC

Return-Path: <paul.wouters@aiven.io>
X-Original-To: lake@ietfa.amsl.com
Delivered-To: lake@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1CBCEC137393 for <lake@ietfa.amsl.com>; Mon, 11 Sep 2023 13:02:12 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.106
X-Spam-Level:
X-Spam-Status: No, score=-2.106 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=aiven.io
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SqrlzRtiQgpz for <lake@ietfa.amsl.com>; Mon, 11 Sep 2023 13:02:08 -0700 (PDT)
Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 25001C137399 for <lake@ietf.org>; Mon, 11 Sep 2023 13:02:08 -0700 (PDT)
Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-52bcd4db4cbso6119004a12.1 for <lake@ietf.org>; Mon, 11 Sep 2023 13:02:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aiven.io; s=google; t=1694462526; x=1695067326; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=6RF+wyuVm1dzZ79D05qLXZw7tCnHbHqIeHV4qvxilP4=; b=INMWah8ETdaMo3yz4+jVwu+lr7DoYw4yt76PgXwMAc3ineWOMrKXcLktpaB/s37Bpc FpQlRDjq32ddyC7CcZFEjjGXTiJDXuZbAO6vcA1OtknzZSaDpXUGujeJat5eB2Ibd/i+ IiiDd9AnSjEXNIOMjq4NBLCB5DNrkBiPYsJf8=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694462526; x=1695067326; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6RF+wyuVm1dzZ79D05qLXZw7tCnHbHqIeHV4qvxilP4=; b=cPAW3mcnKzO33XwmAzeKQkBZzQsKEOEpTTLA3tmdTOeFWwyTXAyamhEW4NuacqFesf qQxmoElea8MBNq4fHQ96TLJ1UGUqgYZOSd+lwydjhdFtCQapscNBnopqdKu4UhjDTXdP /GuVjpzluht4q4THvaKgW3FGNPnM9YhgS71xI2pf6RFJJkqyjaWEW6Ar6d+9+bB8mKgA 5gyO3L7Nn4sqaIkdUhJdWor4w2mBhFzVp85/s6UWaOydLC73BlsnI66H58IQ+OcyJPHV WIQtB/8G2MTOTs3GhOTeqPj2kHvi2pcM3pZHAa7pziUXA5QvXWT8vYxZD6BPJnUQrDuz CEog==
X-Gm-Message-State: AOJu0YwjCaSeU1vt0X8V+JaD1ilLexnPBgkWz51zgqXkcskBx7KZCSPy EYFF5HpI0gcffkYk66QDdXPFlWAeQwuzhHQ60yDS1NeK5ZcOi0gY+z8=
X-Google-Smtp-Source: AGHT+IF9SEeLF6V5xQhaTJTeuF0ZRRkhxopfEMEhfHIMYCyhvXc7F9lhZT7TQVZDmzj235XuPCLHtGRzie8QFBsfKeA=
X-Received: by 2002:aa7:d512:0:b0:525:69c8:6f51 with SMTP id y18-20020aa7d512000000b0052569c86f51mr8252387edq.35.1694462526332; Mon, 11 Sep 2023 13:02:06 -0700 (PDT)
MIME-Version: 1.0
References: <GVXPR07MB9678CD3AA66FB02D6969993389EDA@GVXPR07MB9678.eurprd07.prod.outlook.com> <97DE3D72-EA2F-4085-81C9-E7DFA083FBDE@aiven.io> <GVXPR07MB96788761EDD4677114AF6D7989ECA@GVXPR07MB9678.eurprd07.prod.outlook.com>
In-Reply-To: <GVXPR07MB96788761EDD4677114AF6D7989ECA@GVXPR07MB9678.eurprd07.prod.outlook.com>
From: Paul Wouters <paul.wouters@aiven.io>
Date: Mon, 11 Sep 2023 16:01:55 -0400
Message-ID: <CAGL5yWbcPMVSQHURq_5gzD9pvwJ=GyT7iy7mn-MDkds5sZ7uWw@mail.gmail.com>
To: John Mattsson <john.mattsson=40ericsson.com@dmarc.ietf.org>
Cc: John Mattsson <john.mattsson@ericsson.com>, "lake@ietf.org" <lake@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000f839b206051acca1"
Archived-At: <https://mailarchive.ietf.org/arch/msg/lake/G7-3FOn2tmtcvAmT_RquEiRfONo>
Subject: Re: [Lake] PRs on encoding clarification and invalid test vectors
X-BeenThere: lake@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Lightweight Authenticated Key Exchange <lake.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lake>, <mailto:lake-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lake/>
List-Post: <mailto:lake@ietf.org>
List-Help: <mailto:lake-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lake>, <mailto:lake-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Sep 2023 20:02:12 -0000

On Sat, Sep 9, 2023 at 2:30 AM John Mattsson <john.mattsson=
40ericsson.com@dmarc.ietf.org> wrote:

> Hi Paul,
>
>
>
> https://github.com/lake-wg/edhoc/pull/442
>
>
>
> Is a PR to the traces draft with invalid test vectors. The work before
> focused more or less only on valid test vectors. I wish we had looked at
> this earlier, but I think it very good that we did now.
>

For the traces draft, just submit a new draft please. It has not yet
entered the RFC Editor queue.


> https://github.com/lake-wg/edhoc/pull/446
>
>
>
> Is my collection of things that are not optimal in the EDHOC draft. These
> were found during the work on invalid traces. The PR contains two things:
>
>
>
> 1. Sender side and wire format: Minor clarifications and corrections on
> encoding. These are editorial thing that I intend to bring up in my AUTH48
> review. I just did this part of my AUTH48 review early.
>

>
> 2. Receiver side: Some suggested changes to what a receiver does with
> various types of invalid encoding. This would involve changes to RFC2119
> words and therefore goes beyond clarification and corrections and I
> therefore send it to the WG. I think the topic of what to do with different
> types of invalid messages was ignored a bit. These changes do not change
> the requirements on the sender or the wire format at all.
>

Please send an email with instructions to the RFC Editor (
rfc-editor@rfc-editor.org) now, and CC: me (as AD). Please do not wait for
AUTH48.

 I think the current text on when to abort invalid messages is not optimal.
> On the otherhand it is things that are 100% in the receiver implementations
> and does not affect the sender or the wire format. While changes would be
> good it is not 100% essential, a receiver implementation can do this
> anyway. I don't know what "pause the publication process" would mean. These
> changes would clearly need consensus in the WG, but I don’t know what the
> exact process would be. I assume that is partly up to the AD.
>

Create a PR, notify the list. Then after a few days send email to the RFC
Editor and CC: me (as AD). I guess these two requests to the RFC Editor
should be folded into one request though.

Paul



>
> Cheers,
>
> John
>
> *From: *Lake <lake-bounces@ietf.org> on behalf of Paul Wouters
> <paul.wouters=40aiven.io@dmarc.ietf.org>
> *Date: *Friday, 8 September 2023 at 15:59
> *To: *John Mattsson <john.mattsson=40ericsson.com@dmarc.ietf.org>
> *Cc: *lake@ietf.org <lake@ietf.org>
> *Subject: *Re: [Lake] PRs on encoding clarification and invalid test
> vectors
>
> On Sep 8, 2023, at 04:52, John Mattsson <john.mattsson=
> 40ericsson.com@dmarc.ietf.org> wrote:
>
>
>
> 
>
> The plan is to:
>
> - include the traces PR in the next version of the draft.
>
> - include the EDHOC PR duing AUTH48.
>
>
>
> No PRs should be merged during AUTH48.
>
>
>
> Are you talking about the edhoc draft or the edhoc-traces draft ?
>
>
>
> We can pause the publication process if needed.
>
>
>
> Paul
>