[Last-Call] Intdir telechat review of draft-ietf-lsr-pce-discovery-security-support-12

Carlos Pignataro via Datatracker <noreply@ietf.org> Tue, 11 October 2022 14:06 UTC

MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Carlos Pignataro via Datatracker <noreply@ietf.org>
To: int-dir@ietf.org
Cc: draft-ietf-lsr-pce-discovery-security-support.all@ietf.org, last-call@ietf.org, lsr@ietf.org
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <166549721104.35846.9858835884158053058@ietfa.amsl.com>
Reply-To: Carlos Pignataro <cpignata@cisco.com>
Date: Tue, 11 Oct 2022 07:06:51 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/3EXIi2tUqJaPrkkJt-FhmTBVJiw>
Subject: [Last-Call] Intdir telechat review of draft-ietf-lsr-pce-discovery-security-support-12

Reviewer: Carlos Pignataro
Review result: Ready with Nits

This document defines a mechanism (flags and sub-TLV) to advertise via the PCE
Protocol security required within the IGP being used.

This is a very well written, clear, and sensible document. In my opinion, it is 
Ready.

Flagging some potential nits:

Abstract:
Old:
   capability.  Further, this document updates RFC 8231, and RFC 8306.
New:
   capability.  Further, this document updates RFC 8231 and RFC 8306.

Question:
The header and Section 4 say this updates RFCs 5088 and 5089; however, 
that is not mentioned in the Abstract.

Old:
   The YANG model for PCEP [I-D.ietf-pce-pcep-yang] supports PCEP
   security parameters (key, key chain and TLS).
New:
   The YANG model for PCEP [I-D.ietf-pce-pcep-yang] supports PCEP
   security parameters (key, key chain, and TLS).

Thanks!

Carlos.

[Last-Call] Intdir telechat review of draft-ietf-… Carlos Pignataro via Datatracker
Re: [Last-Call] [Pce] Intdir telechat review of d… Dhruv Dhody
Re: [Last-Call] [Pce] Intdir telechat review of d… Carlos Pignataro (cpignata)