[Last-Call] Secdir last call review of draft-ietf-bess-evpn-lsp-ping-08

Rifaat Shekh-Yusef via Datatracker <noreply@ietf.org> Tue, 11 October 2022 13:54 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: last-call@ietf.org
Delivered-To: last-call@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 943DAC159A2F; Tue, 11 Oct 2022 06:54:29 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Rifaat Shekh-Yusef via Datatracker <noreply@ietf.org>
To: secdir@ietf.org
Cc: bess@ietf.org, draft-ietf-bess-evpn-lsp-ping.all@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 8.17.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <166549646960.63193.4258994849223360241@ietfa.amsl.com>
Reply-To: Rifaat Shekh-Yusef <rifaat.s.ietf@gmail.com>
Date: Tue, 11 Oct 2022 06:54:29 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/OHMZEYMVMIHV3TGXHipV-PmscAY>
Subject: [Last-Call] Secdir last call review of draft-ietf-bess-evpn-lsp-ping-08
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.39
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Oct 2022 13:54:29 -0000

Reviewer: Rifaat Shekh-Yusef
Review result: Has Nits

I have reviewed this document as part of the security directorate's ongoing
effort to review all IETF documents being processed by the IESG.  These
comments were written primarily for the benefit of the security area directors.

Document editors and WG chairs should treat these comments just like any other
last call comments.

LSP Ping is a widely deployed Operation, Administration, and
Maintenance mechanism in MPLS networks.  This document describes
mechanisms for detecting data plane failures using LSP Ping in MPLS
based EVPN and PBB-EVPN network

Summary: Ready

This document builds on top of an existing and widely deployed mechanism, by
adding new TLVs to the LSP Ping mechanism. The existing mechanism security
properties are well defined in existing standards, and this document does not
seem to make any changes that impacts the existing security properties.

I did not see any mention of potential impact of the new TLVs on privacy. It
would be nice if that could be addressed in the security considerations section.