[Last-Call] Opsdir last call review of draft-ietf-pce-lsp-extended-flags-05

Bo Wu via Datatracker <noreply@ietf.org> Tue, 11 October 2022 13:31 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: last-call@ietf.org
Delivered-To: last-call@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 877E4C159A21; Tue, 11 Oct 2022 06:31:11 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Bo Wu via Datatracker <noreply@ietf.org>
To: ops-dir@ietf.org
Cc: draft-ietf-pce-lsp-extended-flags.all@ietf.org, last-call@ietf.org, pce@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 8.17.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <166549507154.15634.8141913864387586124@ietfa.amsl.com>
Reply-To: Bo Wu <lana.wubo@huawei.com>
Date: Tue, 11 Oct 2022 06:31:11 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/RBE3Z2S2c7yO6JTkW0q7q1xHcLY>
Subject: [Last-Call] Opsdir last call review of draft-ietf-pce-lsp-extended-flags-05
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.39
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Oct 2022 13:31:11 -0000

Reviewer: Bo Wu
Review result: Has Nits

I have reviewed this document as part of the Operational directorate's ongoing
effort to review all IETF documents being processed by the IESG.

The draft defines the PCE LSP object flag extension. The original 12 bits flags
have been allocated, but a new individual draft requires new flags. In summary,
the document is ready, with only small issues.

Major issues:

Minor issues:
Introduction:
The bits from 1 to 3 are assigned in [RFC8623] for Explicit
   Route Object (ERO)-compression, fragmentation and Point-to-Multipoint
   (P2MP) respectively.

[Bo Wu] Here uses ERO object. But the title and abstract say Label Switched
Path (LSP) Object Flag Extension, contradict?

5.  Backward Compatibility
   The LSP-EXTENDED-FLAG TLV defined in this document does not introduce any
   interoperability issues.
[Bo Wu] I feel there are interoperability issues introduced, correct? But the
issue will be resolved by the future use?

Nits/editorial comments:
Introduction:
OLD
The bit value 4 is assigned in [RFC8281] for create for PCE-Initiated
   LSPs.
New
The bit value 4 is assigned in [RFC8281] for creation and deletion for
PCE-Initiated LSPs.