Re: [Last-Call] [tsvwg] Opsdir last call review of draft-ietf-tsvwg-aqm-dualq-coupled-24

Sheng Jiang <shengjiang@gmail.com> Tue, 30 August 2022 23:27 UTC

Return-Path: <shengjiang@gmail.com>
X-Original-To: last-call@ietfa.amsl.com
Delivered-To: last-call@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4A61EC1524DF; Tue, 30 Aug 2022 16:27:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.104
X-Spam-Level:
X-Spam-Status: No, score=-7.104 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Mx6tBTmaBTpA; Tue, 30 Aug 2022 16:27:34 -0700 (PDT)
Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EBFE0C15256A; Tue, 30 Aug 2022 16:27:27 -0700 (PDT)
Received: by mail-wr1-x434.google.com with SMTP id bu22so15783538wrb.3; Tue, 30 Aug 2022 16:27:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=jnd8S9swLCo0iBMxlCHNYJmpeKYYc+zoYxGCKYsUy5E=; b=aCS4xm3zZbD9oiVqrUyUXXni6leLXiiGNbD6T9tCw8PxdExgy+4a19RkLjnesktoMb j4t7LjmyXNR/G/2TDRzz2dYpUjxcpwnzMrfbLsY/4ehEWeLvMaolr3IgWS8Kv4jASFn/ /R6g7J399PKHztNafyVEhBWWQFBVsEmpyweP/q4dG1g0TR1qe9VTRPexr/J9/H4sbOD4 3XrchiLDrAsXWBADY+n3YC4ifRlK/0riSThJyhrlSzY9ATbJfj7PjkDvWKPYgkCYxx2I Ei8Y+JROqalbb+956ZmlTwUme0xNzCk6EKzKVKBfyOOTa4aodLnivj0tWWgLiaDeI6Oz zvEg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=jnd8S9swLCo0iBMxlCHNYJmpeKYYc+zoYxGCKYsUy5E=; b=T7eSjFsFnAysGR38BW5+iZG04vQDD/C3guaG9IPuvUuuWGiZGQEvPt7j/hFi3bgP0z sPQo9EpmQMtifVNZhsCpzvd78gNrVvJhr7H8Mwzn4LxBPnnZ/myVqWVWbrXuC+hC0cmx VW/kvQ3N7kRl8Q/d1sDZFAXsaHUxxQ3HhMzgzCHc6TcqwYMbw1B6QPwfTeQakGQKd5ef q09gwu2Lbv6od3EcMLlo27I7l2vviy+sGbnDiczWsSfGSnEyQNwa5me99/Mb0xXEsvNy Hi2DakrLvAyEf6QDnphjmagxW9h3x+98SZdn9po5+UEa1SB+ouOm98022rBq0cPWW7rj GGkQ==
X-Gm-Message-State: ACgBeo0hrgJVjjLa+dsHUMOWVCg8+sHklQ2VVsHFs8WOe2Y5hwrTHO5T XgHCFiS+VlC7DNsYpChfSdWw6vz9wrN7MmpS7wt9YiyY
X-Google-Smtp-Source: AA6agR59YlLLiThcqUXPS+in9oJyJF0lxMDcPhYY4qXFO0/1Ap+l962b6sHkccLMX3p8IVNdWZ3PJi6rHHJnOrFR4l8=
X-Received: by 2002:adf:d1c4:0:b0:225:6f39:78ae with SMTP id b4-20020adfd1c4000000b002256f3978aemr10081935wrd.691.1661902046117; Tue, 30 Aug 2022 16:27:26 -0700 (PDT)
MIME-Version: 1.0
References: <166150819817.15288.14179198336101724610@ietfa.amsl.com> <73a69492-cb2a-3465-7bcc-e0bc964621e6@bobbriscoe.net>
In-Reply-To: <73a69492-cb2a-3465-7bcc-e0bc964621e6@bobbriscoe.net>
From: Sheng Jiang <shengjiang@gmail.com>
Date: Wed, 31 Aug 2022 07:27:13 +0800
Message-ID: <CAL6Yo0LiPBrRwN9ZXZLZFgrSgWgBkoofBAKM_BOvt4E4QKGf1A@mail.gmail.com>
To: Bob Briscoe <in@bobbriscoe.net>
Cc: ops-dir@ietf.org, draft-ietf-tsvwg-aqm-dualq-coupled.all@ietf.org, last-call@ietf.org, tsvwg@ietf.org
Content-Type: multipart/alternative; boundary="0000000000001c430605e77db95b"
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/7doTVU72fzgTJhhkA9nRl8Yc8dg>
Subject: Re: [Last-Call] [tsvwg] Opsdir last call review of draft-ietf-tsvwg-aqm-dualq-coupled-24
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Aug 2022 23:27:38 -0000

Hi, Bob,

If you have documented the reasons that ECT can be used and the other
questions you mentioned in another document, it is worth of mentioning it
in this document and reference to the another document. I am fine with your
explanations. Overall, I do not know L4S much. I just review it from the
general operational perspective.

Thank and regards,

Sheng

On Sun, 28 Aug 2022 at 02:20, Bob Briscoe <in@bobbriscoe.net> wrote:

> Sheng,
>
> Pls see [BB]...
>
> On 26/08/2022 11:03, Sheng Jiang via Datatracker wrote:
> > Reviewer: Sheng Jiang
> > Review result: Has Issues
> >
> > Reviewer: Sheng Jiang
> > Review result: Has Issues
> > Document: draft-ietf-tsvwg-aqm-dualq-coupled-24
> > Review Date: 2022-08-26
> >
> > I have reviewed this document as part of the Operational directorate's
> ongoing
> > effort to review all IETF documents being processed by the IESG. These
> comments
> > were written with the intent of improving the operational aspects of the
> IETF
> > drafts. Comments that are not addressed in last call may be included in
> AD
> > reviews during the IESG review. Document editors and WG chairs should
> treat
> > these comments just like any other last call comments.
> >
> > This experimental document defines a framework for coupling the AQM
> algorithms
> > in two queues intended for flows with different responses to congestion.
> It is
> > the network part of the L4S architecture that enables both very low
> queuing
> > latency and high throughput at the same time.
> >
> > I have concerns on the operational description in this document. This
> document
> > claims its mechanims can be deployed in the current network. But it
> lacks the
> > description on how and why it can works back-compatibly. I heard there
> were
> > intensive debate regarding to the usage of ECT (I did not participate it
> > myself), but the document has not introduced the reason or background
> why it is
> > allowed to use ECT from the urgement.
>
> [BB] I'm afraid this comment is directed at the wrong draft, because it
> confuses two things:
> * This document (DualQ) is about where a bottleneck buffer /has/ been
> updated with L4S support. The DualQ draft is entirely about a backwards
> compatibility mechanism.
> * The intensive debates were about possible cases where a bottleneck
> buffer had previously supported Classic RFC3168 ECN, and it had /not/
> been updated for L4S.
>
> The remedies for the second case are in the requirements for L4S sending
> hosts, which is where that debate was directed (
> draft-ietf-tsvwg-ecn-l4s-id ). The WG has now moved past that debate,
> onto the next stage, which is to measure the size and severity of this
> issue, experiment with the required backward compatibility mechanisms in
> senders and to record all this in the l4sops draft.
>
> The main question was how prevalent cases might be where L4S and non-L4S
> flows could compete in a queue that supports Classic RFC3168 ECN, versus
> whether they would nearly always be separated by a per-flow scheduler,
> and how serious and how sustained the problem would be if they did mix
> sometimes. That's nothing to do with this DualQ draft.
>
> >
> > Another minor comments, there is another reason that can cause the result
> > mentioned in 4.2: if irresponsible terminals labels classic ect(0) flows
> into
> > l4s ect(1), it would overload l4s queue.
>
> [BB] That's not the case with this DualQ system. The two queues feed
> into the same capacity, and either queue can use it all. So there's no
> more overload if traffic is switched from one to the other, even if
> source(s) are unresponsive. And the system is designed so that the
> priority scheduler gives no advantage to overload with ECT1. Because if
> the total load into both queues is greater than the capacity, the
> overload mechanism kicks in. It couples the two queues together as one,
> and applies an equal proportion of AQM drop to both. Here's the overload
> experiments showing that, which were explained in the WG:
> https://l4steam.github.io/overload-results/
>
> Thank you for taking the time to write up your review.
>
>
> Bob
>
> >
> > Regards,
> >
> > Sheng
> >
> >
> >
>
> --
> ________________________________________________________________
> Bob Briscoe                               http://bobbriscoe.net/
>
>

-- 
Sheng Jiang