Re: [Last-Call] [tsvwg] Opsdir last call review of draft-ietf-tsvwg-aqm-dualq-coupled-24

Bob Briscoe <in@bobbriscoe.net> Wed, 31 August 2022 07:58 UTC

Return-Path: <in@bobbriscoe.net>
X-Original-To: last-call@ietfa.amsl.com
Delivered-To: last-call@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4BA67C1524D1; Wed, 31 Aug 2022 00:58:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.106
X-Spam-Level:
X-Spam-Status: No, score=-2.106 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, NICE_REPLY_A=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=bobbriscoe.net
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2dJjEMmzMTtp; Wed, 31 Aug 2022 00:58:01 -0700 (PDT)
Received: from mail-ssdrsserver2.hostinginterface.eu (mail-ssdrsserver2.hostinginterface.eu [185.185.85.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 58FBFC1522C1; Wed, 31 Aug 2022 00:57:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=bobbriscoe.net; s=default; h=In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Content-Type:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=EWA15w0lV+l0NhHu3oc0p9j1HpkFp4+mQC16K/VY/+Y=; b=f30STIxm5lHqo+Rp5bO0rip0Sr HCj/9NFUKEfbRxIwdnvlyNHwhfYPPNgpCbqh+a+h2dczP2DNfC98tnGP8yB/ykKtXADPJQTCYR2zU c7bDUVFctj9p2xLd38dz/hEnuMan3I7mIzterm6rwe3sRX9CyYLoZXRfhEhmEbcMLOrU0XCKCcil+ Vi87pmF7ZkJi6kgVIt0GnclLCOSP1cpicnHZAJp1nKWjZMYB3oLSxR+BzswD7AQRb03TaoRQSaKMW hlBZm2H11oO+8n4F/QmPemcaO2qN6RSpNZIy93sbQrQkrOhJRPbBRebBRAtF/Gtf8CTo0qk/gRYsa 6nLjc8AQ==;
Received: from 67.153.238.178.in-addr.arpa ([178.238.153.67]:54716 helo=[192.168.1.11]) by ssdrsserver2.hostinginterface.eu with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.95) (envelope-from <in@bobbriscoe.net>) id 1oTIbm-0008Ip-2s; Wed, 31 Aug 2022 08:57:53 +0100
Content-Type: multipart/alternative; boundary="------------mhlHkTigsGh7rDXFNe0HtIg8"
Message-ID: <515f6f73-e971-55cd-98fd-22cce6d14887@bobbriscoe.net>
Date: Wed, 31 Aug 2022 08:57:51 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0
Content-Language: en-GB
To: Sheng Jiang <shengjiang@gmail.com>
Cc: ops-dir@ietf.org, draft-ietf-tsvwg-aqm-dualq-coupled.all@ietf.org, last-call@ietf.org, tsvwg@ietf.org
References: <166150819817.15288.14179198336101724610@ietfa.amsl.com> <73a69492-cb2a-3465-7bcc-e0bc964621e6@bobbriscoe.net> <CAL6Yo0LiPBrRwN9ZXZLZFgrSgWgBkoofBAKM_BOvt4E4QKGf1A@mail.gmail.com>
From: Bob Briscoe <in@bobbriscoe.net>
In-Reply-To: <CAL6Yo0LiPBrRwN9ZXZLZFgrSgWgBkoofBAKM_BOvt4E4QKGf1A@mail.gmail.com>
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - ssdrsserver2.hostinginterface.eu
X-AntiAbuse: Original Domain - ietf.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - bobbriscoe.net
X-Get-Message-Sender-Via: ssdrsserver2.hostinginterface.eu: authenticated_id: in@bobbriscoe.net
X-Authenticated-Sender: ssdrsserver2.hostinginterface.eu: in@bobbriscoe.net
X-Source:
X-Source-Args:
X-Source-Dir:
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/ySp10lrMkmY1Y46F5UNBQIBCvlY>
Subject: Re: [Last-Call] [tsvwg] Opsdir last call review of draft-ietf-tsvwg-aqm-dualq-coupled-24
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Aug 2022 07:58:05 -0000

Sheng,

On 31/08/2022 00:27, Sheng Jiang wrote:
> Hi, Bob,
>
> If you have documented the reasons that ECT can be used and the other 
> questions you mentioned in another document, it is worth of mentioning 
> it in this document and reference to the another document. I am fine 
> with your explanations. Overall, I do not know L4S much. I just review 
> it from the general operational perspective.

[BB] ecn-l4s-id is a normative reference in this aqm-dualq-coupled 
draft, which cites it 19 times.


Bob


>
> Thank and regards,
>
> Sheng
>
> On Sun, 28 Aug 2022 at 02:20, Bob Briscoe <in@bobbriscoe.net> wrote:
>
>     Sheng,
>
>     Pls see [BB]...
>
>     On 26/08/2022 11:03, Sheng Jiang via Datatracker wrote:
>     > Reviewer: Sheng Jiang
>     > Review result: Has Issues
>     >
>     > Reviewer: Sheng Jiang
>     > Review result: Has Issues
>     > Document: draft-ietf-tsvwg-aqm-dualq-coupled-24
>     > Review Date: 2022-08-26
>     >
>     > I have reviewed this document as part of the Operational
>     directorate's ongoing
>     > effort to review all IETF documents being processed by the IESG.
>     These comments
>     > were written with the intent of improving the operational
>     aspects of the IETF
>     > drafts. Comments that are not addressed in last call may be
>     included in AD
>     > reviews during the IESG review. Document editors and WG chairs
>     should treat
>     > these comments just like any other last call comments.
>     >
>     > This experimental document defines a framework for coupling the
>     AQM algorithms
>     > in two queues intended for flows with different responses to
>     congestion. It is
>     > the network part of the L4S architecture that enables both very
>     low queuing
>     > latency and high throughput at the same time.
>     >
>     > I have concerns on the operational description in this document.
>     This document
>     > claims its mechanims can be deployed in the current network. But
>     it lacks the
>     > description on how and why it can works back-compatibly. I heard
>     there were
>     > intensive debate regarding to the usage of ECT (I did not
>     participate it
>     > myself), but the document has not introduced the reason or
>     background why it is
>     > allowed to use ECT from the urgement.
>
>     [BB] I'm afraid this comment is directed at the wrong draft,
>     because it
>     confuses two things:
>     * This document (DualQ) is about where a bottleneck buffer /has/ been
>     updated with L4S support. The DualQ draft is entirely about a
>     backwards
>     compatibility mechanism.
>     * The intensive debates were about possible cases where a bottleneck
>     buffer had previously supported Classic RFC3168 ECN, and it had /not/
>     been updated for L4S.
>
>     The remedies for the second case are in the requirements for L4S
>     sending
>     hosts, which is where that debate was directed (
>     draft-ietf-tsvwg-ecn-l4s-id ). The WG has now moved past that debate,
>     onto the next stage, which is to measure the size and severity of
>     this
>     issue, experiment with the required backward compatibility
>     mechanisms in
>     senders and to record all this in the l4sops draft.
>
>     The main question was how prevalent cases might be where L4S and
>     non-L4S
>     flows could compete in a queue that supports Classic RFC3168 ECN,
>     versus
>     whether they would nearly always be separated by a per-flow
>     scheduler,
>     and how serious and how sustained the problem would be if they did
>     mix
>     sometimes. That's nothing to do with this DualQ draft.
>
>     >
>     > Another minor comments, there is another reason that can cause
>     the result
>     > mentioned in 4.2: if irresponsible terminals labels classic
>     ect(0) flows into
>     > l4s ect(1), it would overload l4s queue.
>
>     [BB] That's not the case with this DualQ system. The two queues feed
>     into the same capacity, and either queue can use it all. So
>     there's no
>     more overload if traffic is switched from one to the other, even if
>     source(s) are unresponsive. And the system is designed so that the
>     priority scheduler gives no advantage to overload with ECT1.
>     Because if
>     the total load into both queues is greater than the capacity, the
>     overload mechanism kicks in. It couples the two queues together as
>     one,
>     and applies an equal proportion of AQM drop to both. Here's the
>     overload
>     experiments showing that, which were explained in the WG:
>     https://l4steam.github.io/overload-results/
>
>     Thank you for taking the time to write up your review.
>
>
>     Bob
>
>     >
>     > Regards,
>     >
>     > Sheng
>     >
>     >
>     >
>
>     -- 
>     ________________________________________________________________
>     Bob Briscoe http://bobbriscoe.net/
>
>
>
> -- 
> Sheng Jiang

-- 
________________________________________________________________
Bob Briscoehttp://bobbriscoe.net/