[Last-Call] Rtgdir last call review of draft-ietf-ospf-te-link-attr-reuse-12

Daniele Ceccarelli via Datatracker <noreply@ietf.org> Fri, 29 May 2020 16:18 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: last-call@ietf.org
Delivered-To: last-call@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id B3B683A0D82; Fri, 29 May 2020 09:18:11 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Daniele Ceccarelli via Datatracker <noreply@ietf.org>
To: rtg-dir@ietf.org
Cc: last-call@ietf.org, lsr@ietf.org, draft-ietf-ospf-te-link-attr-reuse.all@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.1.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <159076909169.565.534138764890157419@ietfa.amsl.com>
Reply-To: Daniele Ceccarelli <daniele.ceccarelli@ericsson.com>
Date: Fri, 29 May 2020 09:18:11 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/ZlSQZmtoYdPEI9-ALywpQjlRu-s>
Subject: [Last-Call] Rtgdir last call review of draft-ietf-ospf-te-link-attr-reuse-12
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.29
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 29 May 2020 16:18:12 -0000

Reviewer: Daniele Ceccarelli
Review result: Has Nits

Hello,

I have been selected as the Routing Directorate reviewer for this draft. The
Routing Directorate seeks to review all routing or routing-related drafts as
they pass through IETF last call and IESG review, and sometimes on special
request. The purpose of the review is to provide assistance to the Routing ADs.
For more information about the Routing Directorate, please see
​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs, it would
be helpful if you could consider them along with any other IETF Last Call
comments that you receive, and strive to resolve them through discussion or by
updating the draft.

Document: draft-ietf-ospf-te-link-attr-reuse-12
Reviewer: Daniele Ceccarelli
Review Date: 2020-05-29
IETF LC End Date: date-if-known
Intended Status: Standard Track

Summary:

The readibility of the draft has been significantly improved since my last
review (v07), mostly the abstract and the introduction, which now cleary state
what is the scope of the draft. I also appreciated the introduction of section
3 where a description of the existing solution is described.

Minor issues:
- Section 4.1 - Advantages with respect to RSVP-TE are described while the text
speaks about advantages with respect to RSVP-TE and GMPLS, probably it could be
changed into: advantages with respect to RSVP-TE when used in packet networks
and in GMPLS, something like this. - Section 5 - Why for the UDABM it doens't
say the value MUST be 0,4,8 but rather says "the legal values are" ? Is 8
octets future-proof enough? or conversely, if only 3 values are defined why do
we need 8 octects as option? - Section 8 - I really find it hard to understand
this small section.

Typos:
-  Unidirectional Link Dela [RFC7471]