[Last-Call] Opsdir telechat review of draft-ietf-detnet-ip-oam-12

Yingzhen Qu via Datatracker <noreply@ietf.org> Wed, 14 February 2024 04:09 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: last-call@ietf.org
Delivered-To: last-call@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 8B301C1519A2; Tue, 13 Feb 2024 20:09:03 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Yingzhen Qu via Datatracker <noreply@ietf.org>
To: ops-dir@ietf.org
Cc: detnet@ietf.org, draft-ietf-detnet-ip-oam.all@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.5.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <170788374355.55771.11998499550968611871@ietfa.amsl.com>
Reply-To: Yingzhen Qu <yingzhen.ietf@gmail.com>
Date: Tue, 13 Feb 2024 20:09:03 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/vxGI3XDia41KH_W23m5buxq7Lfk>
Subject: [Last-Call] Opsdir telechat review of draft-ietf-detnet-ip-oam-12
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.39
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Feb 2024 04:09:03 -0000

Reviewer: Yingzhen Qu
Review result: Ready

I've reviewed version 10, and this is a follow up review.

Thanks to the authors for working on this document and addressing my comments.

The document readability has improved a lot from my last review of version -10,
and I believe it is ready for publication.

There are a couple of nits for the authors to consider.

The line numbers are generated using idnits.

160	   is being done by using the Internet Control Message Protocol (ICMP)

nits: there should be a "." in the end.

166	   traffic between DetNet nodes with IP DetNet traffic, e.g., ensure
167	   that such ICMP traffic uses the DetNet IP data plane in each node,

nits: somehow this sentence doesn't read well to me. "uses the DetNet IP
data plane" is not very clear to me, I think you're trying to say ICMP traffic
should go through the same path/interface as DetNet traffic, for example,
there is ECMP between two DetNet nodes.